Patch Detail
Show a patch.
GET /api/1.1/patches/24125/?format=api
{ "id": 24125, "url": "https://patchwork.libcamera.org/api/1.1/patches/24125/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24125/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250815102945.1602071-16-stefan.klug@ideasonboard.com>", "date": "2025-08-15T10:29:35", "name": "[v3,15/19] libipa: agc_mean_luminance: Introduce effectiveYTarget() accessor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f231df56300383d1087d5d3dd80941a7b1fdb858", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24125/mbox/", "series": [ { "id": 5382, "url": "https://patchwork.libcamera.org/api/1.1/series/5382/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5382", "date": "2025-08-15T10:29:20", "name": "Implement WDR algorithm", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5382/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24125/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24125/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAD2FBDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Aug 2025 10:30:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F60D6926A;\n\tFri, 15 Aug 2025 12:30:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F2BE69257\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Aug 2025 12:30:38 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:83d1:ae5d:93a6:6837])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3248219E5; \n\tFri, 15 Aug 2025 12:29:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ej1C5m+0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755253783;\n\tbh=ZhQssLTk6Knl4i/cXB1YEj0E3+qtXJP6XTwKl9chwW8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ej1C5m+0+yGLnkY/dR1fh1HzHMHimsMKwBZepl8BjwVtMG2jqJuuappKBxbRtjC7K\n\tDDnf3SoRctfonYUVdA0kzSqgc3XfzWh4/zgBioEX+TVK2ia/0HreJW3liRqFQHUb/e\n\t6M9Gt3mJp5S1uWewW1sGgbb7ZQVNOPqM52yR8QPw=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v3 15/19] libipa: agc_mean_luminance: Introduce\n\teffectiveYTarget() accessor", "Date": "Fri, 15 Aug 2025 12:29:35 +0200", "Message-ID": "<20250815102945.1602071-16-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250815102945.1602071-1-stefan.klug@ideasonboard.com>", "References": "<20250815102945.1602071-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The upcoming WDR algorithm needs to know the effective y target (Which\nincludes the current ExposureValue). Add a accessor for that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Added this patch\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 16 ++++++++++++++--\n src/ipa/libipa/agc_mean_luminance.h | 2 ++\n 2 files changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex 6c7cf0038b16..2bfafe9b2d02 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -458,8 +458,7 @@ void AgcMeanLuminance::setLimits(utils::Duration minExposureTime,\n */\n double AgcMeanLuminance::estimateInitialGain() const\n {\n-\tdouble yTarget = std::min(relativeLuminanceTarget_ * exposureCompensation_,\n-\t\t\t\t kMaxRelativeLuminanceTarget);\n+\tdouble yTarget = effectiveYTarget();\n \tdouble yGain = 1.0;\n \n \t/*\n@@ -521,6 +520,19 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \treturn gain;\n }\n \n+/**\n+ * \\brief Get the currently effective y target\n+ *\n+ * This function return the current y target including exposure compensation.\n+ *\n+ * \\return The y target value\n+ */\n+double AgcMeanLuminance::effectiveYTarget() const\n+{\n+\treturn std::min(relativeLuminanceTarget_ * exposureCompensation_,\n+\t\t\tkMaxRelativeLuminanceTarget);\n+}\n+\n /**\n * \\brief Apply a filter on the exposure value to limit the speed of changes\n * \\param[in] exposureValue The target exposure from the AGC algorithm\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex fbb526f6ae8e..950b7b893754 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -72,6 +72,8 @@ public:\n \tcalculateNewEv(uint32_t constraintModeIndex, uint32_t exposureModeIndex,\n \t\t const Histogram &yHist, utils::Duration effectiveExposureValue);\n \n+\tdouble effectiveYTarget() const;\n+\n \tvoid resetFrameCount()\n \t{\n \t\tframeCount_ = 0;\n", "prefixes": [ "v3", "15/19" ] }