Patch Detail
Show a patch.
GET /api/1.1/patches/24117/?format=api
{ "id": 24117, "url": "https://patchwork.libcamera.org/api/1.1/patches/24117/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24117/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250815102945.1602071-8-stefan.klug@ideasonboard.com>", "date": "2025-08-15T10:29:27", "name": "[v3,07/19] libipa: agc_mean_luminance: Fix constraint logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7f700187c4a28fe4afa47a0e42b1f70dbadf9d7a", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24117/mbox/", "series": [ { "id": 5382, "url": "https://patchwork.libcamera.org/api/1.1/series/5382/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5382", "date": "2025-08-15T10:29:20", "name": "Implement WDR algorithm", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5382/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24117/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24117/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90C0CBDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Aug 2025 10:30:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A42569267;\n\tFri, 15 Aug 2025 12:30:14 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FFD06925A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Aug 2025 12:30:13 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:83d1:ae5d:93a6:6837])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7CBE156D;\n\tFri, 15 Aug 2025 12:29:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ekhfKApd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755253758;\n\tbh=Ko31T+X17SoBcAz6+/B5dhBV8juu/jmvyP0sWpDiBBM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ekhfKApdZoF1Oqd0ZkqBO0u4En4aFgrQr6sodPl+4notkasQAzdY+tqqcDkJm3bzj\n\tsjRCB88fyLrWbTgWAaOijvZGXl+bWMvTxYZhHl6Wh5eoEFU8XjEcb9ptKA0PaBHyo0\n\tXdrxLP9IeaxkZ2Poox4G89xbFHwZStyxRidGP8dA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v3 07/19] libipa: agc_mean_luminance: Fix constraint logging", "Date": "Fri, 15 Aug 2025 12:29:27 +0200", "Message-ID": "<20250815102945.1602071-8-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250815102945.1602071-1-stefan.klug@ideasonboard.com>", "References": "<20250815102945.1602071-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The debug log statements in constraintClampGain() are after the\nassignment of gain. So they correctly log when the constraint applies,\nbut the gain values logged are the same. Fix that.\n\nFixes: 42e18c96bcb7 (\"libipa: agc_mean_luminance: Add debug logging\")\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Added this patch\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex ff96a381ffce..fce1a5064870 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -488,18 +488,18 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Lower &&\n \t\t newGain > gain) {\n-\t\t\tgain = newGain;\n \t\t\tLOG(AgcMeanLuminance, Debug)\n \t\t\t\t<< \"Apply lower bound: \" << gain << \" to \"\n \t\t\t\t<< newGain;\n+\t\t\tgain = newGain;\n \t\t}\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Upper &&\n \t\t newGain < gain) {\n-\t\t\tgain = newGain;\n \t\t\tLOG(AgcMeanLuminance, Debug)\n \t\t\t\t<< \"Apply upper bound: \" << gain << \" to \"\n \t\t\t\t<< newGain;\n+\t\t\tgain = newGain;\n \t\t}\n \t}\n \n", "prefixes": [ "v3", "07/19" ] }