Patch Detail
Show a patch.
GET /api/1.1/patches/24076/?format=api
{ "id": 24076, "url": "https://patchwork.libcamera.org/api/1.1/patches/24076/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24076/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250808141315.413839-6-stefan.klug@ideasonboard.com>", "date": "2025-08-08T14:12:43", "name": "[v2,05/16] libipa: exposure_mode_helper: Remove double calculation of lastStageGain", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "eac1537c25257d3e61b6c45e4e3853e2e356bad4", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24076/mbox/", "series": [ { "id": 5364, "url": "https://patchwork.libcamera.org/api/1.1/series/5364/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5364", "date": "2025-08-08T14:12:38", "name": "Implement WDR algorithm", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5364/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24076/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24076/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2D91BDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 Aug 2025 14:13:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C67A6922A;\n\tFri, 8 Aug 2025 16:13:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAEBC6921C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 Aug 2025 16:13:57 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3ea1:35ac:90da:a221])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CCC7342D0; \n\tFri, 8 Aug 2025 16:13:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g2aKZd+0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754662387;\n\tbh=jaSaTylteAf9BebnDZq8p7FGkbu3Unqpfr99GXpMpc8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g2aKZd+0oqrqcPH1Mwum3Z3uIZIi1neI2/zw28mRxe9WVXAbbvsXc2bdoF48CZ7nn\n\tTklueD9Qxt8oGK3080WtwbIpsVE25GoBeohs9Nayq7yw87wf0mmnsLzjpTyzjlK0zy\n\tZtfBUIlaUenY72NMDjgENQYC4/b5xX9E8GRXhFK4=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 05/16] libipa: exposure_mode_helper: Remove double\n\tcalculation of lastStageGain", "Date": "Fri, 8 Aug 2025 16:12:43 +0200", "Message-ID": "<20250808141315.413839-6-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250808141315.413839-1-stefan.klug@ideasonboard.com>", "References": "<20250808141315.413839-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "lastStageGain gets recalculated unconditionally even though it is the\nstageGain of the last stage. Refactor for increased simplicity and\nefficiency.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/libipa/exposure_mode_helper.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\nindex d0a61908c966..3c758851679f 100644\n--- a/src/ipa/libipa/exposure_mode_helper.cpp\n+++ b/src/ipa/libipa/exposure_mode_helper.cpp\n@@ -198,10 +198,10 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \n \tutils::Duration exposureTime;\n \tdouble stageGain = 1.0;\n+\tdouble lastStageGain = 1.0;\n \tdouble gain;\n \n \tfor (unsigned int stage = 0; stage < gains_.size(); stage++) {\n-\t\tdouble lastStageGain = stage == 0 ? 1.0 : clampGain(gains_[stage - 1]);\n \t\tutils::Duration stageExposureTime = clampExposureTime(exposureTimes_[stage]);\n \t\tstageGain = clampGain(gains_[stage]);\n \n@@ -228,6 +228,8 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \n \t\t\treturn { exposureTime, gain, exposure / (exposureTime * gain) };\n \t\t}\n+\n+\t\tlastStageGain = stageGain;\n \t}\n \n \t/*\n", "prefixes": [ "v2", "05/16" ] }