Patch Detail
Show a patch.
GET /api/1.1/patches/24068/?format=api
{ "id": 24068, "url": "https://patchwork.libcamera.org/api/1.1/patches/24068/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24068/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250807132052.84591-1-uajain@igalia.com>", "date": "2025-08-07T13:20:52", "name": "test: camera: Use Request::ReuseBuffers flag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a175496360be95fe1da1bc8b26192f743179837", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/1.1/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24068/mbox/", "series": [ { "id": 5361, "url": "https://patchwork.libcamera.org/api/1.1/series/5361/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5361", "date": "2025-08-07T13:20:52", "name": "test: camera: Use Request::ReuseBuffers flag", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5361/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24068/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24068/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7899BBDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Aug 2025 13:20:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E7E26921A;\n\tThu, 7 Aug 2025 15:20:45 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9437569052\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Aug 2025 15:20:43 +0200 (CEST)", "from [49.36.71.143] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uk0Xy-00B0xz-JN; Thu, 07 Aug 2025 15:20:42 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"ZYjEyEZO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=mf58jB+Q+A0jok2fTL7mZFHrkjnTIPjCacoC4Ykh2XU=;\n\tb=ZYjEyEZOb8fUC3wx/mBEqRm58/\n\t7DB4iETvjr1LfIzwGBggjTfnNOR0gw2On50edKBIJ7XNjngHSTAsiUukbTuK125uIfDzcQoYOJDtz\n\trQW366akqVL/wByO1zpUZOsFnktmvWW1lwZgeBkJ3hzoQdJtTwOD0VmlcMc2q8eDcsfFzSkhEj/rp\n\tWkf00H06Nzm/UiRsPfZB0mxNigMNzbAoBid+EjZ9/h5Iv3VnDVXgfZVdagZS2Xfgdk6WhlNnIMJFp\n\tBZown1xnQ96qF04glr2kLSlQJuhwY9S5Xcthuk8mLoe3pJTMmFXhOmdQi+MlpikOSkEOy7csl20aL\n\tH5xteO5A==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <uajain@igalia.com>", "Subject": "[PATCH] test: camera: Use Request::ReuseBuffers flag", "Date": "Thu, 7 Aug 2025 18:50:52 +0530", "Message-ID": "<20250807132052.84591-1-uajain@igalia.com>", "X-Mailer": "git-send-email 2.50.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Pass Request::ReuseBuffers flag to request->reuse()\nwhere the same buffers are added to the request, as the flag\nexists precisely for such use cases.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n test/camera/buffer_import.cpp | 8 +-------\n test/camera/camera_reconfigure.cpp | 8 +-------\n test/camera/capture.cpp | 8 +-------\n 3 files changed, 3 insertions(+), 21 deletions(-)", "diff": "diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\nindex 815d1cae..d6feee79 100644\n--- a/test/camera/buffer_import.cpp\n+++ b/test/camera/buffer_import.cpp\n@@ -52,16 +52,10 @@ protected:\n \t\tif (request->status() != Request::RequestComplete)\n \t\t\treturn;\n \n-\t\tconst Request::BufferMap &buffers = request->buffers();\n-\n \t\tcompleteRequestsCount_++;\n \n \t\t/* Create a new request. */\n-\t\tconst Stream *stream = buffers.begin()->first;\n-\t\tFrameBuffer *buffer = buffers.begin()->second;\n-\n-\t\trequest->reuse();\n-\t\trequest->addBuffer(stream, buffer);\n+\t\trequest->reuse(Request::ReuseBuffers);\n \t\tcamera_->queueRequest(request);\n \n \t\tdispatcher_->interrupt();\ndiff --git a/test/camera/camera_reconfigure.cpp b/test/camera/camera_reconfigure.cpp\nindex 06c87730..ae9941c1 100644\n--- a/test/camera/camera_reconfigure.cpp\n+++ b/test/camera/camera_reconfigure.cpp\n@@ -46,14 +46,8 @@ private:\n \t\tif (request->status() != Request::RequestComplete)\n \t\t\treturn;\n \n-\t\tconst Request::BufferMap &buffers = request->buffers();\n-\n-\t\tconst Stream *stream = buffers.begin()->first;\n-\t\tFrameBuffer *buffer = buffers.begin()->second;\n-\n \t\t/* Reuse the request and re-queue it with the same buffers. */\n-\t\trequest->reuse();\n-\t\trequest->addBuffer(stream, buffer);\n+\t\trequest->reuse(Request::ReuseBuffers);\n \t\tcamera_->queueRequest(request);\n \t}\n \ndiff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\nindex 8766fb19..a4168661 100644\n--- a/test/camera/capture.cpp\n+++ b/test/camera/capture.cpp\n@@ -48,16 +48,10 @@ protected:\n \t\tif (request->status() != Request::RequestComplete)\n \t\t\treturn;\n \n-\t\tconst Request::BufferMap &buffers = request->buffers();\n-\n \t\tcompleteRequestsCount_++;\n \n \t\t/* Create a new request. */\n-\t\tconst Stream *stream = buffers.begin()->first;\n-\t\tFrameBuffer *buffer = buffers.begin()->second;\n-\n-\t\trequest->reuse();\n-\t\trequest->addBuffer(stream, buffer);\n+\t\trequest->reuse(Request::ReuseBuffers);\n \t\tcamera_->queueRequest(request);\n \n \t\tdispatcher_->interrupt();\n", "prefixes": [] }