Patch Detail
Show a patch.
GET /api/1.1/patches/24017/?format=api
{ "id": 24017, "url": "https://patchwork.libcamera.org/api/1.1/patches/24017/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24017/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250729073201.5369-8-mzamazal@redhat.com>", "date": "2025-07-29T07:31:55", "name": "[v16,07/12] config: Allow enabling software ISP in runtime", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8ef47983591643b0b3ecaa21ed138d46380f12f7", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24017/mbox/", "series": [ { "id": 5345, "url": "https://patchwork.libcamera.org/api/1.1/series/5345/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5345", "date": "2025-07-29T07:31:48", "name": "Add global configuration file", "version": 16, "mbox": "https://patchwork.libcamera.org/series/5345/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24017/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24017/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9E25C32B5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Jul 2025 07:32:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5BE6691D8;\n\tTue, 29 Jul 2025 09:32:43 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88411691C4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Jul 2025 09:32:29 +0200 (CEST)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-659-wg7EiVtTOe2jTYLITh-2HQ-1;\n\tTue, 29 Jul 2025 03:32:26 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 785031800261; Tue, 29 Jul 2025 07:32:24 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.43.17.23])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id E4DC71800B6C; Tue, 29 Jul 2025 07:32:22 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"AATzXgZu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1753774348;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Wlv24hNNHSFMz+Ca9+dxl2NBtE2pvv+Gq7b8gHuo7j4=;\n\tb=AATzXgZudEPAHdqbLKUvFYDOgLo6hx0f2HGRrXZiwJfBcnO9tARTTnkzk6vDcnPLI5Bx+a\n\t2kbu5nUQrViSNYWyEVma81KWcJ3sImLcuGjRXFt8TO6T6RvFFrDoXIrBLd4MCu2oSjN+NH\n\tl+XPxne+OecXRKI1Xu8+FuULbNTZapI=", "X-MC-Unique": "wg7EiVtTOe2jTYLITh-2HQ-1", "X-Mimecast-MFC-AGG-ID": "wg7EiVtTOe2jTYLITh-2HQ_1753774344", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v16 07/12] config: Allow enabling software ISP in runtime", "Date": "Tue, 29 Jul 2025 09:31:55 +0200", "Message-ID": "<20250729073201.5369-8-mzamazal@redhat.com>", "In-Reply-To": "<20250729073201.5369-1-mzamazal@redhat.com>", "References": "<20250729073201.5369-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "Rv8VvxFfQl14R8_446FIIHUHFn96bI-4GJLCb7NNBbk_1753774344", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch allows enabling or disabling software ISP in runtime in\naddition to compile time. This can be useful for software ISP testing\non various platforms as well as for overriding the defaults in case the\ndefaults don't work well (e.g. hardware ISP may or may not work on\ni.MX8MP depending on the kernel and libcamera patches present in the\ngiven system).\n\nThe configuration is specified as follows:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: DRIVER-NAME\n software_isp: BOOLEAN\n - ...\n\nFor example:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: mxc-isi\n software_isp: true\n\nThe overall configuration of enabling or disabling software ISP may get\ndropped in future but this patch is still useful in the meantime.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 4323472e1..70c41aed0 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -30,11 +30,13 @@\n #include <libcamera/stream.h>\n \n #include \"libcamera/internal/camera.h\"\n+#include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/camera_sensor_properties.h\"\n #include \"libcamera/internal/converter.h\"\n #include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/software_isp/software_isp.h\"\n@@ -1679,6 +1681,17 @@ bool SimplePipelineHandler::matchDevice(MediaDevice *media,\n \t}\n \n \tswIspEnabled_ = info.swIspEnabled;\n+\tconst GlobalConfiguration &configuration = cameraManager()->_d()->configuration();\n+\tfor (GlobalConfiguration::Configuration entry :\n+\t configuration.configuration()[\"pipelines\"][\"simple\"][\"supported_devices\"]\n+\t\t .asList()) {\n+\t\tauto name = entry[\"driver\"].get<std::string>();\n+\t\tif (name == info.driver) {\n+\t\t\tswIspEnabled_ = entry[\"software_isp\"].get<bool>().value_or(swIspEnabled_);\n+\t\t\tLOG(SimplePipeline, Debug) << \"Overriding software ISP to \" << swIspEnabled_;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n \n \t/* Locate the sensors. */\n \tstd::vector<MediaEntity *> sensors = locateSensors(media);\n", "prefixes": [ "v16", "07/12" ] }