Patch Detail
Show a patch.
GET /api/1.1/patches/23970/?format=api
{ "id": 23970, "url": "https://patchwork.libcamera.org/api/1.1/patches/23970/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23970/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250725172130.2218836-2-kieran.bingham@ideasonboard.com>", "date": "2025-07-25T17:21:29", "name": "[1/2] Documentation: pipeline-handler: Fix broken links", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "cfef514317895d82175f3de085b209e72c17003e", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23970/mbox/", "series": [ { "id": 5334, "url": "https://patchwork.libcamera.org/api/1.1/series/5334/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5334", "date": "2025-07-25T17:21:28", "name": "Documentation/linkcheck fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5334/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23970/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23970/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B13FC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Jul 2025 17:21:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBB5B69110;\n\tFri, 25 Jul 2025 19:21:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECC59690F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jul 2025 19:21:34 +0200 (CEST)", "from Monstersaurus.lan\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0D5CC73;\n\tFri, 25 Jul 2025 19:20:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T+jT7322\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753464055;\n\tbh=MTpWTjDjfgBZ1WwHEy+wX5aqv7DiaydgG8H8XBAoK6E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=T+jT7322Llq3UdVcuLuAqe51jURya3Am/rr+zZYP6AjOEpGqk3437IL5zTBFE+u7G\n\tLMABStbaBxJTHE0GAdBb4mMlJC1uUkC2rAWkSB8zVHI/aDsQF84Vkqj+9OJ3gGMsuF\n\tjoffO1YpP2iJ+d5WdpusWPObyWWAgwVe3iBFUKXs=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 1/2] Documentation: pipeline-handler: Fix broken links", "Date": "Fri, 25 Jul 2025 18:21:29 +0100", "Message-ID": "<20250725172130.2218836-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250725172130.2218836-1-kieran.bingham@ideasonboard.com>", "References": "<20250725172130.2218836-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Documentation/linkcheck target reports failing links in the pipeline\nhandler writers guide. Update the links accordingly to the current\npublic versions.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n Documentation/guides/pipeline-handler.rst | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\nindex 0d5df7269e40..c09690fe7c15 100644\n--- a/Documentation/guides/pipeline-handler.rst\n+++ b/Documentation/guides/pipeline-handler.rst\n@@ -522,7 +522,7 @@ Finally with a successful construction, we return 'true' indicating that the\n PipelineHandler successfully matched and constructed a device.\n \n .. _Camera::create: https://libcamera.org/internal-api-html/classlibcamera_1_1Camera.html#adf5e6c22411f953bfaa1ae21155d6c31\n-.. _registerCamera: https://libcamera.org/api-html/classlibcamera_1_1PipelineHandler.html#adf02a7f1bbd87aca73c0e8d8e0e6c98b\n+.. _registerCamera: https://libcamera.org/api-html/classlibcamera_1_1PipelineHandler.html#a97bc7a1ac8e7128d4b3dff91eb03f2a4\n \n .. code-block:: cpp\n \n@@ -782,8 +782,8 @@ Applications generate a ``CameraConfiguration`` instance by calling the\n implementation of the overridden `PipelineHandler::generateConfiguration()`_\n function.\n \n-.. _Camera::generateConfiguration(): https://libcamera.org/api-html/classlibcamera_1_1Camera.html#a25c80eb7fc9b1cf32692ce0c7f09991d\n-.. _PipelineHandler::generateConfiguration(): https://libcamera.org/api-html/classlibcamera_1_1PipelineHandler.html#a7932e87735695500ce1f8c7ae449b65b\n+.. _Camera::generateConfiguration(): https://libcamera.org/api-html/classlibcamera_1_1Camera.html#a3059dba6e3facae4f58212d3d76b5cac\n+.. _PipelineHandler::generateConfiguration(): https://libcamera.org/api-html/classlibcamera_1_1PipelineHandler.html#a83bbbe0826fb159253535ef077cb4343\n \n Configurations are generated by receiving a list of ``StreamRole`` instances,\n which libcamera uses as predefined ways an application intends to use a camera\n@@ -791,7 +791,7 @@ which libcamera uses as predefined ways an application intends to use a camera\n optional hints on how an application intends to use a stream, and a pipeline\n handler should return an ideal configuration for each role that is requested.\n \n-.. _StreamRole API: https://libcamera.org/api-html/stream_8h.html#file_a295d1f5e7828d95c0b0aabc0a8baac03\n+.. _StreamRole API: https://libcamera.org/api-html/namespacelibcamera.html#a295d1f5e7828d95c0b0aabc0a8baac03\n \n In the pipeline handler ``generateConfiguration`` implementation, remove the\n ``return nullptr;``, create a new instance of the ``CameraConfiguration``\n@@ -1110,7 +1110,7 @@ We can now use the V4L2 control IDs to prepare a list of controls with the\n `ControlList`_ class, and set them using the `ControlList::set()`_ function.\n \n .. _ControlList: https://libcamera.org/api-html/classlibcamera_1_1ControlList.html\n-.. _ControlList::set(): https://libcamera.org/api-html/classlibcamera_1_1ControlList.html#a74a1a29abff5243e6e37ace8e24eb4ba\n+.. _ControlList::set(): https://libcamera.org/api-html/classlibcamera_1_1ControlList.html#aa41c425f3075349747fdbfc1e3a6fc46\n \n In our pipeline ``configure`` function, add the following code after the format\n has been set and checked to initialise the ControlList and apply it to the\n@@ -1281,7 +1281,7 @@ This example pipeline handler identifies the buffer using the `findBuffer`_\n helper from the only supported stream and queues it to the capture device\n directly with the `queueBuffer`_ function provided by the V4L2VideoDevice.\n \n-.. _findBuffer: https://libcamera.org/api-html/classlibcamera_1_1Request.html#ac66050aeb9b92c64218945158559c4d4\n+.. _findBuffer: https://libcamera.org/api-html/classlibcamera_1_1Request.html#abaed06e43f6a92590075962f825767f7\n .. _queueBuffer: https://libcamera.org/api-html/classlibcamera_1_1V4L2VideoDevice.html#a594cd594686a8c1cf9ae8dba0b2a8a75\n \n Replace the stubbed contents of ``queueRequestDevice`` with the following:\n", "prefixes": [ "1/2" ] }