Patch Detail
Show a patch.
GET /api/1.1/patches/239/?format=api
{ "id": 239, "url": "https://patchwork.libcamera.org/api/1.1/patches/239/?format=api", "web_url": "https://patchwork.libcamera.org/patch/239/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190115151849.1547-8-laurent.pinchart@ideasonboard.com>", "date": "2019-01-15T15:18:48", "name": "[libcamera-devel,v2,7/8] libcamera: utils: Implement C++14 make_unique<>()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2af5e4fccaaaea1fc68b2dca864507cd90c4348c", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/239/mbox/", "series": [ { "id": 81, "url": "https://patchwork.libcamera.org/api/1.1/series/81/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=81", "date": "2019-01-15T15:18:41", "name": "Pipeline handler refactoring and assorted improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/81/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/239/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/239/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F51F60C8A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Jan 2019 16:18:55 +0100 (CET)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29DA59DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Jan 2019 16:18:55 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547565535;\n\tbh=EeHx7F4G3g+r7yLlZuozFoIBtaBP7srRW00d+LqYPTs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=evye7kJuD2rThzwK6qlpYRxI63CoO+bEGaYgbOw8sMgPMBx7oDdk5JMLAPNUdmAte\n\tql1y5NSR8NgQeZ3sdmfCFoBE8Mmh8WMjNg0/mbEfcgWXxL1zjsgOFm9IDvzWk8djMr\n\t/rXIVWytlIxWIuD6qhmbKkp3w6IuOAKEE8cf6FqY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 15 Jan 2019 17:18:48 +0200", "Message-Id": "<20190115151849.1547-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190115151849.1547-1-laurent.pinchart@ideasonboard.com>", "References": "<20190115151849.1547-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 7/8] libcamera: utils: Implement C++14\n\tmake_unique<>()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 15 Jan 2019 15:18:55 -0000" }, "content": "C++14 introduces std::make_unique<>() that makes it easier to initialize\nunique_ptr<> instances. As libcamera is limited to C++11, implement our\nown version of the function in the libcamera::utils namespace.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/include/utils.h | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\nindex 3ffa6f4ea591..a2e450b35372 100644\n--- a/src/libcamera/include/utils.h\n+++ b/src/libcamera/include/utils.h\n@@ -7,6 +7,19 @@\n #ifndef __LIBCAMERA_UTILS_H__\n #define __LIBCAMERA_UTILS_H__\n \n+#include <memory>\n+\n #define ARRAY_SIZE(a)\t(sizeof(a) / sizeof(a[0]))\n \n+namespace libcamera::utils {\n+\n+/* C++11 doesn't provide std::make_unique */\n+template<typename T, typename... Args>\n+std::unique_ptr<T> make_unique(Args&&... args)\n+{\n+\treturn std::unique_ptr<T>(new T(std::forward<Args>(args)...));\n+}\n+\n+} /* namespace libcamera::utils */\n+\n #endif /* __LIBCAMERA_UTILS_H__ */\n", "prefixes": [ "libcamera-devel", "v2", "7/8" ] }