Patch Detail
Show a patch.
GET /api/1.1/patches/23891/?format=api
{ "id": 23891, "url": "https://patchwork.libcamera.org/api/1.1/patches/23891/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23891/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250721115029.1561179-1-barnabas.pocze@ideasonboard.com>", "date": "2025-07-21T11:50:29", "name": "[v1] libcamera: control_serializer: Accept empty `ControlList`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0badc48e4ad2a160574b2b90dd12f1211a5bd94c", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23891/mbox/", "series": [ { "id": 5306, "url": "https://patchwork.libcamera.org/api/1.1/series/5306/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5306", "date": "2025-07-21T11:50:29", "name": "[v1] libcamera: control_serializer: Accept empty `ControlList`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5306/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23891/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23891/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22267BDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Jul 2025 11:50:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18D0A68FE1;\n\tMon, 21 Jul 2025 13:50:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E20768FD0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jul 2025 13:50:33 +0200 (CEST)", "from pb-laptop.local (185.221.140.39.nat.pool.zt.hu\n\t[185.221.140.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66B9CEAE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jul 2025 13:49:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K/fhuC2+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753098596;\n\tbh=ovoTjcoqRgCLIo/ilCgyuB3XhhdAIEEC+K08AydkPds=;\n\th=From:To:Subject:Date:From;\n\tb=K/fhuC2+zq6sjDXFFAvUVdUGeuBJUzejowbr2OxmY7U2e6FJ2E6L7aw5bPUdY9mL6\n\t5S4GrJLiKzqSnkOD23FvOCgBpslPLeEqSCdhf3yQiyVkv98qH8q7VbDsXgUsGr5z5u\n\twlVu6E8twfCaSu9JG+ia9mG5cFI2hAZd/hwMi8yU=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] libcamera: control_serializer: Accept empty `ControlList`", "Date": "Mon, 21 Jul 2025 13:50:29 +0200", "Message-ID": "<20250721115029.1561179-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.50.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Accept empty `ControlList`s without an info map. Serialization\nsupports `ControlList`s without an associated `ControlInfoMap`\nobject. However, for deserialization, a \"v4l2\" control list\nwithout an info map resulted in a fatal error.\n\nAfter 30114cadd8cb65 (\"ipa: rpi: Defer initialising AF LensPosition ControlInfo and value\")\nthe `lensControls` member of `ipa::RPi::ConfigResult` is left empty\nand without an info map in every case, not just when a lens is not present.\nThis causes the above assertion to trigger every single time.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/control_serializer.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\nindex 17834648c..1534fc5c8 100644\n--- a/src/libcamera/control_serializer.cpp\n+++ b/src/libcamera/control_serializer.cpp\n@@ -601,8 +601,11 @@ ControlList ControlSerializer::deserialize<ControlList>(ByteStreamBuffer &buffer\n \n \t\tcase IPA_CONTROL_ID_MAP_V4L2:\n \t\tdefault:\n-\t\t\tLOG(Serializer, Fatal)\n-\t\t\t\t<< \"A list of V4L2 controls requires an ControlInfoMap\";\n+\t\t\tif (hdr->entries > 0) {\n+\t\t\t\tLOG(Serializer, Fatal)\n+\t\t\t\t\t<< \"A list of V4L2 controls requires an ControlInfoMap\";\n+\t\t\t}\n+\n \t\t\treturn {};\n \t\t}\n \t}\n", "prefixes": [ "v1" ] }