Patch Detail
Show a patch.
GET /api/1.1/patches/23878/?format=api
{ "id": 23878, "url": "https://patchwork.libcamera.org/api/1.1/patches/23878/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23878/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250721104622.1550908-11-barnabas.pocze@ideasonboard.com>", "date": "2025-07-21T10:46:10", "name": "[RFC,v2,10/22] libcamera: camera: Store `MetadataListPlan` in `Camera::Private`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "db12b1d776e557c7647b72724886111259cdfa4e", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23878/mbox/", "series": [ { "id": 5305, "url": "https://patchwork.libcamera.org/api/1.1/series/5305/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5305", "date": "2025-07-21T10:46:00", "name": "libcamera: Add `MetadataList`", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5305/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23878/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23878/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 727F4C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Jul 2025 10:46:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D495C68FEA;\n\tMon, 21 Jul 2025 12:46:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D456B68FEA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jul 2025 12:46:32 +0200 (CEST)", "from pb-laptop.local (185.221.140.39.nat.pool.zt.hu\n\t[185.221.140.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1CF8795A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jul 2025 12:45:55 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T2ZtaOrK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753094756;\n\tbh=yqcGK1XWN3qV448lFKi1EasGmkmQG6aKN1VQjprmRtw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=T2ZtaOrKcdEbV+0Mlbe7qx0A5xberXWfRfEqrkA3GDj5ehX0U47AJKfzl1K9lYPWY\n\tqSk8mHtpSswMj7JPA9yzAJ2z4JQj8vFFhU21FVofAeFRYlorCPsMyFm1dyNnX8wqgY\n\tG0y1BHZR+G7n/uzUIzn4Z0q9RAzQOluae+//vNds=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v2 10/22] libcamera: camera: Store `MetadataListPlan` in\n\t`Camera::Private`", "Date": "Mon, 21 Jul 2025 12:46:10 +0200", "Message-ID": "<20250721104622.1550908-11-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20250721104622.1550908-1-barnabas.pocze@ideasonboard.com>", "References": "<20250721104622.1550908-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Just like `ControlInfoMap controlInfo_` is a public member of the private\ncamera data for pipeline handlers to populate, add a `MetadataListPlan` as\nwell for the pipeline handlers to fill. This will be used to initialize\nthe `MetadataList` of each request created by the camera.\n\nAlso add `Camera::metadata()`, which makes it accessible for applications.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\nchanges in v2:\n * make it available in `Camera::metadata()`\n---\n include/libcamera/camera.h | 1 +\n include/libcamera/internal/camera.h | 2 ++\n src/libcamera/camera.cpp | 21 +++++++++++++++++++++\n 3 files changed, 24 insertions(+)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 94cee7bd8..e3e40aa89 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -131,6 +131,7 @@ public:\n \n \tconst ControlInfoMap &controls() const;\n \tconst ControlList &properties() const;\n+\tconst MetadataListPlan &metadata() const;\n \n \tconst std::set<Stream *> &streams() const;\n \ndiff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 8a2e9ed58..016c1ae51 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -18,6 +18,7 @@\n #include <libcamera/base/class.h>\n \n #include <libcamera/camera.h>\n+#include <libcamera/metadata_list_plan.h>\n \n namespace libcamera {\n \n@@ -40,6 +41,7 @@ public:\n \tstd::queue<Request *> waitingRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n+\tMetadataListPlan metadataPlan_;\n \n \tuint32_t requestSequence_;\n \ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 5c78f36c1..fa57d46c9 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -669,6 +669,14 @@ Camera::Private::~Private()\n * over a single capture session.\n */\n \n+/**\n+ * \\var Camera::Private::metadataPlan_\n+ * \\brief The set of metadata supported by the camera\n+ *\n+ * The metadata information shall be initialised by the pipeline handler when\n+ * creating the camera.\n+ */\n+\n static const char *const camera_state_names[] = {\n \t\"Available\",\n \t\"Acquired\",\n@@ -1074,6 +1082,19 @@ const ControlInfoMap &Camera::controls() const\n \treturn _d()->controlInfo_;\n }\n \n+/**\n+ * \\brief Retrieve the set of metadata supported by the camera\n+ *\n+ * The list of metadata controls that may be reported by the camera\n+ * for a \\ref Request::metadata() \"request\".\n+ *\n+ * \\return A MetadataListPlan listing the metadata controls supported by the camera\n+ */\n+const MetadataListPlan &Camera::metadata() const\n+{\n+\treturn _d()->metadataPlan_;\n+}\n+\n /**\n * \\brief Retrieve the list of properties of the camera\n *\n", "prefixes": [ "RFC", "v2", "10/22" ] }