Patch Detail
Show a patch.
GET /api/1.1/patches/2386/?format=api
{ "id": 2386, "url": "https://patchwork.libcamera.org/api/1.1/patches/2386/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2386/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191204132106.21582-3-jacopo@jmondi.org>", "date": "2019-12-04T13:20:58", "name": "[libcamera-devel,02/10] libcamera: controls: Parse 'values' in gen-controls.py", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ffa84267150323736faafbe78d965ea384bee5ea", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2386/mbox/", "series": [ { "id": 581, "url": "https://patchwork.libcamera.org/api/1.1/series/581/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=581", "date": "2019-12-04T13:20:56", "name": "Introduce camera properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/581/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2386/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2386/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C743961CC6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Dec 2019 14:21:20 +0100 (CET)", "from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 5A6B524000F;\n\tWed, 4 Dec 2019 13:21:20 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 Dec 2019 14:20:58 +0100", "Message-Id": "<20191204132106.21582-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191204132106.21582-1-jacopo@jmondi.org>", "References": "<20191204132106.21582-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 02/10] libcamera: controls: Parse 'values'\n\tin gen-controls.py", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 04 Dec 2019 13:21:21 -0000" }, "content": "In preparation to add libcamera Camera definition by re-using the\ncontrol generation framework, augment the gen_controls.py script to\nsupport parsing the 'values' yaml tag and generate documentation and\ndefinition of possible values associated with a Control or a Property.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/gen-controls.py | 35 +++++++++++++++++++++++++++++++++++\n 1 file changed, 35 insertions(+)", "diff": "diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\nindex 940386cc68c8..ca843cb9b538 100755\n--- a/src/libcamera/gen-controls.py\n+++ b/src/libcamera/gen-controls.py\n@@ -11,6 +11,24 @@ import string\n import sys\n import yaml\n \n+class ValueGenerator:\n+ doc_template = string.Template('''/**\n+ * \\\\def ${name}\n+ * \\\\brief ${description} */''')\n+ def_template = string.Template('''#define ${name} ${value}''')\n+\n+ def __init__(self, value):\n+ self.info = {\n+ 'name': value['name'],\n+ 'value': value['value'],\n+ 'description': value['description']\n+ }\n+\n+ def generate_doc(self):\n+ return self.doc_template.substitute(self.info)\n+\n+ def generate_def(self):\n+ return self.def_template.substitute(self.info)\n \n def snake_case(s):\n return ''.join([c.isupper() and ('_' + c) or c for c in s]).strip('_')\n@@ -35,14 +53,23 @@ ${description}\n description[0] = '\\\\brief ' + description[0]\n description = '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n \n+ try:\n+ values = ctrl['values']\n+ except KeyError:\n+ values = \"\"\n+\n info = {\n 'name': name,\n 'type': ctrl['type'],\n 'description': description,\n 'id_name': id_name,\n+ 'values' : values,\n }\n \n+ for v in values:\n+ ctrls_doc.append(ValueGenerator(v).generate_doc())\n ctrls_doc.append(doc_template.substitute(info))\n+\n ctrls_def.append(def_template.substitute(info))\n ctrls_map.append('\\t{ ' + id_name + ', &' + name + ' },')\n \n@@ -66,11 +93,19 @@ def generate_h(controls):\n \n ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n \n+ try:\n+ values = ctrl['values']\n+ except KeyError:\n+ values = \"\"\n+\n info = {\n 'name': name,\n 'type': ctrl['type'],\n+ 'values' : values,\n }\n \n+ for v in values:\n+ ctrls.append(ValueGenerator(v).generate_def())\n ctrls.append(template.substitute(info))\n id_value += 1\n \n", "prefixes": [ "libcamera-devel", "02/10" ] }