Patch Detail
Show a patch.
GET /api/1.1/patches/23804/?format=api
{ "id": 23804, "url": "https://patchwork.libcamera.org/api/1.1/patches/23804/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23804/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250713121645.11776-1-laurent.pinchart@ideasonboard.com>", "date": "2025-07-13T12:16:45", "name": "[v3] libcamera: camera_manager: Log info message to report camera creation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d8bd1815e49d932cf2f83ea1eff78f3f2fe792d9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23804/mbox/", "series": [ { "id": 5284, "url": "https://patchwork.libcamera.org/api/1.1/series/5284/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5284", "date": "2025-07-13T12:16:45", "name": "[v3] libcamera: camera_manager: Log info message to report camera creation", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5284/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23804/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23804/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0F70BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 13 Jul 2025 12:17:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EED6468F27;\n\tSun, 13 Jul 2025 14:17:17 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C12F68EA8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 13 Jul 2025 14:17:16 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3092699F;\n\tSun, 13 Jul 2025 14:16:45 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ayDrZKd5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752409005;\n\tbh=muRB9KcPXm6ChyH7FtE1M733NOzKJ4iQ1+9+VMlUnbo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ayDrZKd5NXJH1qix7kfn2BkDLjIWovoqequ8eup/O5RELAEUz/TWqu9IflHzQ6uta\n\tQxWmL2dgkLEcSvaO5bVs4hH/mKFc/gTKjEjB+RDu9gYeETo4uTPXp8cwugnEVcRNpb\n\tBjar0eVBk2PAb8RIHMgVxycswarSrjlSrH7qJgvY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v3] libcamera: camera_manager: Log info message to report\n\tcamera creation", "Date": "Sun, 13 Jul 2025 15:16:45 +0300", "Message-ID": "<20250713121645.11776-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Camera creation is one of the most important events generated by\nlibcamera, but we are completely silent about it. The lack of a log\nmessage makes it more difficult to identify problems and provide\nsupport. Fix it by adding an Info message that reports the camera id and\nits pipeline handler when the camera is added.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nChanges since v2:\n\n- Rebase on latest master branch\n---\n src/libcamera/camera_manager.cpp | 4 ++++\n 1 file changed, 4 insertions(+)\n\n\nbase-commit: afd9890b7b9a65d95ef3295f52e01e0ec9ce7b3f\n--\nRegards,\n\nLaurent Pinchart", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex e62e7193cfdc..f81794bfd6fe 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -217,6 +217,10 @@ void CameraManager::Private::addCamera(std::shared_ptr<Camera> camera)\n \t\tcameras_.push_back(camera);\n \t}\n\n+\tLOG(Camera, Info)\n+\t\t<< \"Adding camera '\" << camera->id() << \"' for pipeline handler \"\n+\t\t<< camera->_d()->pipe()->name();\n+\n \t/* Report the addition to the public signal */\n \tCameraManager *const o = LIBCAMERA_O_PTR();\n \to->cameraAdded.emit(camera);\n", "prefixes": [ "v3" ] }