Patch Detail
Show a patch.
GET /api/1.1/patches/238/?format=api
{ "id": 238, "url": "https://patchwork.libcamera.org/api/1.1/patches/238/?format=api", "web_url": "https://patchwork.libcamera.org/patch/238/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190115151849.1547-7-laurent.pinchart@ideasonboard.com>", "date": "2019-01-15T15:18:47", "name": "[libcamera-devel,v2,6/8] libcamera: device_enumerator: Don't mark the search() function as const", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "941c18763c33004655b78e47631641c94801c58c", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/238/mbox/", "series": [ { "id": 81, "url": "https://patchwork.libcamera.org/api/1.1/series/81/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=81", "date": "2019-01-15T15:18:41", "name": "Pipeline handler refactoring and assorted improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/81/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/238/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/238/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CFDC60C8A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Jan 2019 16:18:55 +0100 (CET)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDC7B59B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Jan 2019 16:18:54 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547565534;\n\tbh=Cz7Czp6CfYmmIFFQEF9MrZkpYtp+3MczlcvN8f3bK2M=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=meaDl+JGkcAZcGOgsprs4u3aF3rVvGgyTuE+A7JFm/Bs3yQozi19h+DAFztQAnog0\n\tA9U1x+5BogyDeLBg22k4cheVeIfT8dfMb8BD0GC52nO9gXdTGMLDqugGRwykZr8qqP\n\tvZQ9KbRh7di8F7A24msRTTIHbdp9Tp+/az0Hp97Q=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 15 Jan 2019 17:18:47 +0200", "Message-Id": "<20190115151849.1547-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190115151849.1547-1-laurent.pinchart@ideasonboard.com>", "References": "<20190115151849.1547-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 6/8] libcamera: device_enumerator:\n\tDon't mark the search() function as const", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 15 Jan 2019 15:18:55 -0000" }, "content": "While the DeviceEnumerator::search() function doesn't modify the\ninstance directly, it returns a non-const pointer to a MediaEntity that\nis owned by the DeviceEnumerator instance. This breaks the const\nsemantics. Don't mark the function as const.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/device_enumerator.cpp | 2 +-\n src/libcamera/include/device_enumerator.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 1653e4f4651a..18d7e86843e8 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -245,7 +245,7 @@ int DeviceEnumerator::addDevice(const std::string &devnode)\n *\n * \\return pointer to the matching MediaDevice, or nullptr if no match is found\n */\n-MediaDevice *DeviceEnumerator::search(const DeviceMatch &dm) const\n+MediaDevice *DeviceEnumerator::search(const DeviceMatch &dm)\n {\n \tfor (MediaDevice *dev : devices_) {\n \t\tif (dev->busy())\ndiff --git a/src/libcamera/include/device_enumerator.h b/src/libcamera/include/device_enumerator.h\nindex 29737da7a225..b68c815827dd 100644\n--- a/src/libcamera/include/device_enumerator.h\n+++ b/src/libcamera/include/device_enumerator.h\n@@ -41,7 +41,7 @@ public:\n \tvirtual int init() = 0;\n \tvirtual int enumerate() = 0;\n \n-\tMediaDevice *search(const DeviceMatch &dm) const;\n+\tMediaDevice *search(const DeviceMatch &dm);\n \n protected:\n \tint addDevice(const std::string &devnode);\n", "prefixes": [ "libcamera-devel", "v2", "6/8" ] }