Patch Detail
Show a patch.
GET /api/1.1/patches/23677/?format=api
{ "id": 23677, "url": "https://patchwork.libcamera.org/api/1.1/patches/23677/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23677/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250627113449.23106-6-mzamazal@redhat.com>", "date": "2025-06-27T11:34:40", "name": "[v7,05/12] libcamera: simple: Don't use raw output formats with conversions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "783df6908290034ab573a8177980ff7a0b99c4ed", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23677/mbox/", "series": [ { "id": 5255, "url": "https://patchwork.libcamera.org/api/1.1/series/5255/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5255", "date": "2025-06-27T11:34:36", "name": "Enable raw streams with software ISP", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5255/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23677/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23677/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C583BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Jun 2025 11:35:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B31E668E11;\n\tFri, 27 Jun 2025 13:35:17 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CD7B68DFC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Jun 2025 13:35:16 +0200 (CEST)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-154-p9HqDZy2PwKNEQBGnZBbrg-1;\n\tFri, 27 Jun 2025 07:35:10 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 5EA35180029F; Fri, 27 Jun 2025 11:35:09 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.226.86])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id CE09730001BC; Fri, 27 Jun 2025 11:35:06 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"hEl8aKZs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1751024115;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=+OPkc3eTDuz3Q9IitVmLmeHUMc6rADfF6TVg1BXZ03c=;\n\tb=hEl8aKZsfi+HM8K12Z1VK0zjKLLktWZRzt8/FFxVaJLs0sxv1hh9uEGf2DqOh5ZFhKjnv7\n\tevy7taUyLtHhR2Fs//vbeOoTHPsdZLBe/Pj/N2G6JGHeULoyWx/Az8mpu1BnefreQk+VJm\n\tXawls8Ig6e/15/yYzA7PZmcWRFAUjHY=", "X-MC-Unique": "p9HqDZy2PwKNEQBGnZBbrg-1", "X-Mimecast-MFC-AGG-ID": "p9HqDZy2PwKNEQBGnZBbrg_1751024109", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>", "Subject": "[PATCH v7 05/12] libcamera: simple: Don't use raw output formats\n\twith conversions", "Date": "Fri, 27 Jun 2025 13:34:40 +0200", "Message-ID": "<20250627113449.23106-6-mzamazal@redhat.com>", "In-Reply-To": "<20250627113449.23106-1-mzamazal@redhat.com>", "References": "<20250627113449.23106-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "lbzQYiTWEhAYbSKDxCmuLmtueZ6nSpuIyp2HZ5d4vIU_1751024109", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to support raw streams, we need to add raw formats to software\nISP configurations. In this preparatory patch, the raw formats are\nexcluded from output configurations for conversions.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex ab19149e4..60b7e1b15 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -27,6 +27,7 @@\n #include <libcamera/camera.h>\n #include <libcamera/color_space.h>\n #include <libcamera/control_ids.h>\n+#include <libcamera/pixel_format.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n@@ -1411,7 +1412,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \n \t\tcfg.setStream(&data->streams_[i]);\n \n-\t\tif (data->useConversion_)\n+\t\tif (data->useConversion_ && !isFormatRaw(cfg.pixelFormat))\n \t\t\toutputCfgs.push_back(cfg);\n \t}\n \n", "prefixes": [ "v7", "05/12" ] }