Patch Detail
Show a patch.
GET /api/1.1/patches/23657/?format=api
{ "id": 23657, "url": "https://patchwork.libcamera.org/api/1.1/patches/23657/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23657/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250626082235.1845316-1-barnabas.pocze@ideasonboard.com>", "date": "2025-06-26T08:22:35", "name": "[RFC,v1] libcamera: pipeline: rpi: Do not clear request metadata anymore", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8339a56448fdc34cd2a30bd187328e90fdf9cb10", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23657/mbox/", "series": [ { "id": 5250, "url": "https://patchwork.libcamera.org/api/1.1/series/5250/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5250", "date": "2025-06-26T08:22:35", "name": "[RFC,v1] libcamera: pipeline: rpi: Do not clear request metadata anymore", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5250/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23657/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23657/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 607D7C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Jun 2025 08:22:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A5E968DED;\n\tThu, 26 Jun 2025 10:22:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13A5F62C44\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Jun 2025 10:22:39 +0200 (CEST)", "from pb-laptop.local (185.221.143.107.nat.pool.zt.hu\n\t[185.221.143.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D761F6BE;\n\tThu, 26 Jun 2025 10:22:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L1oi+Y/f\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750926140;\n\tbh=gYpL2eEnT+UvRkqBhg8RvjMbuG7iQbwMsCABVydV2Zg=;\n\th=From:To:Subject:Date:From;\n\tb=L1oi+Y/fO1poukCeCvX2Vl6Pl1jVp1foNdNylCsT8/jMY14dX+7B0zFfVX0vgH+uw\n\tHXwIBiaUdVpMeDWl/1So2J+yXgGr99UP8I5ZGnoJSh2wemIM+/3iezKTpHGELjGS6C\n\tsEBRqyclP/SbPiDC2Vc9ZJ5Wa/w5vDwAk7sPqEY0=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[RFC PATCH v1] libcamera: pipeline: rpi: Do not clear request\n\tmetadata anymore", "Date": "Thu, 26 Jun 2025 10:22:35 +0200", "Message-ID": "<20250626082235.1845316-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.50.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since 6cf9c4d34fbda5 (\"pipeline: ipa: rpi: Split RPiCameraData::dropFrameCount_\")\nthe initial n frames are not dropped anymore. So clearing the request metadata\nshould not be necessary anymore, remove it.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/pisp/pisp.cpp | 7 +------\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 7 +------\n 2 files changed, 2 insertions(+), 12 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/pisp/pisp.cpp b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\nindex 2df91bacf..834b0e3f9 100644\n--- a/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n+++ b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n@@ -2313,16 +2313,11 @@ void PiSPCameraData::tryRunPipeline()\n \n \t/* Take the first request from the queue and action the IPA. */\n \tRequest *request = requestQueue_.front();\n+\tASSERT(request->metadata().empty());\n \n \t/* See if a new ScalerCrop value needs to be applied. */\n \tapplyScalerCrop(request->controls());\n \n-\t/*\n-\t * Clear the request metadata and fill it with some initial non-IPA\n-\t * related controls. We clear it first because the request metadata\n-\t * may have been populated if we have dropped the previous frame.\n-\t */\n-\trequest->metadata().clear();\n \tfillRequestMetadata(job.sensorControls, request);\n \n \t/* Set our state to say the pipeline is active. */\ndiff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\nindex e99a7edf8..02e835b00 100644\n--- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n+++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n@@ -927,16 +927,11 @@ void Vc4CameraData::tryRunPipeline()\n \n \t/* Take the first request from the queue and action the IPA. */\n \tRequest *request = requestQueue_.front();\n+\tASSERT(request->metadata().empty());\n \n \t/* See if a new ScalerCrop value needs to be applied. */\n \tapplyScalerCrop(request->controls());\n \n-\t/*\n-\t * Clear the request metadata and fill it with some initial non-IPA\n-\t * related controls. We clear it first because the request metadata\n-\t * may have been populated if we have dropped the previous frame.\n-\t */\n-\trequest->metadata().clear();\n \tfillRequestMetadata(bayerFrame.controls, request);\n \n \t/* Set our state to say the pipeline is active. */\n", "prefixes": [ "RFC", "v1" ] }