Patch Detail
Show a patch.
GET /api/1.1/patches/23592/?format=api
{ "id": 23592, "url": "https://patchwork.libcamera.org/api/1.1/patches/23592/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23592/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250617104642.1607118-2-niklas.soderlund+renesas@ragnatech.se>", "date": "2025-06-17T10:46:41", "name": "[1/2] ipa: rkisp1: Add settings for DreamChip RPPX1 ISP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e598588c0282b367ddffd9605f9cf2fa3a1faca8", "submitter": { "id": 230, "url": "https://patchwork.libcamera.org/api/1.1/people/230/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund+renesas@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23592/mbox/", "series": [ { "id": 5226, "url": "https://patchwork.libcamera.org/api/1.1/series/5226/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5226", "date": "2025-06-17T10:46:40", "name": "Add Renesas R-Car Gen4 pipeline with IPA support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5226/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23592/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23592/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8137CBDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 Jun 2025 10:47:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DB6568DCC;\n\tTue, 17 Jun 2025 12:46:59 +0200 (CEST)", "from fhigh-b4-smtp.messagingengine.com\n\t(fhigh-b4-smtp.messagingengine.com [202.12.124.155])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE5A468DC3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Jun 2025 12:46:56 +0200 (CEST)", "from phl-compute-09.internal (phl-compute-09.phl.internal\n\t[10.202.2.49])\n\tby mailfhigh.stl.internal (Postfix) with ESMTP id C14212540183;\n\tTue, 17 Jun 2025 06:46:55 -0400 (EDT)", "from phl-mailfrontend-01 ([10.202.2.162])\n\tby phl-compute-09.internal (MEProxy); Tue, 17 Jun 2025 06:46:55 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Tue,\n\t17 Jun 2025 06:46:54 -0400 (EDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech.se header.i=@ragnatech.se\n\theader.b=\"IR9xG8MR\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"nKyTts63\"; \n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h=\n\tcc:cc:content-transfer-encoding:content-type:content-type:date\n\t:date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm3; t=1750157215;\n\tx=1750243615; bh=FieoyiWHCHxAErHZsrXqjLJl0EJf/xOouLXHYuh2NHs=; b=\n\tIR9xG8MR60ux0iSLDkB4GMXWMrX64ZV6sl2c21HnrloPrasosYJmIA4R4wyPMRuF\n\tmhMi+k1MtM8aUWB42dRV6HwwJHXvHG1kf1AnjXyFsGZ26hYf66sWXfMwJFnEgE+1\n\tUVGcj8rjXFoTUhoMXaXY3ARhfM+NfNab6kXUdSx8FMC4ZMHcs+DCnYhge0bhDTEq\n\tEOJjdYLmgWxm5nSbgYegOdgL11mQmtmEa7f1Uv8svWy8GZllwKpyh53nvSrcjWDi\n\tBud0nVMdf6k1hsocAodbYfDeV/6DOATDQf90wPRw/GNHabieX3LoIaCQ5yPGpCi+\n\tvr1uynX16KuvFv4TpB44+w==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1750157215; x=\n\t1750243615; bh=FieoyiWHCHxAErHZsrXqjLJl0EJf/xOouLXHYuh2NHs=; b=n\n\tKyTts630zKN2W1Y2f9zi0vCff41nv1O3183+kmNZ7qlPeFAuomjkhUEqVbVYLoQy\n\twqiOJ36XiwywtSVxrLmreg8fEmwkt6r2PfdR0RPVBMwWpYbYcbrzl89RJYBeTaRB\n\tgtGLMiXjQq8WUu+3BpPkJDxPYHTLThUQ98yvZk3/f8FcZdFZ5sCSEIE1lzG2o+L1\n\tru43EgEaqUiNckNiy+KdauWLoQXlbVywOwX1XmHQAg2YL5CxYCyj7ed4mIsgfs0l\n\tuUnNscaw1ZwA86ZNuN9YTk5RfxQ/eM0I+oq+VA4r/aqldq1tAfXq1SVbHr8b310L\n\tbY3ukZ4NTOV1tkkBUnIpA==" ], "X-ME-Sender": "<xms:n0dRaBB0WV80NN2QD8klQDEFP3U5eUoC8qYV1JNgqodFzz5ZMDSWZg>\n\t<xme:n0dRaPjmEh6QmrHGjtVPY5WY6uzOtvK-MRFqxIzYdrZIMxnejxubNXT9srRiGo7UR\n\thUN8pYzGxcPFagesp0>", "X-ME-Received": "<xmr:n0dRaMl_j71Coh34v3tZ_04W1bXCSjGjKeKl_xypG-pd0UkZFff2jA8BX8fi_DVcu_RK25QXfOLGNUW0DpzXI2JVIg>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeeffedrtddugddvledtfecutefuodetggdotefrod\n\tftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp\n\tuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg\n\thnthhsucdlqddutddtmdenucfjughrpefhvfevufffkffojghfgggtgfesthekredtredt\n\tjeenucfhrhhomheppfhikhhlrghsucfunpguvghrlhhunhguuceonhhikhhlrghsrdhsoh\n\tguvghrlhhunhguodhrvghnvghsrghssehrrghgnhgrthgvtghhrdhsvgeqnecuggftrfgr\n\tthhtvghrnhepheeigfeuveeutdefhfehgeekvedtleeuueekveefudehhffhjeffgfegff\n\telfeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep\n\tnhhikhhlrghsrdhsohguvghrlhhunhgusehrrghgnhgrthgvtghhrdhsvgdpnhgspghrtg\n\thpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjhgrtghophhordhm\n\tohhnughisehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhopehlrghurhgvnh\n\thtrdhpihhntghhrghrthesihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtohep\n\tlhhisggtrghmvghrrgdquggvvhgvlheslhhishhtshdrlhhisggtrghmvghrrgdrohhrgh\n\tdprhgtphhtthhopehnihhklhgrshdrshhouggvrhhluhhnugdorhgvnhgvshgrshesrhgr\n\tghhnrghtvggthhdrshgv", "X-ME-Proxy": "<xmx:n0dRaLxqFwPPvc-sF8CW-00-PdbmujJQmZte9oIBa3HOTTGIkBa9DQ>\n\t<xmx:n0dRaGQecQROG3b2AACV7FP6L5Fmsh6147T3bdNVD-_jH3gO6CAQqg>\n\t<xmx:n0dRaOZkjsL_A9o2Fp5XaZuH1TjNmofUJjzrH5j-9ijc0-LrakgcJg>\n\t<xmx:n0dRaHQr7a-sspWO9oksTwrdnCcbcxcGvn7S8Ghf0SZv0iLt8S5pUw>\n\t<xmx:n0dRaJ9eWY1Bhl4Y2EVVhD1WAvWsrsbcUw8m7vBqDlaLooVCUOZ0KM_S>", "Feedback-ID": "i80c9496c:Fastmail", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?=\n\t<niklas.soderlund+renesas@ragnatech.se>", "To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund+renesas@ragnatech.se>", "Subject": "[PATCH 1/2] ipa: rkisp1: Add settings for DreamChip RPPX1 ISP", "Date": "Tue, 17 Jun 2025 12:46:41 +0200", "Message-ID": "<20250617104642.1607118-2-niklas.soderlund+renesas@ragnatech.se>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250617104642.1607118-1-niklas.soderlund+renesas@ragnatech.se>", "References": "<20250617104642.1607118-1-niklas.soderlund+renesas@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The DreamChip RPPX1 ISP appears to be a superset of the Rockchip RkISP1\nISP V10. The RkISP1 interface and hardware operates at 8-bits color\ndepth, while the RPPX1 operates at 24-bits. For this reason the RkISP1\nparameter and buffer formats are deigned around 8-bits.\n\nThe kernel driver for RPPX1 can however compensate for this and scale\ndown it's internal data structures to 8-bits and produce parameter\nbuffers (RK1E) and output statistics (RK1S) that is compatible with the\nRkISP1 IPA.\n\nThe one difference is that the RPPX1 have 32 histogram buckets compared\nto RkISP1 V10 16. Add a dedicated hardware revisions descriptor for the\nRPPX1 device so it can reuse the existing IPA.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>\n---\n include/libcamera/ipa/rkisp1.mojom | 8 ++++++++\n src/ipa/rkisp1/rkisp1.cpp | 11 +++++++++++\n 2 files changed, 19 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex 043ad27ea199..608ba82a0091 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -8,6 +8,14 @@ module ipa.rkisp1;\n \n import \"include/libcamera/ipa/core.mojom\";\n \n+/*\n+ * Hardware revisions in rkisp1-config.h (enum rkisp1_cif_isp_version) start at\n+ * 10 and increment sequentially. Add a namespace starting at 0x80000000 for\n+ * devices not cover by the kernel rkisp1 implementation but still supported\n+ * by the IPA.\n+ */\n+const uint32 HwRevisionExternalRppX1 = 0x80000001;\n+\n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 1ed7d7d92166..00281404a9a0 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -113,6 +113,14 @@ const IPAHwSettings ipaHwSettingsV12{\n \tfalse,\n };\n \n+const IPAHwSettings ipaHwSettingsRPPX1{\n+\tRKISP1_CIF_ISP_AE_MEAN_MAX_V10,\n+\tRKISP1_CIF_ISP_HIST_BIN_N_MAX_V12,\n+\tRKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10,\n+\tRKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10,\n+\tfalse,\n+};\n+\n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n \t{ &controls::DebugMetadataEnable, ControlInfo(false, true, false) },\n@@ -148,6 +156,9 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \tcase RKISP1_V12:\n \t\tcontext_.hw = &ipaHwSettingsV12;\n \t\tbreak;\n+\tcase HwRevisionExternalRppX1:\n+\t\tcontext_.hw = &ipaHwSettingsRPPX1;\n+\t\tbreak;\n \tdefault:\n \t\tLOG(IPARkISP1, Error)\n \t\t\t<< \"Hardware revision \" << hwRevision\n", "prefixes": [ "1/2" ] }