Patch Detail
Show a patch.
GET /api/1.1/patches/2359/?format=api
{ "id": 2359, "url": "https://patchwork.libcamera.org/api/1.1/patches/2359/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2359/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191126233620.1695316-12-niklas.soderlund@ragnatech.se>", "date": "2019-11-26T23:36:01", "name": "[libcamera-devel,11/30] libcamera: v4l2_videodevice: Align which type variable is used in queueBuffer()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "84e468fc782d740957b029b7e3604c5b4df20edb", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2359/mbox/", "series": [ { "id": 579, "url": "https://patchwork.libcamera.org/api/1.1/series/579/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=579", "date": "2019-11-26T23:35:50", "name": "libcamera: Rework buffer API", "version": 1, "mbox": "https://patchwork.libcamera.org/series/579/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2359/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2359/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03B2C61C6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Nov 2019 00:39:32 +0100 (CET)", "from bismarck.berto.se (p54ac5865.dip0.t-ipconnect.de\n\t[84.172.88.101]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid fe84577b-10a5-11ea-a0b9-005056917f90;\n\tWed, 27 Nov 2019 00:39:31 +0100 (CET)" ], "X-Halon-ID": "fe84577b-10a5-11ea-a0b9-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 27 Nov 2019 00:36:01 +0100", "Message-Id": "<20191126233620.1695316-12-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.24.0", "In-Reply-To": "<20191126233620.1695316-1-niklas.soderlund@ragnatech.se>", "References": "<20191126233620.1695316-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 11/30] libcamera: v4l2_videodevice: Align\n\twhich type variable is used in queueBuffer()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 26 Nov 2019 23:39:33 -0000" }, "content": "Reading V4L2VideoDevice::queueBuffer() is confusing since buf.type is\nfirst set to bufferType_ but then both variables are used in V4L2 macros\nto operate based on which type of buffer is being processed. Aligen on\nonly using buf.type since it have the most existing users.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 166b0abc1b101f88..7b6fa5347ef320f8 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1000,7 +1000,7 @@ int V4L2VideoDevice::queueBuffer(Buffer *buffer)\n \t\tbuf.m.planes = v4l2Planes;\n \t}\n \n-\tif (V4L2_TYPE_IS_OUTPUT(bufferType_)) {\n+\tif (V4L2_TYPE_IS_OUTPUT(buf.type)) {\n \t\tbuf.bytesused = buffer->bytesused_;\n \t\tbuf.sequence = buffer->sequence_;\n \t\tbuf.timestamp.tv_sec = buffer->timestamp_ / 1000000000;\n", "prefixes": [ "libcamera-devel", "11/30" ] }