Patch Detail
Show a patch.
GET /api/1.1/patches/23568/?format=api
{ "id": 23568, "url": "https://patchwork.libcamera.org/api/1.1/patches/23568/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23568/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250616084733.18707-6-mzamazal@redhat.com>", "date": "2025-06-16T08:47:23", "name": "[v10,05/13] config: Look up rpi config path in configuration file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f30e10ab24886c55566dc24c9301c68892aed248", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23568/mbox/", "series": [ { "id": 5220, "url": "https://patchwork.libcamera.org/api/1.1/series/5220/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5220", "date": "2025-06-16T08:47:18", "name": "Add global configuration file", "version": 10, "mbox": "https://patchwork.libcamera.org/series/5220/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23568/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23568/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F9ACC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Jun 2025 08:48:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1069868DD9;\n\tMon, 16 Jun 2025 10:48:10 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74AD668DC0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Jun 2025 10:48:04 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-81-G_KT1XinM5CuEcvTCjcslA-1;\n\tMon, 16 Jun 2025 04:47:59 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id A461C195609F; Mon, 16 Jun 2025 08:47:58 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.226.135])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D79B31956094; Mon, 16 Jun 2025 08:47:55 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"RjJfwbsi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1750063683;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=a1vEno8Te+tpljG/yAhFKI0mbUpdaKxphUuEyfCqPQs=;\n\tb=RjJfwbsigZlUiUu1ivi6M/CQb+t2+axhApcyhsMFyDYTWi1Ks/HtFrlvamDjJsygKZ7RPC\n\tml6mFwUN/AFd/WqK1IloW0TLjcKhy7hkr+rrZ9yx4OAwZ7LlCfSCy+BMZPYBxs/mPvZ1FE\n\tIiUHLFCZPLwjK8nH/YQCZaLUDUCeUhM=", "X-MC-Unique": "G_KT1XinM5CuEcvTCjcslA-1", "X-Mimecast-MFC-AGG-ID": "G_KT1XinM5CuEcvTCjcslA_1750063678", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<pobrn@protonmail.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v10 05/13] config: Look up rpi config path in configuration\n\tfile", "Date": "Mon, 16 Jun 2025 10:47:23 +0200", "Message-ID": "<20250616084733.18707-6-mzamazal@redhat.com>", "In-Reply-To": "<20250616084733.18707-1-mzamazal@redhat.com>", "References": "<20250616084733.18707-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "Og_iKJ42Gh0_aDImGNVJP-KTQ8YfaKvdXxSNfcILdwI_1750063678", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Let's introduce a configuration option for rpi configuration file path.\nIt may be arguable whether pipeline specific configurations belong to\nthe global configuration file. But:\n\n- Having a single configuration file is generally easier for the user.\n- The original configuration via environment variables can be already\n considered global.\n- This option points to other configuration files and it makes little\n sense to add another configuration file to the chain.\n\nThe configuration snippet:\n\n configuration:\n pipeline:\n rpi:\n config_file: FILENAME\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex d8c7ca935..850a5e31b 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -20,6 +20,7 @@\n #include <libcamera/property_ids.h>\n \n #include \"libcamera/internal/camera_lens.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/v4l2_subdevice.h\"\n \n@@ -1084,7 +1085,12 @@ int CameraData::loadPipelineConfiguration()\n \t/* Initial configuration of the platform, in case no config file is present */\n \tplatformPipelineConfigure({});\n \n-\tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RPI_CONFIG_FILE\");\n+\tconst GlobalConfiguration &config = pipe()->cameraManager()->_d()->configuration();\n+\tstd::optional<std::string> configFile =\n+\t\tconfig.envOption(\"LIBCAMERA_RPI_CONFIG_FILE\", \"pipelines.rpi.config_file\");\n+\tif (!configFile.has_value())\n+\t\treturn 0;\n+\tchar const *configFromEnv = configFile.value().c_str();\n \tif (!configFromEnv || *configFromEnv == '\\0')\n \t\treturn 0;\n \n", "prefixes": [ "v10", "05/13" ] }