Patch Detail
Show a patch.
GET /api/1.1/patches/23559/?format=api
{ "id": 23559, "url": "https://patchwork.libcamera.org/api/1.1/patches/23559/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23559/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250613100947.589875-4-stefan.klug@ideasonboard.com>", "date": "2025-06-13T10:09:38", "name": "[v2,3/4] test: ipa: Add failing test for single point Pwl", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3490970aaaeb0ffbfcba615e38924dadc335138c", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23559/mbox/", "series": [ { "id": 5217, "url": "https://patchwork.libcamera.org/api/1.1/series/5217/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5217", "date": "2025-06-13T10:09:35", "name": "ipa: pwl: Fixes for single point PWLs", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5217/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23559/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23559/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21C81BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Jun 2025 10:10:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9021B68DC7;\n\tFri, 13 Jun 2025 12:10:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E05868DC3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Jun 2025 12:10:12 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:37bc:6352:9b26:2f94])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4E08F56D;\n\tFri, 13 Jun 2025 12:10:02 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ndDLRsL1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749809403;\n\tbh=ulq+YLUIGfWaIQjjeAz+yVVdBZ7kRa/LyZPLVKOxARY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ndDLRsL1TNZ9pMkY4SSJ+lCiUr3J1hA2ye/ro3oP2ePSNjJ0srRZOCbF3hyiG2gaA\n\tzUPJXqqsJEMYuUEEi0VF+sRXV0S5v+MfRMih5pzkXA0ZLJJ274ltlwXVx+qJbhA4HK\n\t/Ee8pGYH4CXOU6mlpYZM7fyQUkbv9kuzXGgl/ws8=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 3/4] test: ipa: Add failing test for single point Pwl", "Date": "Fri, 13 Jun 2025 12:09:38 +0200", "Message-ID": "<20250613100947.589875-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250613100947.589875-1-stefan.klug@ideasonboard.com>", "References": "<20250613100947.589875-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Sometimes it is useful to have a Pwl with only a single point defined.\nA practical use case is tuning files with only a single entry for Pwl\nrelated parameters, where the expectation is that this entry just gets\nused.\n\nAdd a failing test case for such a single point Pwl.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n test/ipa/libipa/meson.build | 2 +-\n test/ipa/libipa/pwl.cpp | 7 +++++++\n 2 files changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/ipa/libipa/meson.build b/test/ipa/libipa/meson.build\nindex b2cc4b7461c1..c553366a7934 100644\n--- a/test/ipa/libipa/meson.build\n+++ b/test/ipa/libipa/meson.build\n@@ -4,7 +4,7 @@ libipa_test = [\n {'name': 'fixedpoint', 'sources': ['fixedpoint.cpp']},\n {'name': 'histogram', 'sources': ['histogram.cpp']},\n {'name': 'interpolator', 'sources': ['interpolator.cpp']},\n- {'name': 'pwl', 'sources': ['pwl.cpp']},\n+ {'name': 'pwl', 'sources': ['pwl.cpp'], 'should_fail': true },\n ]\n \n foreach test : libipa_test\ndiff --git a/test/ipa/libipa/pwl.cpp b/test/ipa/libipa/pwl.cpp\nindex d41a290a0e84..6640b1ab9f36 100644\n--- a/test/ipa/libipa/pwl.cpp\n+++ b/test/ipa/libipa/pwl.cpp\n@@ -43,6 +43,13 @@ protected:\n \n \t\tASSERT_EQ(pwl.size(), 2);\n \n+\t\t/* Test degenerate PWL. */\n+\t\tpwl.clear();\n+\t\tpwl.append(1, 1);\n+\t\tASSERT_EQ(pwl.eval(0), 1);\n+\t\tASSERT_EQ(pwl.eval(1), 1);\n+\t\tASSERT_EQ(pwl.eval(2), 1);\n+\n \t\treturn TestPass;\n \t}\n };\n", "prefixes": [ "v2", "3/4" ] }