Patch Detail
Show a patch.
GET /api/1.1/patches/23545/?format=api
{ "id": 23545, "url": "https://patchwork.libcamera.org/api/1.1/patches/23545/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23545/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611142431.33306-2-mzamazal@redhat.com>", "date": "2025-06-11T14:24:17", "name": "[v9,01/13] yaml: Move yaml_parser.cpp to base", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b807d689b0ff81c496988fc71695a2602e22161e", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23545/mbox/", "series": [ { "id": 5215, "url": "https://patchwork.libcamera.org/api/1.1/series/5215/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5215", "date": "2025-06-11T14:24:16", "name": "Add global configuration file", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5215/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23545/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23545/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14328C3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 14:24:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A9CA68DBF;\n\tWed, 11 Jun 2025 16:24:48 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D030E61552\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 16:24:45 +0200 (CEST)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-652-SNPerwLYNkOgKi73qTcqdA-1;\n\tWed, 11 Jun 2025 10:24:41 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8007C1800292; Wed, 11 Jun 2025 14:24:40 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.33.76])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 5FD2918003FC; Wed, 11 Jun 2025 14:24:38 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"KPLl5maH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1749651884;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=uIFhUZICIRNGXgo/daUbdCwyU+zzsteckUr59RsmEIE=;\n\tb=KPLl5maHYw5T7LC3yYAKh6vkagEvKD4yo6hvp3uZziyuu2TjFNaTe/o/oWTsjs8NSR59KU\n\t104Ccf9p9lRPAa2dCBr2PJeXPilsVnfunEgtEMXWZYkQ4b3kxHzILM8chVlWGY0RHSAcq8\n\tYjnHpcI4XhuCPHG2e+953vcmfE+4rxw=", "X-MC-Unique": "SNPerwLYNkOgKi73qTcqdA-1", "X-Mimecast-MFC-AGG-ID": "SNPerwLYNkOgKi73qTcqdA_1749651880", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<pobrn@protonmail.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v9 01/13] yaml: Move yaml_parser.cpp to base", "Date": "Wed, 11 Jun 2025 16:24:17 +0200", "Message-ID": "<20250611142431.33306-2-mzamazal@redhat.com>", "In-Reply-To": "<20250611142431.33306-1-mzamazal@redhat.com>", "References": "<20250611142431.33306-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "6h5h6dKCGQiUhv1TjDj0HdCSM69RqcF1t7_O3aZ-Y7w_1749651880", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Global configuration, which uses objects from the YAML parser, will be\naccessed from base. Thus YAML parser must be moved to base too.\n\nIndentation is changed in one place of the moved file to make the\nautoformatter and checkstyle.py happy.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/base/meson.build | 14 ++++++++++++++\n src/libcamera/{ => base}/yaml_parser.cpp | 13 ++++++-------\n src/libcamera/meson.build | 14 --------------\n 3 files changed, 20 insertions(+), 21 deletions(-)\n rename src/libcamera/{ => base}/yaml_parser.cpp (98%)", "diff": "diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\nindex a742dfdfe..94843eb95 100644\n--- a/src/libcamera/base/meson.build\n+++ b/src/libcamera/base/meson.build\n@@ -24,10 +24,12 @@ libcamera_base_internal_sources = files([\n 'thread.cpp',\n 'timer.cpp',\n 'utils.cpp',\n+ 'yaml_parser.cpp',\n ])\n \n libdw = dependency('libdw', required : false)\n libunwind = dependency('libunwind', required : false)\n+libyaml = dependency('yaml-0.1', required : false)\n \n if cc.has_header_symbol('execinfo.h', 'backtrace')\n config_h.set('HAVE_BACKTRACE', 1)\n@@ -41,11 +43,23 @@ if libunwind.found()\n config_h.set('HAVE_UNWIND', 1)\n endif\n \n+# Fallback to a subproject if libyaml isn't found, as it's not packaged in AOSP.\n+if not libyaml.found()\n+ cmake = import('cmake')\n+\n+ libyaml_vars = cmake.subproject_options()\n+ libyaml_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n+ libyaml_vars.append_compile_args('c', '-Wno-unused-value')\n+ libyaml_wrap = cmake.subproject('libyaml', options : libyaml_vars)\n+ libyaml = libyaml_wrap.dependency('yaml')\n+endif\n+\n libcamera_base_deps = [\n libatomic,\n libdw,\n libthreads,\n libunwind,\n+ libyaml,\n ]\n \n # Internal components must use the libcamera_base_private dependency to enable\ndiff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/base/yaml_parser.cpp\nsimilarity index 98%\nrename from src/libcamera/yaml_parser.cpp\nrename to src/libcamera/base/yaml_parser.cpp\nindex a5e424615..13111faaa 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/base/yaml_parser.cpp\n@@ -149,13 +149,12 @@ YamlObject::Getter<bool>::get(const YamlObject &obj) const\n \n template<typename T>\n struct YamlObject::Getter<T, std::enable_if_t<\n-\tstd::is_same_v<int8_t, T> ||\n-\tstd::is_same_v<uint8_t, T> ||\n-\tstd::is_same_v<int16_t, T> ||\n-\tstd::is_same_v<uint16_t, T> ||\n-\tstd::is_same_v<int32_t, T> ||\n-\tstd::is_same_v<uint32_t, T>>>\n-{\n+\t\t\t\t std::is_same_v<int8_t, T> ||\n+\t\t\t\t std::is_same_v<uint8_t, T> ||\n+\t\t\t\t std::is_same_v<int16_t, T> ||\n+\t\t\t\t std::is_same_v<uint16_t, T> ||\n+\t\t\t\t std::is_same_v<int32_t, T> ||\n+\t\t\t\t std::is_same_v<uint32_t, T>>> {\n \tstd::optional<T> get(const YamlObject &obj) const\n \t{\n \t\tif (obj.type_ != Type::Value)\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 202db1efe..24fcfcf57 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -55,7 +55,6 @@ libcamera_internal_sources = files([\n 'v4l2_subdevice.cpp',\n 'v4l2_videodevice.cpp',\n 'vector.cpp',\n- 'yaml_parser.cpp',\n ])\n \n includes = [\n@@ -83,7 +82,6 @@ if not cc.has_function('dlopen')\n libdl = cc.find_library('dl')\n endif\n libudev = dependency('libudev', required : get_option('udev'))\n-libyaml = dependency('yaml-0.1', required : false)\n \n # Use one of gnutls or libcrypto (provided by OpenSSL), trying gnutls first.\n libcrypto = dependency('gnutls', required : false)\n@@ -119,17 +117,6 @@ if libudev.found()\n ])\n endif\n \n-# Fallback to a subproject if libyaml isn't found, as it's not packaged in AOSP.\n-if not libyaml.found()\n- cmake = import('cmake')\n-\n- libyaml_vars = cmake.subproject_options()\n- libyaml_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n- libyaml_vars.append_compile_args('c', '-Wno-unused-value')\n- libyaml_wrap = cmake.subproject('libyaml', options : libyaml_vars)\n- libyaml = libyaml_wrap.dependency('yaml')\n-endif\n-\n control_sources = []\n \n controls_mode_files = {\n@@ -190,7 +177,6 @@ libcamera_deps += [\n libdl,\n liblttng,\n libudev,\n- libyaml,\n ]\n \n # We add '/' to the build_rpath as a 'safe' path to act as a boolean flag.\n", "prefixes": [ "v9", "01/13" ] }