Patch Detail
Show a patch.
GET /api/1.1/patches/23541/?format=api
{ "id": 23541, "url": "https://patchwork.libcamera.org/api/1.1/patches/23541/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23541/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-36-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:45", "name": "[35/35] libcamera: software_isp: Add a gpuisp todo list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "85b4b661df1087feec4ca88e14505498580094b3", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23541/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/1.1/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23541/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23541/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 596EDC3335\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:34:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D179E68E03;\n\tWed, 11 Jun 2025 03:34:44 +0200 (CEST)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E6A668DFD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:34:42 +0200 (CEST)", "by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-43cfe63c592so69825475e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:34:42 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.34.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:34:40 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"W5UyCopA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605681; x=1750210481;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=0m12xjA1BCDmYO4m2lL9R9mWTByBEaOo21WJw27iUYo=;\n\tb=W5UyCopAG3UQFjDfbglkRtdO9IQY6u9edbWIr3MMMI8MveCjpccJ8x2kHOcznJAQuA\n\tp/3sRgjxUHXivqGnDH0NTA8weLCe4qoO9442Ak7x7fmNfKNKg7NWjnxhxldPOn35bzJi\n\tVuJqHTqI0ADcBII/02QeKDnK8O4leHVhlvM1bA0fTPmxKzhRi/5RjIrf+D40g4RRx8/Y\n\tusybb2v5b0m26IVf3az1n545qhOJX++L0hh3BrMWp3U2CBbsoRfYsZtNui0O14/hENyp\n\t1R4wjfa+WoOkOFvzO+UAvSJXQ65/n4kGZzj4o7VL+ITt7q62dnbOx6IDSKyatl+CZW5l\n\trPCA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605681; x=1750210481;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=0m12xjA1BCDmYO4m2lL9R9mWTByBEaOo21WJw27iUYo=;\n\tb=Zn5KvWG+ed7VfGinwwj42pPzfiQNmYuePRoaiyaHxhojP1HtLPQYkE+x1+IHDHvIQ+\n\tfgtO5fGmf0brEsyHNWkPLuvs+ihMR3t8UwEF1qkRXVLM9XX7T6IJoR/QZ+nK5soZX4+1\n\tipzfWgObket/792WPQwUW8YuAniFCAoPdjI9rxRAQiFJQyO06uAVOen4l4FZggVpvTMC\n\tTky/I35IaVr5lwIrFA8Pjfq+besc+6C3znBsxfXELRceznQ0BFp6DpSgON2O3uYouhvY\n\tFw4Ug+ELNUFXJC6cQCzMKOCcRfML5IuxHcTprk5RdeOx4gkdSQz7MgAwjDPrQdGK0rnV\n\tXR8A==", "X-Gm-Message-State": "AOJu0YykypGaT+zIpwS3uMB3z9FnBfnk/i2Fnj+bXz7XAiWpNk0o31cf\n\tGSMvrOJD5QZu9N3q7QKbfTdsaTx9fMggWKMi1vU3bAX7uP65EjLN+t35zMcTMizRP3AiOW4TNRV\n\tPxGhyXGo=", "X-Gm-Gg": "ASbGncuO8dotg0XUpem8hQDP5XFvMrunwRUZc7t/TMAxynwjSegpk/nQ16jpwpnO/Yz\n\tCpAZEuqV5fjjVVZK/VpnP4BAcZOK6wou9Y83l7gyC4Jx38thucnj/Uq8X68qzcEOI4YFC/ar0v1\n\tPxxlT9PFd/gyy20yAZBo4YFx0RFcn4wHFhgemcQWo0ynOBmliK+yLpIXAZrPFPvDgBgt8+s3ffO\n\tpRdM5gE53GZLo7NDnwV4VvR7OHOWKBzgXAlqdpLordv7olfhZ6EJrcmPDzfUG8mLd75nsIE8x6U\n\tiudENW84z5qpJo3STbW8PrM1lRJjKGQFaVg7pWezTL/peBqPszW0hhhdjn85ZTiHxQJ5IcfGzpO\n\t//+DSyl+5ZUUEOTD5bnGweOm/lYhLT2dfo1QnCMrhOA==", "X-Google-Smtp-Source": "AGHT+IFNp0Sjvcl8jPoLVZmh7Sst78F3yLOfgBT480EJV5km6K6+s1njWkZ5YChVHD4PZMxnqdO2Gg==", "X-Received": "by 2002:a05:600c:3b93:b0:439:643a:c8d5 with SMTP id\n\t5b1f17b1804b1-453247f88a8mr11495815e9.0.1749605681310; \n\tTue, 10 Jun 2025 18:34:41 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 35/35] libcamera: software_isp: Add a gpuisp todo list", "Date": "Wed, 11 Jun 2025 02:32:45 +0100", "Message-ID": "<20250611013245.133785-36-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "List the series of things to do in GPU ISP in perceived order of\ndifficulty.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/gpuisp-todo.txt | 42 ++++++++++++++++++++++\n 1 file changed, 42 insertions(+)\n create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt", "diff": "diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\nnew file mode 100644\nindex 00000000..0ff82f81\n--- /dev/null\n+++ b/src/libcamera/software_isp/gpuisp-todo.txt\n@@ -0,0 +1,42 @@\n+List the TODOs in perceived order of ease.\n+\n+24 bit output support:\n+\t- Take the BPP we already capture and get a 24 bit GBM surface\n+\t- Pass a compile-time parameter to the shaders to tell them to do\n+\t gl_FragColor = rgb not gl_FragColor = rgba\n+\n+Make GPUISP default:\n+\t- Right now the environment variable allows over-riding to swtich\n+\t from CPU to GPU.\n+\t- Once we support 24 BPP output on GPUISP we will have the same\n+\t pixel format support as CPU and can set the default to GPU without\n+\t regressing functionality\n+\n+glTexture1D:\n+\t- Initial code was developed for < GLES 2.O but since we have fixed\n+\t on GLES >= 2.0 this means we can use glTexture1D\n+\t- Provided this is so amend the shaders to do val = texture(x, y, 0);\n+\t not texture(x, y, 0.5) the 0.5 is because of using glTexture2D\n+\n+Surfaceless GBM:\n+\t- We get a GBM surface and then have to swap buffers\n+\t If we rework for surfaceless GBM and EGL then the swap buffer can\n+\t be dropped.\n+\n+dma-buf texture upload:\n+\t- Currently we pass the input buffer to glCreateTexture2D.\n+\t We should be able to make the upload of the input buffer go faster\n+\t by using eglCreateImageKHR and enumerated the dma-buf contents.\n+\n+Render-to-texture:\n+\t- Right now we render to the GBM provided surface framebuffer\n+\t and then memcpy from that buffer to the target output buffer.\n+\t This necessitates flushing the cache on the target buffer in\n+\t addition to the memcpy().\n+\t- Render-to-texture where we generate the target framebuffer\n+\t directly from a dma-buf handle will mitigate the memcpy() phase.\n+\t- It should be the case then that the consumer of the output buffer\n+\t i.e. the thing that's not libcamera is responsible to flush the cache\n+\t if-and-only-if that user writes to the buffer.\n+\t- We need to flush the cache on the buffer because we are memcpying() to it.\n+\n", "prefixes": [ "35/35" ] }