Patch Detail
Show a patch.
GET /api/1.1/patches/23536/?format=api
{ "id": 23536, "url": "https://patchwork.libcamera.org/api/1.1/patches/23536/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23536/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-31-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:40", "name": "[30/35] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4332d9c2287e66c06675e1d2dd88742998b215e1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23536/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/1.1/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23536/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23536/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8ED1C3333\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:34:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53BBE68DF8;\n\tWed, 11 Jun 2025 03:34:28 +0200 (CEST)", "from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3773568DF0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:34:25 +0200 (CEST)", "by mail-wr1-x42f.google.com with SMTP id\n\tffacd0b85a97d-3a4f78ebec8so3674210f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:34:25 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.34.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:34:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Vv6Q3INo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605664; x=1750210464;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=HI49pYUXinc5VYst8KgNjwxFTmCviwBQg1gk8SwGa4M=;\n\tb=Vv6Q3INovc2VD+fZdN7w0NjpZzc6/xxIfgTfchnkb03o7Ozk8Ui9UodftqsqUYqf+U\n\t/cD8gCJBTjGpVMuy4oRXjfrJnidx6DR4hh0/i3KvWGhDzyVl/qG4WX5xWhFqquB/1fCM\n\tui4s2xfO6Xz1qxTnZG4qqOn7zSt3EfGFQMB1PMEEBazDJMPt82yCTHdiTLf30+64MlwG\n\t00VptdnWLGiXyLGgyCumyvN7QnSk5RKZG3aGyv1CIQNCeEHaionkxUWORpt8saIQc8yt\n\tB+z/+2ffHvl80H1uz8rdidlAI/rI2yStM8RsyvjHUbUVbGUu2/hJjFCL9pOCXn+xZc2a\n\tqdeA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605664; x=1750210464;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=HI49pYUXinc5VYst8KgNjwxFTmCviwBQg1gk8SwGa4M=;\n\tb=CR3ZWYjh3gUzmczwOhOsRdk0T7kraFbRnEE7NWeSE6ahlXN9Jsqm63We5KYwVgBCJy\n\t2QTIVxo4l82Z9GAzy1v/Tsaf0kNtje7diipDd+5nGbUowKtcjilrWZcalmw8fDnS5IJM\n\ticPBEq0zIDYYi9e4UqiNk3ZCzxf3Zb7RcFY8CtWCvwtLdf3d8E2CVsQF+xVSHXkWlvUP\n\tnj1IaBNT8CMN2bvW/ccIhUdFnfEUIb83cE17ilI3u1Vr8q82t01uqurHSIDN+GpF5LbV\n\trB03FzJ9gSdDvjZYtLhz7Jm6P8+J/jIPUsJrWKOJ0ZypJ6wyKXW2CCy0m25jc8dC6etG\n\tDNFQ==", "X-Gm-Message-State": "AOJu0YzJbmeEbPnVSzRZXNVD/jscQR5oztIhOn/jYzOLerv8x9AReuS6\n\te8/ddYPU5yuSZeUGH2+fyZyX5kRBH3taBueZVHMFzcRqWoGj5A7KVIzIsN6YUCJfAnZG3i2XL+X\n\tYHGsMYk4=", "X-Gm-Gg": "ASbGncuPKuif2MJ8uxysg0M8eMcaoaoXi6HMLh5PR/XPdtJfcZWsJt6IlaFlP3iqQp9\n\t0wvVUvR0dk4g0AzT6VUQBnHqFZL+s2HFdkkr8rBanyes4uJOw+ET76+5jpIU7CCXOF872M2hdee\n\trx9bVsKzaD5HZPwETCsoJWzot2+ggCDReqrw/YTfvqH+hrep2ErKupD+aU36kN1/o42kJAyk9R/\n\tQJXU8uguXguPxeEhmUUsBDYPTOYsnkGKX8by7mHRtnI6734mbqBCXhee03VnvcKD4sMPgOKeilh\n\tLJI6G5hRYsnPArfi1rJ88IEbaTE1PPWcCuqhMdi+Ipi1xm8sOzD1fw/sT18xAyCy2yV727DhS74\n\tdm7up2IrJ2RRgNh+E1BPGl+sTcI3Sw0XKNoNkk9ZWccsdW6aDQAyu", "X-Google-Smtp-Source": "AGHT+IFNonVCs10alOBA/xOndvNC/XdHixkaWZP8bBP6SF/LUlu+yLaKuB81KvQen6zSInKa8o4cTA==", "X-Received": "by 2002:a05:6000:4025:b0:3a4:f723:3e73 with SMTP id\n\tffacd0b85a97d-3a558aad7b3mr698227f8f.16.1749605664601; \n\tTue, 10 Jun 2025 18:34:24 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 30/35] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static", "Date": "Wed, 11 Jun 2025 02:32:40 +0100", "Message-ID": "<20250611013245.133785-31-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make getInputConfig and getOutputConfig static so as to allow for\ninterrogation of the supported pixel formats prior to object instantiation.\nDo this so as to allow the higher level logic make an informed choice\nbetween CPU and GPU ISP based on which pixel formats are supported.\n\nCurretnly CPU ISP supports more diverse input and output schemes.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex a043a954..999e3421 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -102,8 +102,8 @@ private:\n \ttemplate<bool addAlphaByte, bool ccmEnabled>\n \tvoid debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n \n-\tint getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n-\tint getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n+\tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n+\tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint setupStandardBayerOrder(BayerFormat::Order order);\n \tint setDebayerFunctions(PixelFormat inputFormat,\n \t\t\t\tPixelFormat outputFormat,\n", "prefixes": [ "30/35" ] }