Patch Detail
Show a patch.
GET /api/1.1/patches/23525/?format=api
{ "id": 23525, "url": "https://patchwork.libcamera.org/api/1.1/patches/23525/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23525/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-20-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:29", "name": "[19/35] libcamera: software_isp: ccm: Populate CCM table to Debayer params structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3f4be1ea7b9772f798bbce3fe46ad17095ae498d", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23525/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/1.1/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23525/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23525/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7CFFC3326\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:33:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EA2668DE2;\n\tWed, 11 Jun 2025 03:33:56 +0200 (CEST)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFCAA68DD4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:33:53 +0200 (CEST)", "by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-4531e146a24so9702735e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:33:53 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.33.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:33:52 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"a3co4uxJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605633; x=1750210433;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=eKYgK1WfN5ePoqdc0nHiHli5OuTT0JnN7h99qCjPS28=;\n\tb=a3co4uxJEWOJr4o3ltUzbeVhxy2zXqkb11wj6HoYYlMy14DKbMKPCsPZh1f6FVJ09X\n\t9J2gRTVcYxcBeVG2Wj6hoVPmGqVgCguMicNUgSCsbMwT3vepMHStONbd1xnTdzWC5ZtI\n\tEwjH1b4Sv2Z/X0326DG37Uk2D8A3g1A6nllmkWvmaUkZFVx9qI/7Pun3pNafWuQpyqgT\n\tMeEvfxsC3hQG9CAxolHe4rerTFIVhrdXCrNbfz2sP2Iqj50pP3i3vewKtwUDMS9mhFfr\n\tfPWkicyhGZa0vyl5c9hFfkLDySTWi95ESjnTZQUktdccqjw7yo2GuIcnCP9F5N0aSIgr\n\tvyoQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605633; x=1750210433;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=eKYgK1WfN5ePoqdc0nHiHli5OuTT0JnN7h99qCjPS28=;\n\tb=eTKyjP7f2x8E04TfNZ1y/udyv4E3l7JjBEj5+/SVWisBCjyUeerKfdwmExHCifUzII\n\t/ccWx7/vijgGrpX1g4zTsw4s5k+kI9l3vCbI6QItw7EvLMpUF4olXMGsDYoZuHsefwQz\n\tkmn7RYCMts0MF8q+H1eOu13ZuOrLQMB3US4yc6d9aR2M7ND1fcdyUOVWiiK158tE/UnY\n\tJy4RFW7lgrg8t1kO5W9r1WUF6aNLnGSHGpa7mUvpf5Is2JNCPR8B6Ebpq+RqgVQTtczQ\n\taLu62rfrnfIDN00P5Yjn9fEphC+aFKR+ll7Ryx9K/oaPBKkMBkZIkqiwecQb+5tpU/F3\n\tVkVw==", "X-Gm-Message-State": "AOJu0YxpZhhkWHQoRrsrtsh73bk8X/L3QkDblQulhrWYimtrP7ZFFHQY\n\twCNEPxdZAWIrHjspCCDoSHSrzTrK8TFRC67pd+K8Wo2Yh5jPCVdI/dh/Bcw3oA3t3HoIPulBsAe\n\tpCntdcbU=", "X-Gm-Gg": "ASbGncseZS2mrqZpqo9kdY0FO3m76LjQ4/AJmfVruxqalk9wcrsgCXQP3XpcAcuNRgl\n\tQutvmsxcIj+7ixeJVvHptNtJAm6tpFIx29JVPAXtLaBSNmzzMzXtZokFN3KoCjshYfQWwmyvZaZ\n\tKj5LLE21A/OnDx1xHH0AxfXGh2F9ujgXXLRpzWjX9GqRFkWapkyrzQwjrWQx3Q+IoVjr61EWY0f\n\tciD5XqFo+E9gCdR+80rSWP3ZMnwim7uwwWU5lsfJebA2nyy+2bwGm/liXTWMzeDu0ytZPKT8L2g\n\tDfAFPT0lLloCFXMCIYNvDOOMhDNV0soAQWqMFNyhpuxam70CeyF9Min9x5UbV2G8e4FYPu87THf\n\tTZiUqcV/xfIqBR3UoCdOh9W9vRZVJNMSVp1X2sx08dg==", "X-Google-Smtp-Source": "AGHT+IH4sxxVhXJp+vX7Vp0cDt3oPyvpWfSCb49R5uKKc2j2UH8qUFvJCHzC3zOs5A1oeT7ejVk+fw==", "X-Received": "by 2002:a05:600c:6087:b0:442:f956:53f9 with SMTP id\n\t5b1f17b1804b1-453248be49emr10321235e9.18.1749605633191; \n\tTue, 10 Jun 2025 18:33:53 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 19/35] libcamera: software_isp: ccm: Populate CCM table to\n\tDebayer params structure", "Date": "Wed, 11 Jun 2025 02:32:29 +0100", "Message-ID": "<20250611013245.133785-20-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Populate the DebayerParams CCM table during ccm::prepare(). A copy is made\nof the CCM into the DebayerParams structure.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/ipa/simple/algorithms/ccm.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex 0a98406c..cb023878 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -14,6 +14,7 @@\n #include <libcamera/control_ids.h>\n \n #include \"libcamera/internal/matrix.h\"\n+#include \"libcamera/internal/software_isp/debayer_params.h\"\n \n namespace {\n \n@@ -84,7 +85,7 @@ void Ccm::applySaturation(Matrix<float, 3, 3> &ccm, float saturation)\n }\n \n void Ccm::prepare(IPAContext &context, const uint32_t frame,\n-\t\t IPAFrameContext &frameContext, [[maybe_unused]] DebayerParams *params)\n+\t\t IPAFrameContext &frameContext, DebayerParams *params)\n {\n \tauto &saturation = context.activeState.knobs.saturation;\n \n@@ -108,6 +109,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \tcontext.activeState.ccm.ccm = ccm;\n \tframeContext.ccm.ccm = ccm;\n \tframeContext.saturation = saturation;\n+\tparams->ccm = ccm;\n \tcontext.activeState.ccm.changed = true;\n }\n \n", "prefixes": [ "19/35" ] }