Patch Detail
Show a patch.
GET /api/1.1/patches/23524/?format=api
{ "id": 23524, "url": "https://patchwork.libcamera.org/api/1.1/patches/23524/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23524/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-19-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:28", "name": "[18/35] meson: Automatically generate glsl_shaders.h from specified shader programs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "315dfd48cde74cf55e53e006da1f91f24d8df561", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23524/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/1.1/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23524/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23524/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86C06C332C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:33:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1652868DDC;\n\tWed, 11 Jun 2025 03:33:55 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6233268DD4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:33:51 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-451e2f0d9c2so3219735e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:33:51 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.33.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:33:50 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Tq1KFvPA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605631; x=1750210431;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TvNGubUkRMki02NFiKmKim9ORLxISkAfK1S9L+RNjSI=;\n\tb=Tq1KFvPAdoNW1TtuZ6A/MsSg3X5jvjyZ6X+ELd4fM8ZFVNumk7obCrca240Yv4vtj7\n\t2VYP4+Z3fgDsddiUPyvX/gAoWJx6KYKjM8Kd9fVy3mzU9RI+thnBgYw8FfcuZ03mFkh7\n\tv51wIqDqmrOG6YR1hx3SN6Fx8SYUnbpIEM5+FQ8cqIIrbo0WsPkTU/CkQPRio5UkvBgK\n\tJOirywgWu9qqtBru7ptf42y02iGWbDLW/7EO6EI7izVxjYdUWTTCObxlGFsb0HQxmOdZ\n\tkNTvNKNBvHquomZfzKZvR3V9+SAC/zIyQzc5hkAPhuoC58iuM7Et0AvRF5A6+72eDvIW\n\tZwxw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605631; x=1750210431;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=TvNGubUkRMki02NFiKmKim9ORLxISkAfK1S9L+RNjSI=;\n\tb=tlOXhdVB+zqkHzAHFefX42osJo9Ww0ONv+T4WZPHd73EYbplaO0gqEJ0gzxTVWMKyx\n\twAaLJU9FwvsVq85kjP0IQR6twV+uMG3o2EyBAEbdzWxg3/FvzWOHfej4RPXHjBsh7PxR\n\tgv2sqR22ZucSrnaDBrdH2qBd2uUqmsv9Nf4CyFR1V5YJ7X2lJJ0nrjaIkge9ds38BpM3\n\tiOhtkBG+QFssThFvnkpdUdoyiGsZeBMUaBzW+44+v77OPZQHhpyxe+IMxfHlkw2NJCbN\n\tkL9gjSpFlHaRDwn1DmGD/Jze6nHwaF0xfhi7zD5F6YHjDZ1WNKQqhjaJpVo0XEEMerK9\n\t9jLQ==", "X-Gm-Message-State": "AOJu0YzTpU4GHcXkgDguPiJe4qY3/HSOvCX0fWlrAzlL1R2U5e1dIlEr\n\tw5PDqYKWiNhyxa6dXSvq/VET1JVm7+Tk/KK6UanC5y2wRx179iPvzB34mdj4TPbtZA0ZqMBEA9Z\n\tvbp/UoMI=", "X-Gm-Gg": "ASbGncs8tmuwyHtT3jhbUJs2cwXKXTfs3cI+gDCayDahqVM9EoXzA+b3C1bZwIF+E6e\n\tF2YmwImYVdaOfkBWAbclzNBMG/vnxuEHrhoFsB74PbIo50yXFgT/oBmp82kfGErpAMbmHFX36s+\n\tDlhLmHKj4l1rbJLclHP5UZl7COpkZWQ7LwXcQELMHRi6b2NMcKHPD59eZTzNZsI4OJzNTjSOchi\n\tncBmIWpeJ/QT8IrEOB+iBVZy2BiuPcjwlJU0lNLcOm+6+B6SPRqFKIYw4FKDF5ihC5y6JTbqr//\n\t7blymPdoA4O4JlXG+fReDTu8JR58wSnSCZq8FKefWl/O/KNI5errNvKHovUi47u87AIZGNjfTUh\n\tyI6p8BWWw3uJzdgPgkRBD8kyLAJaCSGwuU+YQR5TV4/ppPkDrugX4", "X-Google-Smtp-Source": "AGHT+IGZoH9kNWwMCaOexy/Rmh4o/e2LXN3kRGanD7TQlX8pA+/kh8eYPmVfAS1BaxOZPBBorGQ3AQ==", "X-Received": "by 2002:a05:600c:3496:b0:43b:c6a7:ac60 with SMTP id\n\t5b1f17b1804b1-453242f49c0mr11339335e9.10.1749605630680; \n\tTue, 10 Jun 2025 18:33:50 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 18/35] meson: Automatically generate glsl_shaders.h from\n\tspecified shader programs", "Date": "Wed, 11 Jun 2025 02:32:28 +0100", "Message-ID": "<20250611013245.133785-19-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Encode the bayer shader files into a header as part of the build process.\nQcam already compiles the shader files down into a QT resource file which\nit references internally.\n\nIn order to share the debayering shader programs outside of qcam create a\ngeneric header which both qcam and libcamera can operate from.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/meson.build | 10 ++++++++++\n include/libcamera/internal/shaders/meson.build | 10 ++++++++++\n utils/meson.build | 2 ++\n 3 files changed, 22 insertions(+)\n create mode 100644 include/libcamera/internal/shaders/meson.build", "diff": "diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex 33f318b2..c0b593bf 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -1,6 +1,7 @@\n # SPDX-License-Identifier: CC0-1.0\n \n subdir('tracepoints')\n+subdir('shaders')\n \n libcamera_internal_headers = files([\n 'bayer_format.h',\n@@ -57,5 +58,14 @@ tracepoints_h = custom_target(\n \n libcamera_internal_headers += tracepoints_h\n \n+libcamera_shader_headers = custom_target(\n+ 'gen-shader-headers',\n+ input : [shader_files],\n+ output : 'glsl_shaders.h',\n+ command : [gen_shader_headers, meson.project_source_root(), meson.project_build_root(), '@OUTPUT@', '@INPUT@'],\n+)\n+\n+libcamera_internal_headers += libcamera_shader_headers\n+\n subdir('converter')\n subdir('software_isp')\ndiff --git a/include/libcamera/internal/shaders/meson.build b/include/libcamera/internal/shaders/meson.build\nnew file mode 100644\nindex 00000000..386b342d\n--- /dev/null\n+++ b/include/libcamera/internal/shaders/meson.build\n@@ -0,0 +1,10 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+# List of shader files to convert to header hex\n+# for the purposes of inclusion in OpenGL debayering\n+shader_files = files([\n+ 'bayer_1x_packed.frag',\n+ 'bayer_8.frag',\n+ 'bayer_8.vert',\n+ 'identity.vert',\n+])\ndiff --git a/utils/meson.build b/utils/meson.build\nindex 95d657ac..3deed8ad 100644\n--- a/utils/meson.build\n+++ b/utils/meson.build\n@@ -3,5 +3,7 @@\n subdir('codegen')\n subdir('ipu3')\n \n+gen_shader_headers = files('gen-shader-headers.sh')\n+\n ## Module signing\n gen_ipa_priv_key = files('gen-ipa-priv-key.sh')\n", "prefixes": [ "18/35" ] }