Patch Detail
Show a patch.
GET /api/1.1/patches/23523/?format=api
{ "id": 23523, "url": "https://patchwork.libcamera.org/api/1.1/patches/23523/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23523/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-18-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:27", "name": "[17/35] utils: gen-shader-headers: Add a utility to generate headers from shaders", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "272e0b02b0e89ff5247aa2924f3bd52c1f097477", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23523/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/1.1/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23523/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23523/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 458F9C332B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:33:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AD3068DE9;\n\tWed, 11 Jun 2025 03:33:50 +0200 (CEST)", "from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B898868DDE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:33:48 +0200 (CEST)", "by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-442e9c00bf4so50646485e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:33:48 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.33.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:33:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"kL9YGQPY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605628; x=1750210428;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Bu8bAsFBaqMQEQkx5cdIdQP+OHMD0PNQhcyagmWH6gY=;\n\tb=kL9YGQPYYWoYWQSY4vCW9PxNdikT8cZP6Lkz1+8R+ItQbymxoSXw1f8C27Sxl1PyL3\n\teSYjKT08OAGg1e5U3AInF6ErL31AE0OSAm427HppqQE7OZtJyvK04aCr3DSBlLkoTFtf\n\tptCUf+fdy78/suTWN6JFgThgEbtWz1eHLG7M2adON5Rv1UtfsWbUIQFK/X+B0VCYhCnc\n\tA1G780KWrBzUQsw3hKvVHZp9xDJXlPTzbFjOFKcY2cBxLkcHolRqHjOY2/fPyVsv5NPZ\n\tD+g7A76mji7dXqv0JL4feRXTyh9nfjkwWhgWVRQeC/Tf+gfhgkx79F6xQqdTcaI+eS3W\n\tbnLA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605628; x=1750210428;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Bu8bAsFBaqMQEQkx5cdIdQP+OHMD0PNQhcyagmWH6gY=;\n\tb=eZZg0rTrr9XZPkKqlvTd4BRquDvAC86LatSDq0tWVb8O/c6Gtye8i1fjXS0xXaona6\n\tas11YxZrYPf3ZpRBvojj4HRZfOcwyUYa38JFj3RlbrMUo/qlK2oO9WyRDZPQwMijEW+i\n\tKnlFhZ8CHawyDojB4PRWVmSBJv04+h0on2wkvJzhzz8v7ZkdSfPnR5kKBwwl8uo6QVD7\n\txxx4QiRpe9hXqWXSnHYKywLaqZBDO0DuktVNVtlmENvqvao51TMngz6YPnnm3kNIOXqk\n\trPZnQQHN55T5kosIv1VDT1BWdAhkKdcCMMPQbMqFNYWYHBx6898TGwG4mhI9QO1pAqbT\n\tmaRQ==", "X-Gm-Message-State": "AOJu0Yx7poepn8yT5nUiemScE7vvl81OV/VNU7Idlte0Fz8iOnk23aEq\n\tFQhbdSTIL1JOisNE7h6hEnres1s2Gu0Q0KxsCutu0NdNheeCOmKl+KKIELVsPWK5GsowOT3fhEO\n\t+tDq0aIs=", "X-Gm-Gg": "ASbGncvlRBXsnfshwRcE/eMiHXerd0OoNpYEbnMGeAdRzJcfMaecC4OHogE4FO50h9I\n\ta9QVTxbEu5fEy0QQbE692+0qFJ0kTiSvZmy4tjD/m6CYK/WFKKk21EmEa95lGNMMegM5F83c9k7\n\tyF0MK6q3Y+CVPs+p2XlSkM0xlf4a123LeNY7GYtn7zAIxWIY90hNcqjRIKrlIba/v6T5ERRlQyp\n\t2JsQyD4Z6gHVnc7nP8UF5Q5QtfOdEMSXFQ3OhwdS8aXvxnzlj5ONmwEx+2rF43En0KPD0so6nqt\n\th/CVc+iT70HiMytThrah3nSxwuL5IzrYvO95uqpwrBuwX3kvnImFf9Y3s69sbruJIMv964gSbWf\n\t8VEMn2H2/HmsyaOu62+JUz4nni8cHdKJiAjaoeU2ahQ==", "X-Google-Smtp-Source": "AGHT+IFimr21puVb8EtyrS/3T/KgKyIGY6mdse51NaZlDl4KrAuCpEUEBSONu/zpV6ioIKdUvGiSnQ==", "X-Received": "by 2002:a05:600c:3f0e:b0:43d:9d5:474d with SMTP id\n\t5b1f17b1804b1-45324d04de8mr8549755e9.0.1749605628104; \n\tTue, 10 Jun 2025 18:33:48 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 17/35] utils: gen-shader-headers: Add a utility to generate\n\theaders from shaders", "Date": "Wed, 11 Jun 2025 02:32:27 +0100", "Message-ID": "<20250611013245.133785-18-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Two simple script to generate a header that contains GLSL shaders translated\nto C arrays.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n utils/gen-shader-header.py | 38 ++++++++++++++++++++++++++++++++\n utils/gen-shader-headers.sh | 44 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 82 insertions(+)\n create mode 100755 utils/gen-shader-header.py\n create mode 100755 utils/gen-shader-headers.sh", "diff": "diff --git a/utils/gen-shader-header.py b/utils/gen-shader-header.py\nnew file mode 100755\nindex 00000000..6668e648\n--- /dev/null\n+++ b/utils/gen-shader-header.py\n@@ -0,0 +1,38 @@\n+#!/usr/bin/env python3\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# Copyright (C) 2025, Bryan O'Donoghue.\n+#\n+# Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n+#\n+# A python script which takes a list of shader files and converts into a C\n+# header.\n+#\n+import sys\n+\n+try:\n+ with open(sys.argv[2]) as file:\n+ data = file.read()\n+ data_len = len(data)\n+\n+ name = sys.argv[1].replace(\".\", \"_\")\n+ name_len = name + \"_len\"\n+\n+ j = 0\n+ print(\"unsigned char\", name, \"[] = {\")\n+ for ch in data:\n+ print(f\"0x{ord(ch):02x}, \", end=\"\")\n+ j = j + 1\n+ if j == 16:\n+ print()\n+ j = 0\n+ if j != 0:\n+ print()\n+ print(\"};\")\n+\n+ print()\n+ print(f\"const unsigned int {name_len}={data_len};\")\n+\n+except FileNotFoundError:\n+ print(f\"File {sys.argv[2]} not found\", file=sys.stderr)\n+except IOError:\n+ print(f\"Unable to read {sys.argv[2]}\", file=sys.stderr)\ndiff --git a/utils/gen-shader-headers.sh b/utils/gen-shader-headers.sh\nnew file mode 100755\nindex 00000000..ca4f19f0\n--- /dev/null\n+++ b/utils/gen-shader-headers.sh\n@@ -0,0 +1,44 @@\n+#!/bin/sh\n+set -x\n+\n+if [ $# -lt 4 ]; then\n+\techo \"Invalid arg count must be >= 5\"\n+\texit 1\n+fi\n+src_dir=\"$1\"; shift\n+build_dir=\"$1\"; shift\n+build_path=$build_dir/\"$1\"; shift\n+\n+cat <<EOF > \"$build_path\"\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/* This file is auto-generated, do not edit! */\n+/*\n+ * Copyright (C) 2025, Linaro Ltd.\n+ *\n+ */\n+\n+#pragma once\n+\n+EOF\n+\n+cat <<EOF >> \"$build_path\"\n+/*\n+ * List the names of the shaders at the top of\n+ * header for readability's sake\n+ *\n+EOF\n+\n+for file in \"$@\"; do\n+\techo \"file is $file\"\n+\tname=$(basename \"$build_dir/$file\" | tr '.' '_')\n+\techo \" * unsigned char $name;\" >> \"$build_path\"\n+done\n+\n+echo \"*/\" >> \"$build_path\"\n+\n+echo \"/* Hex encoded shader data */\" >> \"$build_path\"\n+for file in \"$@\"; do\n+\tname=$(basename \"$build_dir/$file\")\n+\t\"$src_dir/utils/gen-shader-header.py\" \"$name\" \"$build_dir/$file\" >> \"$build_path\"\n+\techo >> \"$build_path\"\n+done\n", "prefixes": [ "17/35" ] }