Patch Detail
Show a patch.
GET /api/1.1/patches/23519/?format=api
{ "id": 23519, "url": "https://patchwork.libcamera.org/api/1.1/patches/23519/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23519/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-14-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:23", "name": "[13/35] libcamera: software_isp: Move configure to worker thread", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1e5afac0095b6381ff51f46b8a779a03441014f1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23519/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/1.1/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23519/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23519/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E42EC3325\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:33:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA9D468DDC;\n\tWed, 11 Jun 2025 03:33:40 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A38468DC9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:33:38 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-43edecbfb46so51410865e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:33:38 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.33.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:33:37 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"RUGbdXj6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605618; x=1750210418;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=GKpObFN+EgBcQyqBbRGy4fFnCArup6QMMSIFijPSPfA=;\n\tb=RUGbdXj6qrDIj7nS+t8duxhwURkuyTq2by7gx0TkHofGyiW8DDZRYUMHj/vGy1izzk\n\tLZTd9wMg/OLqKfeV3mmXRKVYwju8gZy/xYWOw2p3EH+v7oUtYyR40JIyGWRrlwsVifQk\n\ttPC5MEof30KXvkfnFgjFXVMr/HXm/UZN3//nOdUZCZR1bJ/JFFg/zHajdg4idCkHh7/N\n\tiHnwEhq5zE4wnj1Ny4K54fehn83cbF2N41yVJBM0UDGSF1B6U+avVuJI/bOVkVdew4sH\n\t6ueJpA1OI9hBuK9FeBWX/poMhLPPbKaKUk/xzbzJZ4G1l0Uyxzks53jjXDaZLs5EYjiH\n\tNQ9A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605618; x=1750210418;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=GKpObFN+EgBcQyqBbRGy4fFnCArup6QMMSIFijPSPfA=;\n\tb=bDZvuA9METq+tOxGjngc2k3FhoPJ1NRnuMKQMdQEXOblbCbgD8wnQQ7nRDu+CZJNaQ\n\tac+aIPAPgahw+OWSQOecxnQOk8eif7g5WU0+vwp2v7BOzzN7k/YGdCAsBf1ZSJbJkIh7\n\tplEOy9w9LrHl7klN69+qzB3h2BQ+fyrJFi3jhrZfPn+NLRDk8olsqUwZcWQRExyS+xgx\n\tcoFXDZeYtYLvqmItiSRn313BGTLz/qdyTfhYrLKe+5MKEREJ3Ltf03zwX1XEqzE0RtDq\n\t9r5qCzDgELr+dD5xuuaN7V/+69Xy0nfxS3UpBIV6AlZNck3NYyG54IYQ+mn4u1SuAOO4\n\tGI6w==", "X-Gm-Message-State": "AOJu0YzO1h5D0pQOMNapVZMvY6iJkICQuMWMbwGizcpik1uzY9PAzNvC\n\tU4luJ2COOVZ9IYuqKYO9iuCui8QLPgpC9cUOqzStceJFRNdbiy/tyXgLzmvS5cXBiw0O0HqOT7L\n\tfOiZmUAY=", "X-Gm-Gg": "ASbGnct0gHCgkhqvm1T5ZethbqY8OUL38QZO610F6/tl9UiTK1bmRgV4wAmrd/8sPXt\n\tp5KbihQNuO9MNsz35k03tQEGcRBgvRovQ5oaOKSg0GoZ5IsA8+JcOYQy6k33WzAev6APJVVkACq\n\t2eWa289vUiRYhBb+5XFHZKEqhYCNi1RYuiz6Pna7NhH2lecuAfs54teh+4cta5R3hsMnmgUdrCf\n\tNruH5iiD+7H6QO2pqxLuHg78eqcOh/CiDV76vAlPiL8V8al4D9Tqa+vsUX29VzxJTCyl+5cdvPh\n\tyagJ2D1HPpa2gP4+J/AFVh2rj9d1Prb7VA64CFb5dP15qyPzeWgad3MtCCrdsZ7uhZJ3Cs5AV1Z\n\t2WWAtBQEO1bOWTLsWJdOvn2NthlQ/MpvitLo3Oaf4cQ==", "X-Google-Smtp-Source": "AGHT+IE9p03Zk5THt1Eqr79NheVJlXFqjchU2l+c3hdHz65PA6lX0ZVL/vV1CrDTr7MsN0KHrW49Mg==", "X-Received": "by 2002:a05:600c:83c6:b0:450:d5a5:e6c5 with SMTP id\n\t5b1f17b1804b1-45324f4906dmr5725615e9.26.1749605617844; \n\tTue, 10 Jun 2025 18:33:37 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 13/35] libcamera: software_isp: Move configure to worker\n\tthread", "Date": "Wed, 11 Jun 2025 02:32:23 +0100", "Message-ID": "<20250611013245.133785-14-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "OpenGL requires both configure() and process() to operate on the same\nthread. As preparation for that, move current CPU configure into the\nWorkerThread with a ConnectionTypeBlocking invocation of\n&DebayerCpu::configure.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 7bee8f06..e8fa8a17 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -263,7 +263,15 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tdebayer_->moveToThread(&ispWorkerThread_);\n \tispWorkerThread_.start();\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->invokeMethod(&Debayer::configure,\n+\t\t\t\t ConnectionTypeBlocking, inputCfg,\n+\t\t\t\t outputCfgs, ccmEnabled_);\n+\tif (ret) {\n+\t\tispWorkerThread_.exit();\n+\t\tispWorkerThread_.wait();\n+\t}\n+\n+\treturn ret;\n }\n \n /**\n@@ -386,7 +394,7 @@ void SoftwareIsp::stop()\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n \tipa_->computeParams(frame);\n-\tdebayer_->invokeMethod(&DebayerCpu::process,\n+\tdebayer_->invokeMethod(&Debayer::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n", "prefixes": [ "13/35" ] }