Patch Detail
Show a patch.
GET /api/1.1/patches/23502/?format=api
{ "id": 23502, "url": "https://patchwork.libcamera.org/api/1.1/patches/23502/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23502/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250606164156.1442682-22-barnabas.pocze@ideasonboard.com>", "date": "2025-06-06T16:41:54", "name": "[RFC,v1,21/23] libcamera: pipeline: rpi: Use `metadataAvailable()`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ca20c98f192efd92ea84ce9b70d67df0113791c7", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23502/mbox/", "series": [ { "id": 5210, "url": "https://patchwork.libcamera.org/api/1.1/series/5210/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5210", "date": "2025-06-06T16:41:33", "name": "libcamera: Add `MetadataList`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5210/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23502/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23502/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 321A4C3330\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Jun 2025 16:42:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4B4B68DE3;\n\tFri, 6 Jun 2025 18:42:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D685668DD4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Jun 2025 18:42:20 +0200 (CEST)", "from pb-laptop.local (185.182.215.79.nat.pool.zt.hu\n\t[185.182.215.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5ED708DB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Jun 2025 18:42:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UVb/aVDW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749228136;\n\tbh=GfFwFjJcvkYj36wlL1DD6cCGMcoRu84novp/y0KZMyo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UVb/aVDWLNZvfnRDVry2FeNrAb+1Y2OG4oiKf26HHoblHiLVJuc/hiyv+nmUcZ1As\n\tSCtP5NjP7Dztr2S273tuIaBxwBI0WM3SY5P1Qo15hGWnuRkeV1aWQaL4rkwvNkH10u\n\tweItR4RhIK8HL9XQtJdLsmc+fnMp20sFhi+8MAEE=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 21/23] libcamera: pipeline: rpi: Use\n\t`metadataAvailable()`", "Date": "Fri, 6 Jun 2025 18:41:54 +0200", "Message-ID": "<20250606164156.1442682-22-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>", "References": "<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the newly introduced `metadataAvailable()` function to send metadata\nitems to the application.\n\nObsoleted by https://patchwork.libcamera.org/cover/23474/.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex d432cfb51..c5dd6fd94 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1407,7 +1407,7 @@ void CameraData::clearIncompleteRequests()\n \t\t}\n \n \t\t// TODO: need this when cancelled?\n-\t\trequest->metadata().merge(metadata);\n+\t\tpipe()->metadataAvailable(request, metadata);\n \n \t\tpipe()->completeRequest(request);\n \t\trequestQueue_.pop();\n@@ -1485,7 +1485,7 @@ void CameraData::checkRequestCompleted()\n \t\tLOG(RPI, Debug) << \"Completing request sequence: \"\n \t\t\t\t<< request->sequence();\n \n-\t\trequest->metadata().merge(metadata);\n+\t\tpipe()->metadataAvailable(request, metadata);\n \n \t\tpipe()->completeRequest(request);\n \t\trequestQueue_.pop();\n", "prefixes": [ "RFC", "v1", "21/23" ] }