Patch Detail
Show a patch.
GET /api/1.1/patches/23480/?format=api
{ "id": 23480, "url": "https://patchwork.libcamera.org/api/1.1/patches/23480/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23480/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250606105651.1624640-7-naush@raspberrypi.com>", "date": "2025-06-06T10:55:24", "name": "[v3,6/6] ipa: rpi: Rename dropFrameCount_ to invalidCount_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "46b7571abbe041919b5a1e52f942057afabc9572", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23480/mbox/", "series": [ { "id": 5209, "url": "https://patchwork.libcamera.org/api/1.1/series/5209/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5209", "date": "2025-06-06T10:55:18", "name": "Eliminating startup frames", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5209/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23480/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23480/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3225EC3325\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Jun 2025 10:57:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29E7A68DC4;\n\tFri, 6 Jun 2025 12:57:11 +0200 (CEST)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1CD268DBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Jun 2025 12:57:00 +0200 (CEST)", "by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-3a4e57d018cso318295f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 06 Jun 2025 03:57:00 -0700 (PDT)", "from NAUSH-P-DELL.tail9c427.ts.net ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-452137277afsm20092455e9.30.2025.06.06.03.56.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Jun 2025 03:56:59 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"kqXQOqsn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1749207420; x=1749812220;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=+1kR8yrdGRXTW45504PuBDRwP7cmAEbOv3Y11k50OaI=;\n\tb=kqXQOqsnp5TkRG2o8FNLin+JQUc5DvIliGX/32y6MMMrTmhejdMv9u1tB+qonUmDD8\n\tLJ8DK56QyDgaf+4EmwJ5SfdqyYvGlmVr1MNH9yyRg/+4kQy9J0uemK6igi5BMWzYoRBW\n\t/cyAEj2cABeywuSBCTAoPxjt+T5+KBXRnGNhFK/qnceZ2EPem2MDvwEsDyfCDgbEV031\n\tEir6wMmdtHSaLZYKMScDlPWSIdlNBdgpVHzqnxozJhJsuvlq8AfIF9oKXIPOWMt2ydBT\n\tDNouWh05Wc5RtN09cm2BSgOoHy+nsYczrheUI+HSaOXEjuoguKkF8M5dWxW4m3tiGBc4\n\tek1Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749207420; x=1749812220;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=+1kR8yrdGRXTW45504PuBDRwP7cmAEbOv3Y11k50OaI=;\n\tb=FiTFWUMTwFkECYZ2XW5efzNLM9CNvGGRpTfEs7mt2tU91lLBuwCP+EOifWiuyJ3BwK\n\tf1EK7yG/12MZlvT2urecBvjCH6HDUsmU0oB50kWlxknjVIWuEXZ96+pyqejEJec/RgVf\n\t3nA5jBxrUk1jODWj+soy+77JYNyFNbbVXy47MGROxfj7EIhiyxrtQDhdN5X4u6h7+uJ+\n\thuB3Nhb/cR3t6qm6RfWjwQLGooZN4nTBl+vBBb70PrwM2y3MojYnRFcDg7zbSQjLTLC2\n\tOX1mu3aX/T8seTBgp6n1OW0gjqJcJUv0uhGFJqK2fZpezJNgvVyLmW2unMIx3XpDYplV\n\tsWVw==", "X-Gm-Message-State": "AOJu0YzzRAz+Nld4iRqKOtnAms3ic4Y371KcNn9MsVTMP/Sj8wcmOK71\n\tNNGjxQRGcH9iSBXNnPFPSFACkYqAMSE2OD7VZtTyNJbtDA5kNaRzZ3A2FdnXHKBYoQK8xzK+Q0W\n\t6H1L2", "X-Gm-Gg": "ASbGncvA4OlAFFtFGPSB/3WbC16egD7mV4aU7VL5T9cjLXtViokaMgqP5n5ElrzUCQr\n\t6d8B1px67+3bTbrtC3/1C6dSX3eCyVlm8F8xh+XAfSjZ1NUj1ebtbkDXgI5JWCMkTDPKz7Z8ued\n\tdj51f7BdxGNCaHVV0UebWAwa9Z8c6rBm5AbNmMEM5l+hKkVStaIA2YcAvCoxUxp0Adw0IvrRL1K\n\tIXhIcFIpBydDSYzeiy+erd3quW5vohqkMDXYiE5uJj8u00UNy6fVDzz5r01gqE1D/K6lDvTRpie\n\tBTZp0PUMk5n1S7fFeqRdIRXjyokq62osV27MK5IprkSCh8EKCL8naQN/w4rvvCDbzo1U/jegvVJ\n\tU", "X-Google-Smtp-Source": "AGHT+IECrpuT7Vsm0ybGrsT1SDG6pyRE7VNVe4Qu3vQihNe6veKOCtK/vZlZQ2gC+CntrBAqB4LTog==", "X-Received": "by 2002:a05:600c:6206:b0:43d:2318:ed7f with SMTP id\n\t5b1f17b1804b1-4528a05cf37mr8223605e9.0.1749207420177; \n\tFri, 06 Jun 2025 03:57:00 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v3 6/6] ipa: rpi: Rename dropFrameCount_ to invalidCount_", "Date": "Fri, 6 Jun 2025 11:55:24 +0100", "Message-ID": "<20250606105651.1624640-7-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250606105651.1624640-1-naush@raspberrypi.com>", "References": "<20250606105651.1624640-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename dropFrameCount_ to invalidCount_ to better reflect its use as\nframes are no longer dropped by the pipeline handler.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 10 +++++-----\n src/ipa/rpi/common/ipa_base.h | 4 ++--\n 2 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex eee81e064e0d..50e25f05765d 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -327,7 +327,7 @@ void IpaBase::start(const ControlList &controls, StartResult *result)\n \tunsigned int agcConvergenceFrames = 0, awbConvergenceFrames = 0;\n \tframeCount_ = 0;\n \tif (firstStart_) {\n-\t\tdropFrameCount_ = helper_->hideFramesStartup();\n+\t\tinvalidCount_ = helper_->hideFramesStartup();\n \t\tmistrustCount_ = helper_->mistrustFramesStartup();\n \n \t\t/*\n@@ -353,14 +353,14 @@ void IpaBase::start(const ControlList &controls, StartResult *result)\n \t\t\t\tawbConvergenceFrames += mistrustCount_;\n \t\t}\n \t} else {\n-\t\tdropFrameCount_ = helper_->hideFramesModeSwitch();\n+\t\tinvalidCount_ = helper_->hideFramesModeSwitch();\n \t\tmistrustCount_ = helper_->mistrustFramesModeSwitch();\n \t}\n \n \tresult->startupFrameCount = std::max({ agcConvergenceFrames, awbConvergenceFrames });\n-\tresult->invalidFrameCount = dropFrameCount_;\n+\tresult->invalidFrameCount = invalidCount_;\n \n-\tdropFrameCount_ = std::max({ dropFrameCount_, agcConvergenceFrames, awbConvergenceFrames });\n+\tinvalidCount_ = std::max({ invalidCount_, agcConvergenceFrames, awbConvergenceFrames });\n \n \tLOG(IPARPI, Debug) << \"Startup frames: \" << result->startupFrameCount\n \t\t\t << \" Invalid frames: \" << result->invalidFrameCount;\n@@ -443,7 +443,7 @@ void IpaBase::prepareIsp(const PrepareParams ¶ms)\n \n \t/* Allow a 10% margin on the comparison below. */\n \tDuration delta = (frameTimestamp - lastRunTimestamp_) * 1.0ns;\n-\tif (lastRunTimestamp_ && frameCount_ > dropFrameCount_ &&\n+\tif (lastRunTimestamp_ && frameCount_ > invalidCount_ &&\n \t delta < controllerMinFrameDuration * 0.9 && !hdrChange) {\n \t\t/*\n \t\t * Ensure we merge the previous frame's metadata with the current\ndiff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex 1a811beb31f2..e818104ba633 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -115,8 +115,8 @@ private:\n \t/* How many frames we should avoid running control algos on. */\n \tunsigned int mistrustCount_;\n \n-\t/* Number of frames that need to be dropped on startup. */\n-\tunsigned int dropFrameCount_;\n+\t/* Number of frames that need to be marked as dropped on startup. */\n+\tunsigned int invalidCount_;\n \n \t/* Frame timestamp for the last run of the controller. */\n \tuint64_t lastRunTimestamp_;\n", "prefixes": [ "v3", "6/6" ] }