Patch Detail
Show a patch.
GET /api/1.1/patches/23478/?format=api
{ "id": 23478, "url": "https://patchwork.libcamera.org/api/1.1/patches/23478/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23478/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250606105651.1624640-5-naush@raspberrypi.com>", "date": "2025-06-06T10:55:22", "name": "[v3,4/6] pipeline: rpi: Remove disable_startup_frame_drops config option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1fc87fa7ce6b2d49b9b505fdb229a34733807c20", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23478/mbox/", "series": [ { "id": 5209, "url": "https://patchwork.libcamera.org/api/1.1/series/5209/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5209", "date": "2025-06-06T10:55:18", "name": "Eliminating startup frames", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5209/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23478/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23478/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F048C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Jun 2025 10:57:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1311768DBF;\n\tFri, 6 Jun 2025 12:57:08 +0200 (CEST)", "from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E7AB68DC3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Jun 2025 12:57:00 +0200 (CEST)", "by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-44ff4081975so470095e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 06 Jun 2025 03:57:00 -0700 (PDT)", "from NAUSH-P-DELL.tail9c427.ts.net ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-452137277afsm20092455e9.30.2025.06.06.03.56.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Jun 2025 03:56:58 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RnkhOZ5F\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1749207419; x=1749812219;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=8NJR7QRxV2lxaWVQp05RjZAoEuju/VJwaB09A6PDeMc=;\n\tb=RnkhOZ5FaHiL9v1pMggHTPZvRfekHQ0bVt8hMF/brjSr/rTEXeXookPkJzPA+/mjeh\n\tkZ0iCvIgdQ8JB2NoBveGuraeFk2WOlqwSDDZE1Htm3JUXjRTsDrYKvmH3JrAxMbHs8F4\n\tnmWL7zLzz7+QUwMf0c4eL+n0j8Tcc0Ah/7dbSE6qGjBk37nY3n3akrvDRfWeBntfBG4O\n\thsYkF+GK7HMvHxKhN0sR7lCOfbGDcnsZDq8WtY1jN+qvkQ28bKxCg+jYW9xrK2DWuIYH\n\tIpgBGGtqspzX5yJ21nvVZY69uEh1Kqp16oV/V/JXBjqZ9lORoww9OypZV19j45Ts7fbf\n\tRXXA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749207419; x=1749812219;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=8NJR7QRxV2lxaWVQp05RjZAoEuju/VJwaB09A6PDeMc=;\n\tb=EPoCi3PsMy4SsoG0Z8Hn0ff+lCbeW9aJL3oA8JCoKJY8BY2j6k5EBqKoFgFAOXyGJw\n\tOyfn0mUFBut+V8UbY+VffnvO6ml8MD3GKoRQNxtBuNm+JuETQyvx6yQteoz+/2spbc3g\n\tKgZM7cjIio1qcTCE7fv1IifIDKBkKEJl5cHPG7Pz9a1mwYI2IpDT+yolvVYEYsLvXIwG\n\t2GgGEj4CyBlA1lpPcDNkbSf0fHCr9ocBrIb9da6Iqdy41QHDIy+pFyBgmStYsVX9kjZ6\n\trPfruyxyNBo2NmYni9n3uqnglFBEb/Dzz0QH/g4tcKFrTLM4v0U/L4GJIECudMqZpDEM\n\tWnKQ==", "X-Gm-Message-State": "AOJu0YzRq3Ad7NlXmgXCQ4Ea/zvzQ9VlCnpon2MjsB8m7Fcdjxe80kk9\n\tH5dLU+UBQ6b8epHXIit9Rf8WNwyYECZZ3fJ8b4qMuSOKRSky1R3GzFqiAqlgagbPzzmfn7C9gHD\n\tkVppv", "X-Gm-Gg": "ASbGncuKdw7KCSWn12K8eRtAqLMAoPf9iqCJ0rwKGWl4+V/lWOrli+ala2l1VecDjDa\n\t1cHSH8BEAVBCOGEE42NjZRDbQ3XKNQu79Hsw3/neDYORGvOiZZM+ozLvQfg6cRXM0X5y9cfibGp\n\tHvnUruVd4qs8EEoC8EGsNnSWlelg/pdXfXVWU5E2RSkzomLcAEACcBgx4J3k6qEpJvzo9HqgTHy\n\t+ZKZYKBFLH+MfBbe2vFLS7xGQ6EyQERNxqFQlKZfpbR9VR3FDAt6Wii0yfV8SMSf0uQn6TMtRHe\n\tCbXF+ZZdY18eHH3oEt5gFfWigUchPRLFmPBxXGwbuZtnLLoB/pBseXZC8DKM7mMKyRavzVHaUOZ\n\tF", "X-Google-Smtp-Source": "AGHT+IHptrA5q0hNbIuu9PZBQQGJaQSXmW5e0o+MhrAne8aJqTfEoL0gJBCc51h8+3500PRutFx82w==", "X-Received": "by 2002:a05:600c:4f0f:b0:442:fff5:5185 with SMTP id\n\t5b1f17b1804b1-4529abdfba3mr7809445e9.6.1749207418999; \n\tFri, 06 Jun 2025 03:56:58 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v3 4/6] pipeline: rpi: Remove disable_startup_frame_drops\n\tconfig option", "Date": "Fri, 6 Jun 2025 11:55:22 +0100", "Message-ID": "<20250606105651.1624640-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250606105651.1624640-1-naush@raspberrypi.com>", "References": "<20250606105651.1624640-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the previous change to not drop frames in the pipeline handler,\nthe \"disable_startup_frame_drops\" pipeline config option is not used.\nRemove it, and throw a warning if the option is present in the YAML\nconfig file.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 7 ++++---\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 5 -----\n src/libcamera/pipeline/rpi/pisp/data/example.yaml | 5 -----\n src/libcamera/pipeline/rpi/vc4/data/example.yaml | 5 -----\n 4 files changed, 4 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 3f0b7abdc59a..d8c7ca9352de 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1078,7 +1078,6 @@ void CameraData::enumerateVideoDevices(MediaLink *link, const std::string &front\n int CameraData::loadPipelineConfiguration()\n {\n \tconfig_ = {\n-\t\t.disableStartupFrameDrops = false,\n \t\t.cameraTimeoutValue = 0,\n \t};\n \n@@ -1115,8 +1114,10 @@ int CameraData::loadPipelineConfiguration()\n \n \tconst YamlObject &phConfig = (*root)[\"pipeline_handler\"];\n \n-\tconfig_.disableStartupFrameDrops =\n-\t\tphConfig[\"disable_startup_frame_drops\"].get<bool>(config_.disableStartupFrameDrops);\n+\tif (phConfig.contains(\"disable_startup_frame_drops\"))\n+\t\tLOG(RPI, Warning)\n+\t\t\t<< \"The disable_startup_frame_drops key is now deprecated, \"\n+\t\t\t<< \"startup frames are now identified by the FrameMetadata::Status::FrameStartup flag\";\n \n \tconfig_.cameraTimeoutValue =\n \t\tphConfig[\"camera_timeout_value_ms\"].get<unsigned int>(config_.cameraTimeoutValue);\ndiff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\nindex 6023f9f9d6b3..e27c4f860d1a 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n@@ -164,11 +164,6 @@ public:\n \tbool buffersAllocated_;\n \n \tstruct Config {\n-\t\t/*\n-\t\t * Override any request from the IPA to drop a number of startup\n-\t\t * frames.\n-\t\t */\n-\t\tbool disableStartupFrameDrops;\n \t\t/*\n \t\t * Override the camera timeout value calculated by the IPA based\n \t\t * on frame durations.\ndiff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\nindex d67e654a8b9e..baf03be79bb3 100644\n--- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n+++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n@@ -16,11 +16,6 @@\n #\n # \"num_cfe_config_queue\": 2,\n \n- # Override any request from the IPA to drop a number of startup\n- # frames.\n- #\n- # \"disable_startup_frame_drops\": false,\n-\n # Custom timeout value (in ms) for camera to use. This overrides\n # the value computed by the pipeline handler based on frame\n # durations.\ndiff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\nindex b8e01adeaf40..27e543488d48 100644\n--- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n+++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n@@ -29,11 +29,6 @@\n #\n # \"min_total_unicam_buffers\": 4,\n \n- # Override any request from the IPA to drop a number of startup\n- # frames.\n- #\n- # \"disable_startup_frame_drops\": false,\n-\n # Custom timeout value (in ms) for camera to use. This overrides\n # the value computed by the pipeline handler based on frame\n # durations.\n", "prefixes": [ "v3", "4/6" ] }