Patch Detail
Show a patch.
GET /api/1.1/patches/23421/?format=api
{ "id": 23421, "url": "https://patchwork.libcamera.org/api/1.1/patches/23421/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23421/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250522075244.1198110-7-naush@raspberrypi.com>", "date": "2025-05-22T07:48:22", "name": "[v2,6/6] ipa: rpi: Rename dropFrameCount_ to startupCount_", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dda635295b3dd1d6ad5fbbd2235f6a2daafb45ed", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23421/mbox/", "series": [ { "id": 5188, "url": "https://patchwork.libcamera.org/api/1.1/series/5188/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5188", "date": "2025-05-22T07:48:16", "name": "Eliminating startup frames", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5188/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23421/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23421/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7097C331D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 May 2025 07:53:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50FAC68D9C;\n\tThu, 22 May 2025 09:53:01 +0200 (CEST)", "from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F37D668D9A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 May 2025 09:52:51 +0200 (CEST)", "by mail-wr1-x431.google.com with SMTP id\n\tffacd0b85a97d-3a365bc0af8so559999f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 May 2025 00:52:51 -0700 (PDT)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a3ca066eb7sm4191516f8f.2.2025.05.22.00.52.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 22 May 2025 00:52:50 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"q7KqahLx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1747900371; x=1748505171;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=LZqiQlR9owO1wtt/qZunnLktQ2lr/L7FkNTRGEyHuSo=;\n\tb=q7KqahLxI3A8LNi8VO7RTPpIPHyKNnJMpigQjsRIo/WyZ95s63wn+UA0AJxGkJW4Nw\n\t07/d6PKBapnxGef34RHyghOUNEw4eTti80LPhpwwmXYakLgcM4IeRCpooc4ifXqdhpbM\n\t7utKGtx3K4JjfBou+1R/IUGiCNiWTfgHviYSZwyQdavW4duhR7uHo1C4rjBuu9oFuZlj\n\tA9JauiZjySax2VmohJGOAznk9z6IQktp9AJCtlrceOlPAK/vja5CITx51lEkov20jkjP\n\tqLQE8GgDD4B+7ZhbTex9Si43Mj1TbT64WLnsrHKCtf2QFr6kvTAN7ExX5maqg+peytjQ\n\tb+4Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1747900371; x=1748505171;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=LZqiQlR9owO1wtt/qZunnLktQ2lr/L7FkNTRGEyHuSo=;\n\tb=D/2DvNefCAUlxRLQH9QllcrXQ9ATN9rnhp/QDYwN3tT6SW0t83WsUCI+N87ZPBx0/2\n\tSN0+TV40VRCjntv/wF6yoDLwXzqqRfaVHkKnr9yEXQkdgLDb8G4goLNuSpyjemRaCNIb\n\tem5cOSZdwS3Ffe6malzNxkWApCM2e6i7dNGGYScwP0HDYA67FODufFPNukWBx661D23N\n\tAzb4ZH8SbcsJX0O36zXq8W8OMpeutkcg2BUdLvD4IvkZFmprKy5400BxiVlPNvGnRIHS\n\tWCvzK8qkGkoeqCsEy0RFnfJKiVj+ik+Ix2mKed42XsU5sAoQC4fSMkrAWpgf5gKaLEJS\n\t1DuA==", "X-Gm-Message-State": "AOJu0YxUTrfgNslSlbMX50Uu2Ppqgk5KGSWuuk6tujgriib2M60NR32w\n\t4EfwdNX4N3m97kGKbxfSjIF99qYzfHeH9z6Hd7JFd4hmvcDTCwOetZ5nU7+sYcL1tkStoAHivDH\n\tYKV0B", "X-Gm-Gg": "ASbGnct+JhTUQr23rjZbC5IGK+IwYM8y+wJtdzkv4jJXhf/X3BKrPZslGJiaUgKQUqH\n\t1WhN7+WCViIyKtPtdlwsv0dZG9WNufV6vaEWHgJzoUTSg+n1u8EvHuHpHP00n7M8GmbEct+zvha\n\txg3Px/QDLxLUumBI6tMkwYSkk29Mhmd1SdabZMWNWJPwIZyizM7xB+Oz2dFRkagioKuATWXx8Md\n\t9ClTmt/ZsPcxuVz6A6oOb2e+TvCOgU/dItp+asN1CYyXnq/Z+Za6kecsxV4DkdAT2CLzYTeQsjG\n\t62TQTQsuxFZ/JuYD3iij+im3X8Xly7v56bLExnpIfd6aZ8F7z5lphwvfP5GZS+3VqQ2s8lE=", "X-Google-Smtp-Source": "AGHT+IF8EHRy4DXetsyS78VNd/9WTw78b9zq3+ReMWJtFSYv66fPAamWEBrISf45bENRs4+jkw+STg==", "X-Received": "by 2002:a05:6000:2284:b0:3a3:6e0e:a09d with SMTP id\n\tffacd0b85a97d-3a36e0ea15dmr5782700f8f.6.1747900370791; \n\tThu, 22 May 2025 00:52:50 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>", "Subject": "[PATCH v2 6/6] ipa: rpi: Rename dropFrameCount_ to startupCount_", "Date": "Thu, 22 May 2025 08:48:22 +0100", "Message-ID": "<20250522075244.1198110-7-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250522075244.1198110-1-naush@raspberrypi.com>", "References": "<20250522075244.1198110-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename dropFrameCount_ to startupCount_ to better reflect its use as\nframes are no longer dropped by the pipeline handler.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 10 +++++-----\n src/ipa/rpi/common/ipa_base.h | 4 ++--\n 2 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex c15f8a7bf71e..8d591faeceaa 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -327,7 +327,7 @@ void IpaBase::start(const ControlList &controls, StartResult *result)\n \tunsigned int agcConvergenceFrames = 0, awbConvergenceFrames = 0;\n \tframeCount_ = 0;\n \tif (firstStart_) {\n-\t\tdropFrameCount_ = helper_->hideFramesStartup();\n+\t\tstartupCount_ = helper_->hideFramesStartup();\n \t\tmistrustCount_ = helper_->mistrustFramesStartup();\n \n \t\t/*\n@@ -353,14 +353,14 @@ void IpaBase::start(const ControlList &controls, StartResult *result)\n \t\t\t\tawbConvergenceFrames += mistrustCount_;\n \t\t}\n \t} else {\n-\t\tdropFrameCount_ = helper_->hideFramesModeSwitch();\n+\t\tstartupCount_ = helper_->hideFramesModeSwitch();\n \t\tmistrustCount_ = helper_->mistrustFramesModeSwitch();\n \t}\n \n \tresult->startupFrameCount = std::max({ agcConvergenceFrames, awbConvergenceFrames });\n-\tresult->invalidFrameCount = dropFrameCount_;\n+\tresult->invalidFrameCount = startupCount_;\n \n-\tdropFrameCount_ = std::max({ dropFrameCount_, agcConvergenceFrames, awbConvergenceFrames });\n+\tstartupCount_ = std::max({ startupCount_, agcConvergenceFrames, awbConvergenceFrames });\n \n \tLOG(IPARPI, Debug) << \"Startup frames: \" << result->startupFrameCount\n \t\t\t << \" Invalid frames: \" << result->invalidFrameCount;\n@@ -443,7 +443,7 @@ void IpaBase::prepareIsp(const PrepareParams ¶ms)\n \n \t/* Allow a 10% margin on the comparison below. */\n \tDuration delta = (frameTimestamp - lastRunTimestamp_) * 1.0ns;\n-\tif (lastRunTimestamp_ && frameCount_ > dropFrameCount_ &&\n+\tif (lastRunTimestamp_ && frameCount_ > startupCount_ &&\n \t delta < controllerMinFrameDuration * 0.9 && !hdrChange) {\n \t\t/*\n \t\t * Ensure we merge the previous frame's metadata with the current\ndiff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex 1a811beb31f2..a51afc156a8f 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -115,8 +115,8 @@ private:\n \t/* How many frames we should avoid running control algos on. */\n \tunsigned int mistrustCount_;\n \n-\t/* Number of frames that need to be dropped on startup. */\n-\tunsigned int dropFrameCount_;\n+\t/* Number of frames that need to be marked as dropped on startup. */\n+\tunsigned int startupCount_;\n \n \t/* Frame timestamp for the last run of the controller. */\n \tuint64_t lastRunTimestamp_;\n", "prefixes": [ "v2", "6/6" ] }