Patch Detail
Show a patch.
GET /api/1.1/patches/23419/?format=api
{ "id": 23419, "url": "https://patchwork.libcamera.org/api/1.1/patches/23419/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23419/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250522075244.1198110-5-naush@raspberrypi.com>", "date": "2025-05-22T07:48:20", "name": "[v2,4/6] pipeline: rpi: Remove disable_startup_frame_drops config option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5bfa51e86f786b03c6d9f9f0b91a2345638e31d9", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23419/mbox/", "series": [ { "id": 5188, "url": "https://patchwork.libcamera.org/api/1.1/series/5188/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5188", "date": "2025-05-22T07:48:16", "name": "Eliminating startup frames", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5188/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23419/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23419/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32D07C331D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 May 2025 07:53:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4998068D9B;\n\tThu, 22 May 2025 09:52:58 +0200 (CEST)", "from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 620EB68D95\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 May 2025 09:52:50 +0200 (CEST)", "by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-3a361c8a830so955264f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 May 2025 00:52:50 -0700 (PDT)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a3ca066eb7sm4191516f8f.2.2025.05.22.00.52.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 22 May 2025 00:52:49 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cEh9Ag+g\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1747900370; x=1748505170;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=PQbXpP6ym6kMA9r51U3/3ckVgPiXTqaSa9FB8oZ25C4=;\n\tb=cEh9Ag+gN+GBUDvW2KcIkLuMDc6NeksBz7vDpVgSStzUA8hRrpSwxxxkX7moGri2AB\n\t2iW+T6aHOP+qOOUs1uf/gqKecZJMpZ9sbTLm4Lh3uIhuq67imUE4qIAcwyWNXu20e5UW\n\tNPZrPqYCMIbwmxJ0Re/inMCWkeX4PluQXN7X6UMf7G8Oc2rQmmWL4Gm4JtEFlkJMVRe9\n\t81c6/J1FcGaS3MCXQ1wVcqbkaj6aIs/aY78BuXidNOiOaAkpMYtVAZ2PIrlPCLwIjkfG\n\trBKsTA4K9Tc8lUHz59JHD2mhiA3Yfx52HTAt9O/WUCWlFNN3TE1jNp46Ika10JJgSEIL\n\tz/Rw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1747900370; x=1748505170;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=PQbXpP6ym6kMA9r51U3/3ckVgPiXTqaSa9FB8oZ25C4=;\n\tb=dpm/u4V/xpFl5CeSd6UQe9/jHiMyVojrmAknQD8moBc5CIT8UcGEp/obpq1yHL3VGf\n\t8NV/a7snLERneZFkRl2EEZD29uvPJx68uK3c9dFzwUuHSZYQhi3Da4W2ovjTW6rRrbCF\n\tn68FQ9NVoIm9WJsJfbJm0dt6wnVBJ0yUKoGc5M0zrddKK0dGsDfxgicQ8D3soX+ieN92\n\tcZK9UWOJu1Qqo05dl4alLg8rcSZ8MipiDg+qzAn/xLWC+inG33bMPsEr0Gyk5oN9Teom\n\tROaj+jeP/dDdsqtCVYFm79gCZvZKaDdAiFxbj7S7IrPUmvzzZMxA+BofbwnOjd/vj4VS\n\t3hRw==", "X-Gm-Message-State": "AOJu0Yw5EW+ljaOwnE4L63KDIcRgQkmRLdQCrSKimcEzdF27uZIeOSAH\n\tdrn6iulfBtFF3szfQqnyAJw+/ko0YVFh+/L/hGwmPNeEVhRlh2hOt7HYMAyLcn+bjNA9LTfhmQj\n\tnyCqL", "X-Gm-Gg": "ASbGnctP9dkhVtJxPX2faJnd9ds70u1kYVWGC8E5d5762Cc5dhyUu9A+OS9/YUKlM3d\n\tWlWHDdSZHTuSgl2eT8AX6BLfWFVjxkJE8mIYaiIuDxNS8cI31JOGPcRonMSDTdcOnktHC+W8vDY\n\t226MhCJZ3RaG7h2prUCpS0XnqxxRIOJIITcbWKDHuLLM45i8So6L9Hsbts4oTAiPfc/aIG4B1XZ\n\tVa1yw+oaqfhr542uM76fFm7zyI/SVTMBQ5bFEGFpB9upm3fAKRMefD0oSX3Vf7GNBX1QXxvIIOc\n\t9lKd0/rPwCQwVZ4uK8Iv5jEiGF/hRxOjbynT3lOaKZWfIeDX5cdiywhyUj4QWWEgtjmLXOQ=", "X-Google-Smtp-Source": "AGHT+IEgzSjIQ4mF2VDv5rkzgsdusSIdr381GPwG6V3jXa8OuBlLObH+1Wq4Azq9gdcP+Lng3OhJmA==", "X-Received": "by 2002:a05:6000:1884:b0:3a3:73dd:92b4 with SMTP id\n\tffacd0b85a97d-3a373dd9431mr4591291f8f.4.1747900369639; \n\tThu, 22 May 2025 00:52:49 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>", "Subject": "[PATCH v2 4/6] pipeline: rpi: Remove disable_startup_frame_drops\n\tconfig option", "Date": "Thu, 22 May 2025 08:48:20 +0100", "Message-ID": "<20250522075244.1198110-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250522075244.1198110-1-naush@raspberrypi.com>", "References": "<20250522075244.1198110-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the previous change to not drop frames in the pipeline handler,\nthe \"disable_startup_frame_drops\" pipeline config option is not used.\nRemove it, and throw a warning if the option is present in the YAML\nconfig file.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 7 ++++---\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 5 -----\n src/libcamera/pipeline/rpi/pisp/data/example.yaml | 5 -----\n src/libcamera/pipeline/rpi/vc4/data/example.yaml | 5 -----\n 4 files changed, 4 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 3f0b7abdc59a..bef057a70353 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1078,7 +1078,6 @@ void CameraData::enumerateVideoDevices(MediaLink *link, const std::string &front\n int CameraData::loadPipelineConfiguration()\n {\n \tconfig_ = {\n-\t\t.disableStartupFrameDrops = false,\n \t\t.cameraTimeoutValue = 0,\n \t};\n \n@@ -1115,8 +1114,10 @@ int CameraData::loadPipelineConfiguration()\n \n \tconst YamlObject &phConfig = (*root)[\"pipeline_handler\"];\n \n-\tconfig_.disableStartupFrameDrops =\n-\t\tphConfig[\"disable_startup_frame_drops\"].get<bool>(config_.disableStartupFrameDrops);\n+\tif (phConfig.contains(\"disable_startup_frame_drops\"))\n+\t\tLOG(RPI, Warning)\n+\t\t\t<< \"The disable_startup_frame_drops key is now deprecated, \"\n+\t\t\t<< \"please use FrameMetadata::Status::FrameStartup instead.\";\n \n \tconfig_.cameraTimeoutValue =\n \t\tphConfig[\"camera_timeout_value_ms\"].get<unsigned int>(config_.cameraTimeoutValue);\ndiff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\nindex 6023f9f9d6b3..e27c4f860d1a 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n@@ -164,11 +164,6 @@ public:\n \tbool buffersAllocated_;\n \n \tstruct Config {\n-\t\t/*\n-\t\t * Override any request from the IPA to drop a number of startup\n-\t\t * frames.\n-\t\t */\n-\t\tbool disableStartupFrameDrops;\n \t\t/*\n \t\t * Override the camera timeout value calculated by the IPA based\n \t\t * on frame durations.\ndiff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\nindex d67e654a8b9e..baf03be79bb3 100644\n--- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n+++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n@@ -16,11 +16,6 @@\n #\n # \"num_cfe_config_queue\": 2,\n \n- # Override any request from the IPA to drop a number of startup\n- # frames.\n- #\n- # \"disable_startup_frame_drops\": false,\n-\n # Custom timeout value (in ms) for camera to use. This overrides\n # the value computed by the pipeline handler based on frame\n # durations.\ndiff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\nindex b8e01adeaf40..27e543488d48 100644\n--- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n+++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n@@ -29,11 +29,6 @@\n #\n # \"min_total_unicam_buffers\": 4,\n \n- # Override any request from the IPA to drop a number of startup\n- # frames.\n- #\n- # \"disable_startup_frame_drops\": false,\n-\n # Custom timeout value (in ms) for camera to use. This overrides\n # the value computed by the pipeline handler based on frame\n # durations.\n", "prefixes": [ "v2", "4/6" ] }