Patch Detail
Show a patch.
GET /api/1.1/patches/23408/?format=api
{ "id": 23408, "url": "https://patchwork.libcamera.org/api/1.1/patches/23408/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23408/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250521102208.989701-3-naush@raspberrypi.com>", "date": "2025-05-21T10:19:52", "name": "[v1,2/2] libcameara: sensor: Fix the gain delay for IMX283", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5bb182281e4c10fedb5736d92c5ad7e02f9b034f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23408/mbox/", "series": [ { "id": 5185, "url": "https://patchwork.libcamera.org/api/1.1/series/5185/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5185", "date": "2025-05-21T10:19:50", "name": "RPi: Add IMX283 tunings", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5185/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23408/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23408/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECAF9BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 May 2025 10:22:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B6AF68D7E;\n\tWed, 21 May 2025 12:22:15 +0200 (CEST)", "from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E36E68C91\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 May 2025 12:22:12 +0200 (CEST)", "by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-442ea0f72f4so3447195e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 May 2025 03:22:12 -0700 (PDT)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-447f6f062fcsm62216535e9.15.2025.05.21.03.22.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 May 2025 03:22:11 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"P0nJsyYI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1747822932; x=1748427732;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ll0ss0qf5FTU+9HFVeKlBOW0z6NjroszVZnjlX4zETQ=;\n\tb=P0nJsyYIDL0m4YSJz5Ffn8Zu/Yj4adTvXvz/+jATAeAL9GNaQqtG8YgOTYOK9RdX77\n\tn/TkNWlUGnUL4pooMSjisRSXCHWbT0WuVGoTgrpzptsXKjClVFPp6AFWbvSKBnUkwikx\n\tZMYo9H6ZOToyv4RObWa2yfbxtEGshWGYJYm0RMj/4NMhGEGpVuuws1Rd4DWstvdhRuZY\n\tI6VOvK4iB6XBAuOPv1tCAKwDGJgfMnLfPKpFs+coxefmYsQSnDr1ciIkB+Yq0Nm1vO5u\n\tM1mOblhrClHMrLV1eYQfeKyRgYqv8TjnaGhcu7UKw83TvlxqF3Ywp4vBxOZqtSqhrFgI\n\tenjw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1747822932; x=1748427732;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=ll0ss0qf5FTU+9HFVeKlBOW0z6NjroszVZnjlX4zETQ=;\n\tb=dYaXb2SIt5bMTLW2PmBHVsT67BG5y1kf96H76cHNr9TQYD3qZX1P5W9Saoz+4AudCJ\n\td9cGB0U8REa8IOMlJcUw+33MMcyEftePBjBGN7Kw8Ie4/fWemJBq46bugJdci5LFIucI\n\tHXiO7NYB54BIhlJE1SoPAXbq87CVXi76RBLs6ZVSIiD3NwGaaD9TNVXyQkiqXOfFjepe\n\tX3CPhbR+SMdpDVtOLtW8CiUAzlude0VVqOSY2azLqxFvGJMe3BMiZU7cg50T2DwTvdEb\n\tMJgp3s/iFsJLPAh1Vz8mvYYeMRZEWNUu14FtG/HUDF7Zb2A9aJviX+5uM4Ye5yXYSvmv\n\tCvyw==", "X-Gm-Message-State": "AOJu0YxMkxDuFgF0y8L/NnyEL+YaL0Z+8KS0rC6hv1qqcg9wtFOgvdwI\n\tneJi5GtVczVD3u0y4cGC65h8w1krBGvrOBvbPbsH2Y6oE5duY/LBOoBA8hLsqAq4tTSZVVHba48\n\tVKLlQ", "X-Gm-Gg": "ASbGncuve4M2lnceItIdyvh/imQ1Y2KMCN9gMIxVePwYeCh7mJs6QQXSv3BnYfAIOHk\n\tcAGe35AoyQ0p70f2y/fAJl4J5yXomvr2pnGlIqaEXkAssvTaMPUZN87ksZffh0/TYHL3vbAPQW2\n\tHexxT6c/pVxJwkmvOM56pY0CNy3phozH1tJuBZVnwLHE2EGL2vnKdFGUdd+5ZSQ8KMgGKibdKDi\n\tX5Qdt1kqHFslPqMfIPQQZ4jqlNBE4/s6y4+yr4egScdPc3ZqszPZl/WWXzGi3IqGmq/c2hZdTNt\n\t4+4FfF4B1oThIhALHhDGAdggGrvf9x5at+6zvlelnvelHNsPHrlgZYTODMzxectoRBOg5QI=", "X-Google-Smtp-Source": "AGHT+IGBC+U60umiNVD76YbmxNcdRB/JjtFbyG2BCzdc+bkMi+D6Kcb1+yCWRU/c2bdYC/y1uGqSWQ==", "X-Received": "by 2002:a05:600c:3b95:b0:43d:2318:ed7f with SMTP id\n\t5b1f17b1804b1-442fd5a2cb4mr67908685e9.0.1747822931782; \n\tWed, 21 May 2025 03:22:11 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v1 2/2] libcameara: sensor: Fix the gain delay for IMX283", "Date": "Wed, 21 May 2025 11:19:52 +0100", "Message-ID": "<20250521102208.989701-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250521102208.989701-1-naush@raspberrypi.com>", "References": "<20250521102208.989701-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IMX283 uses a gain delay of 1 instead of the current value of 2 as\ndefined in the sensor properties. Fix it.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/sensor/camera_sensor_properties.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex e2f518f9ea62..c9e9e148a1f0 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -194,7 +194,7 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t.testPatternModes = {},\n \t\t\t.sensorDelays = {\n \t\t\t\t.exposureDelay = 2,\n-\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.gainDelay = 1,\n \t\t\t\t.vblankDelay = 2,\n \t\t\t\t.hblankDelay = 2\n \t\t\t},\n", "prefixes": [ "v1", "2/2" ] }