Patch Detail
Show a patch.
GET /api/1.1/patches/23342/?format=api
{ "id": 23342, "url": "https://patchwork.libcamera.org/api/1.1/patches/23342/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23342/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250507082753.2306743-2-naush@raspberrypi.com>", "date": "2025-05-07T07:52:08", "name": "[RFC,1/6] libcamera: framebuffer: Add FrameMetadata::Status::FrameStartup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fa7ed4e8d57155df2e9cda3e9a5beb105c9c1aa2", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23342/mbox/", "series": [ { "id": 5164, "url": "https://patchwork.libcamera.org/api/1.1/series/5164/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5164", "date": "2025-05-07T07:52:07", "name": "Eliminating startup frames", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5164/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23342/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23342/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A54A5C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 May 2025 08:28:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B1FB68B2C;\n\tWed, 7 May 2025 10:28:01 +0200 (CEST)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9D7C68AD3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 May 2025 10:27:57 +0200 (CEST)", "by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-43cf825f46bso5806365e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 May 2025 01:27:57 -0700 (PDT)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-441d440fff6sm22182575e9.25.2025.05.07.01.27.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 May 2025 01:27:56 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"gisJUzeO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1746606477; x=1747211277;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Zd5df1quEaR166Fq4cu5Y3EUJiRzpvBQBh9y5xYqZPs=;\n\tb=gisJUzeOnjFP/YsqXgkkGQd8hRAgIwhsVaO66VyZf5FA6M/I9hqhJE05QuaENvIPXT\n\tLxgRlwjwlgn0d6pSiBp5Zkh0KCWXyUt8swjOkYBCRXcCNRNHMN7c3PPwJ89UiK6cvM7H\n\tK6Y0HN6SGHzLdyc/hiujSEMPRtmdH+R2RikcWUnk4mqaoYSove3qjOz5yn6YVDlEN9IL\n\tgnOm1y+NLyWcvpUjFJxOYMtZrq2BOay434vYtC6BTBCkbeeEraxTupLQQbJWbXzfD8sM\n\tRI0wmP5sb9+ntQn95LJ8mDUsqD/+BFEVCJwbbAuASM9YcdeM2mdbQ/5hjHitiPR4yF3L\n\tvHVA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1746606477; x=1747211277;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Zd5df1quEaR166Fq4cu5Y3EUJiRzpvBQBh9y5xYqZPs=;\n\tb=AR9rJcNDYvTG/dW5DgTcU3nR0k2eU1z/oM14K3OSWsjGCD4WPEg4vKdSG+VYc+IPXS\n\tCUMkq5m2EKzwmzBpQ0S+d7DbAP6OeI+P9WHIZHCjxRLsklQt0arjrPeeLP04zJ/huNj6\n\tjiUgpC1enCYyVs8Z/QVbh7SdoDT4pgNuXMQwc2A9cdO4TjzjD3jYimMVwWCA8RXiZ3r1\n\tn+s4bCwJ9ZQJvWn0cav+Xujg4Y8jCfdXuU3df86bRr8EBm0r3cjdQHevzXqI8pwReNum\n\tNcIHXbqLz5491HZf3h90XfohBuFGq9gdN+Boo75kO6QQmqbccY7M7MuwfXBVokvbYom3\n\tqGLw==", "X-Gm-Message-State": "AOJu0YzDt09SvfdXuO46p0RMyKHs8kc2SE+Q2LLGmN8Rit7W3FWrqlWI\n\tnqySWPVxzaZOnbJM/1zpn9057SSXvTf4LhyNTd2DN3RUExD2ji0niv558W12P+Xrpa9v7nBaEs+\n\tI", "X-Gm-Gg": "ASbGncsRGHBWnBJ0Z0zwd//A5k6Tq+/PPnQhbv5Yg5k07wtxGGi4Wwt19sh0mD0VBVM\n\t3pcrl98gbXkB/uhEuoKKHNLVwFXIlTt0lAWH3/cjJ1ylGInB9Z73E2Vj0JoOc4T4jnOKnGgwsc4\n\t8XswWxQwMpChwKW8HVJtc/S7ZgZVCP0pWpV0mIzETapw8YVt9UXvhFcqzz2gPpwOw1WmNFnCf4g\n\tdVDFog52QsOYfPuDLylFnFpozahODN0evNVsNFRpIS+GMRiwo1P0FqwDAlDm96Z0Dm+4kbLl83e\n\tfO3a5htW31qR/ZF81sqdwX0RpHCA4Fjo04I7ktUyYByBE9fEd9JyZNJqxOeBmaTdc7uuBTM=", "X-Google-Smtp-Source": "AGHT+IGu+sIxewoMnakQwFrd+WtpFgPW8oYU700bgvVtqjA/1ds+luR965SVMGpBuRSl7mKdcytpiA==", "X-Received": "by 2002:a05:600c:3554:b0:441:c5ee:cdb4 with SMTP id\n\t5b1f17b1804b1-441d44dd442mr6653345e9.4.1746606477201; \n\tWed, 07 May 2025 01:27:57 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[RFC PATCH 1/6] libcamera: framebuffer: Add\n\tFrameMetadata::Status::FrameStartup", "Date": "Wed, 7 May 2025 08:52:08 +0100", "Message-ID": "<20250507082753.2306743-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250507082753.2306743-1-naush@raspberrypi.com>", "References": "<20250507082753.2306743-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a new status enum, FrameStartup, used to denote that even though\nthe frame has been successfully captured, the IQ parameters set by the\nIPA will cause the frame to be unusable and applications are advised to\nnot consume this frame. An example of this would be on a cold-start of\nthe 3A algorithms, and there will be large oscillations to converge to\na stable state quickly.\n\nAdditional, update the definition of the FrameError state to include its\nusage when the sensor is known to produce a number of invalid/error\nframes after stream-on.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n include/libcamera/framebuffer.h | 1 +\n src/libcamera/framebuffer.cpp | 11 +++++++++--\n 2 files changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex ff83924300ac..e83825b466aa 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -26,6 +26,7 @@ struct FrameMetadata {\n \t\tFrameSuccess,\n \t\tFrameError,\n \t\tFrameCancelled,\n+\t\tFrameStartup,\n \t};\n \n \tstruct Plane {\ndiff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\nindex 826848f75a56..36e56d593bc3 100644\n--- a/src/libcamera/framebuffer.cpp\n+++ b/src/libcamera/framebuffer.cpp\n@@ -44,11 +44,18 @@ LOG_DEFINE_CATEGORY(Buffer)\n * of the FrameMetadata structure are valid.\n * \\var FrameMetadata::FrameError\n * An error occurred during capture of the frame. The frame data may be partly\n- * or fully invalid. The sequence and timestamp fields of the FrameMetadata\n- * structure is valid, the other fields may be invalid.\n+ * or fully invalid. This status may also indicate an invalid frame produced by\n+ * the sensor during its startup or restart phase. The sequence and timestamp\n+ * fields of the FrameMetadata structure is valid, the other fields may be\n+ * invalid.\n * \\var FrameMetadata::FrameCancelled\n * Capture stopped before the frame completed. The frame data is not valid. All\n * fields of the FrameMetadata structure but the status field are invalid.\n+ * \\var FrameMetadata::FrameStartup The frame has been successfully captured.\n+ * However, the IPA is in a cold-start or reset phase and will result in image\n+ * quality parameters producing unusable images. Applications are recommended to\n+ * not consume these frames. All fields of the FrameMetadata structure are\n+ * valid.\n */\n \n /**\n", "prefixes": [ "RFC", "1/6" ] }