Patch Detail
Show a patch.
GET /api/1.1/patches/2333/?format=api
{ "id": 2333, "url": "https://patchwork.libcamera.org/api/1.1/patches/2333/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2333/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191120015506.362440-3-niklas.soderlund@ragnatech.se>", "date": "2019-11-20T01:54:58", "name": "[libcamera-devel,v2,02/10] libcamera: buffer: Plane: Drop friend statement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5f536fc4333ecfa1dc62005f5d442556e5b88987", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2333/mbox/", "series": [ { "id": 572, "url": "https://patchwork.libcamera.org/api/1.1/series/572/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=572", "date": "2019-11-20T01:54:56", "name": "libcamera: Fixes found while working on new", "version": 2, "mbox": "https://patchwork.libcamera.org/series/572/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2333/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2333/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B2F7617A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Nov 2019 02:55:29 +0100 (CET)", "from bismarck.berto.se (p54ac5865.dip0.t-ipconnect.de\n\t[84.172.88.101]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid d3534330-0b38-11ea-a00b-005056917a89;\n\tWed, 20 Nov 2019 02:55:28 +0100 (CET)" ], "X-Halon-ID": "d3534330-0b38-11ea-a00b-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 20 Nov 2019 02:54:58 +0100", "Message-Id": "<20191120015506.362440-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.24.0", "In-Reply-To": "<20191120015506.362440-1-niklas.soderlund@ragnatech.se>", "References": "<20191120015506.362440-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 02/10] libcamera: buffer: Plane: Drop\n\tfriend statement", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 20 Nov 2019 01:55:29 -0000" }, "content": "The Plane class do not need to friend Stream, drop it.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/buffer.h | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex e14c9bd390a13bfc..d7784d9d24ab3f41 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -29,8 +29,6 @@ public:\n \tunsigned int length() const { return length_; }\n \n private:\n-\tfriend class Stream;\n-\n \tint mmap();\n \tint munmap();\n \n", "prefixes": [ "libcamera-devel", "v2", "02/10" ] }