Patch Detail
Show a patch.
GET /api/1.1/patches/23297/?format=api
{ "id": 23297, "url": "https://patchwork.libcamera.org/api/1.1/patches/23297/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23297/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250429115934.3551701-1-stefan.klug@ideasonboard.com>", "date": "2025-04-29T11:59:19", "name": "ipa: rkisp1: awb: Ignore empty AWB statistics", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "acfb9d593d41710077565fe6c0e7f229ff168145", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23297/mbox/", "series": [ { "id": 5151, "url": "https://patchwork.libcamera.org/api/1.1/series/5151/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5151", "date": "2025-04-29T11:59:19", "name": "ipa: rkisp1: awb: Ignore empty AWB statistics", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5151/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23297/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23297/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": [ "parsemail@patchwork.libcamera.org", "kbingham@ideasonboard.com" ], "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81CB8C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Apr 2025 13:02:27 +0000 (UTC)", "from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DCFBAF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Apr 2025 15:02:21 +0200 (CEST)", "from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id SLd2Gyq/EGieDjgA4E0KoQ\n\t(envelope-from <libcamera-devel-bounces@lists.libcamera.org>)\n\tfor <kbingham@ideasonboard.com>; Tue, 29 Apr 2025 13:59:38 +0200", "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\tby perceval.ideasonboard.com (Postfix) with ESMTPS\n\tid 0EC16669;\tTue, 29 Apr 2025 13:59:38 +0200 (CEST)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BD3768AD5;\n\tTue, 29 Apr 2025 13:59:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8377A617DB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Apr 2025 13:59:40 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:79bc:8373:e04e:9a51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B720C669;\n\tTue, 29 Apr 2025 13:59:34 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745931741;\n\tbh=/8eFKApEsVCqI8plrPF3+y+xLShljT4rtHenq+3/rYY=;\n\th=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive:\n\tList-Post:List-Help:List-Subscribe:Resent-From:Resent-To:From;\n\tb=nUYKKKHv0gYr73ax1DPCdIChCkyS1TCK3b/2nQSAB83JDnAejAAVdonvD3CSdSJly\n\tBUBmSyCIH4Lmbvja+Lyz8VDXmgETd0qiDszMrxQ1Afj2zFXNQ1ymfhQttzWgdHAWYf\n\tM8QkCb1V2dUUdO3EfawMI/eH5BtllCQDJdSDAXjA=", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745927974;\n\tbh=/8eFKApEsVCqI8plrPF3+y+xLShljT4rtHenq+3/rYY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=GBlwtaRnKRjnzj32hrFZg1mQZFfytFmygB3fV+YQ20wSTNCLKeL79GEM0xilfYPeA\n\tigo/uDhq+Re/gq5GFWjA1bBRVvHqxSLOkDF+yu9PEOaZWgN4rlLuKvFqRIKc5DjEG1\n\tvvWboHxiO3nuB/MNYEx1A0P9UllUvARrNxrpoDFU=" ], "Authentication-Results": [ "perceval.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.a=rsa-sha256 header.s=mail header.b=GBlwtaRn; dkim-atps=neutral", "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GBlwtaRn\";\tdkim-atps=neutral" ], "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH] ipa: rkisp1: awb: Ignore empty AWB statistics", "Date": "Tue, 29 Apr 2025 13:59:19 +0200", "Message-ID": "<20250429115934.3551701-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>", "X-TUID": "+vUbSA6pLHJ2", "Resent-From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Resent-To": "parsemail@patchwork.libcamera.org" }, "content": "When the AWB engine doesn't find a valid pixel because all pixels lie\noutside the configured colour range it returns an AWB measurement value\nof 255, 255, 255. This leaves the regulation in an unrecoverable state\nnoticeable by a completely green image. Fix that by skipping the AWB\ncalculation in case there were no valid pixels.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>.\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex eafe93081bb1..2b8b41ecccbe 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -296,6 +296,11 @@ void Awb::process(IPAContext &context,\n \tconst rkisp1_cif_isp_stat *params = &stats->params;\n \tconst rkisp1_cif_isp_awb_stat *awb = ¶ms->awb;\n \n+\tif (awb->awb_mean[0].cnt == 0) {\n+\t\tLOG(RkISP1Awb, Warning) << \"AWB statistics are empty\";\n+\t\treturn;\n+\t}\n+\n \tRGB<double> rgbMeans = calculateRgbMeans(frameContext, awb);\n \n \t/*\n", "prefixes": [] }