Patch Detail
Show a patch.
GET /api/1.1/patches/2329/?format=api
{ "id": 2329, "url": "https://patchwork.libcamera.org/api/1.1/patches/2329/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2329/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191119164421.68983-6-jacopo@jmondi.org>", "date": "2019-11-19T16:44:20", "name": "[libcamera-devel,RFC,5/6] libcamera: v4l2_controls: Store default value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "78a95b89f82aab1f114b21209509e72b461b2f45", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/2329/mbox/", "series": [ { "id": 571, "url": "https://patchwork.libcamera.org/api/1.1/series/571/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=571", "date": "2019-11-19T16:44:15", "name": "Collect Camera properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/571/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2329/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2329/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94494617A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Nov 2019 17:42:28 +0100 (CET)", "from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 23CED20005;\n\tTue, 19 Nov 2019 16:42:27 +0000 (UTC)" ], "X-Originating-IP": "93.34.114.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 19 Nov 2019 17:44:20 +0100", "Message-Id": "<20191119164421.68983-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191119164421.68983-1-jacopo@jmondi.org>", "References": "<20191119164421.68983-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 5/6] libcamera: v4l2_controls: Store default\n\tvalue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 19 Nov 2019 16:42:29 -0000" }, "content": "Store the default value for V4L2 controls as reported by the kernel when\ncreating ControlRange instances using information coming from\nv4l2_query_ext_ctrl.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/v4l2_controls.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\nindex b6547a7c627c..0073d4fa4ca1 100644\n--- a/src/libcamera/v4l2_controls.cpp\n+++ b/src/libcamera/v4l2_controls.cpp\n@@ -122,16 +122,19 @@ V4L2ControlRange::V4L2ControlRange(const struct v4l2_query_ext_ctrl &ctrl)\n \tcase V4L2_CTRL_TYPE_BOOLEAN:\n \t\tControlRange::operator=(ControlRange(static_cast<bool>(ctrl.minimum),\n \t\t\t\t\t\t static_cast<bool>(ctrl.maximum)));\n+\t\tdefaultValue_.set(static_cast<bool>(ctrl.default_value));\n \t\tbreak;\n \n \tcase V4L2_CTRL_TYPE_INTEGER64:\n \t\tControlRange::operator=(ControlRange(static_cast<int64_t>(ctrl.minimum),\n \t\t\t\t\t\t static_cast<int64_t>(ctrl.maximum)));\n+\t\tdefaultValue_.set(static_cast<int64_t>(ctrl.default_value));\n \t\tbreak;\n \n \tdefault:\n \t\tControlRange::operator=(ControlRange(static_cast<int32_t>(ctrl.minimum),\n \t\t\t\t\t\t static_cast<int32_t>(ctrl.maximum)));\n+\t\tdefaultValue_.set(static_cast<int32_t>(ctrl.default_value));\n \t\tbreak;\n \t}\n }\n", "prefixes": [ "libcamera-devel", "RFC", "5/6" ] }