Patch Detail
Show a patch.
GET /api/1.1/patches/23253/?format=api
{ "id": 23253, "url": "https://patchwork.libcamera.org/api/1.1/patches/23253/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23253/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250424114103.451395-2-barnabas.pocze@ideasonboard.com>", "date": "2025-04-24T11:40:55", "name": "[RFC,v5,1/9] libcamera: process: Disable copy/move", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1889ee2939b66ca847911da55f315eda8bc39baa", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23253/mbox/", "series": [ { "id": 5145, "url": "https://patchwork.libcamera.org/api/1.1/series/5145/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5145", "date": "2025-04-24T11:40:54", "name": "libcamera: process: Remove `ProcessManager` singleton", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5145/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23253/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23253/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAAFAC327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Apr 2025 11:41:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90CA968AD9;\n\tThu, 24 Apr 2025 13:41:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DCF168ACD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Apr 2025 13:41:07 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CD601230;\n\tThu, 24 Apr 2025 13:41:05 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JXEipIl4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745494865;\n\tbh=/i8v1siOOqDzDe2JqXG0KEGLYIr+ubhZNLVjfELyg30=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JXEipIl4FKSnlzpfaMp3dVJa5FOnZK3zCPB8vmKwxerNn7tRYExKm0uEQUDBmdt+4\n\t7Q8B0W7QXenutq8oE7ybmNHXEdW/P6uCd/hAEYwFXTY+gs5idSpAhTQ6tOKGAp4ak/\n\tZeULYtRFH61Vmc8MTMf4kNH/odfoKzOnjo4naxwk=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[RFC PATCH v5 1/9] libcamera: process: Disable copy/move", "Date": "Thu, 24 Apr 2025 13:40:55 +0200", "Message-ID": "<20250424114103.451395-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>", "References": "<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A `Process` object has address identity because a pointer to it is\nstored inside the `ProcessManager`. However, copy/move special\nmethods are still generated by the compiler. So disable them to\navoid potential issues and confusion.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/process.h | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\nindex b1d07a5a5..6c34aef2f 100644\n--- a/include/libcamera/internal/process.h\n+++ b/include/libcamera/internal/process.h\n@@ -11,6 +11,7 @@\n #include <string>\n #include <vector>\n \n+#include <libcamera/base/class.h>\n #include <libcamera/base/signal.h>\n #include <libcamera/base/unique_fd.h>\n \n@@ -42,6 +43,8 @@ public:\n \tSignal<enum ExitStatus, int> finished;\n \n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(Process)\n+\n \tvoid closeAllFdsExcept(const std::vector<int> &fds);\n \tint isolate();\n \tvoid died(int wstatus);\n", "prefixes": [ "RFC", "v5", "1/9" ] }