Patch Detail
Show a patch.
GET /api/1.1/patches/23245/?format=api
{ "id": 23245, "url": "https://patchwork.libcamera.org/api/1.1/patches/23245/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23245/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250424112203.445351-4-barnabas.pocze@ideasonboard.com>", "date": "2025-04-24T11:21:56", "name": "[RFC,v4,3/9] libcamera: process: Use `pid_` member to decide if running", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "167d4ea854b70f5d54bbe725f9c3d8b916ea5499", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23245/mbox/", "series": [ { "id": 5144, "url": "https://patchwork.libcamera.org/api/1.1/series/5144/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5144", "date": "2025-04-24T11:21:53", "name": "libcamera: process: Remove `ProcessManager` singleton", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5144/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23245/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23245/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8A4DC331E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Apr 2025 11:22:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0425368ADC;\n\tThu, 24 Apr 2025 13:22:14 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98B6168AC5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Apr 2025 13:22:07 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8480F1230;\n\tThu, 24 Apr 2025 13:22:05 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MyJ9SB/k\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745493725;\n\tbh=fGC17eG1S/Jqp91DikygXMfnrbPJeAFxslQBqhJeatE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MyJ9SB/ksKBWltDXpDa5GO/SaKqvqtwFPGYG35q3Grw2vZvI1zCa0X6Oo6XHBPTO4\n\tPl3M7OQxv40Quqzv9UWm5gd3+ldcS2pQYwoGsFQdCwhMmPPtS/S1JBfxkUSyaP9TA+\n\txRXWwVInkFPa49rH9TjraFY0Rw3UxN9sDoxwjQ+o=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[RFC PATCH v4 3/9] libcamera: process: Use `pid_` member to decide\n\tif running", "Date": "Thu, 24 Apr 2025 13:21:56 +0200", "Message-ID": "<20250424112203.445351-4-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250424112203.445351-1-barnabas.pocze@ideasonboard.com>", "References": "<20250424112203.445351-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of using a separate member variable, use `pid_ > 0` to determine\nif the process is still running. Previously the value of `pid_` was not\nreset to -1 when the process terminated, but since it is only meaningful\nwhile the process is running, reset it to -1 in `Process::died()`.\n\nNeither `pid_` nor `running_` are exposed, so this change has no effect\non the public interface or observable behaviour.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/process.h | 1 -\n src/libcamera/process.cpp | 8 +++-----\n 2 files changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\nindex 6c34aef2f..891e78947 100644\n--- a/include/libcamera/internal/process.h\n+++ b/include/libcamera/internal/process.h\n@@ -50,7 +50,6 @@ private:\n \tvoid died(int wstatus);\n \n \tpid_t pid_;\n-\tbool running_;\n \tenum ExitStatus exitStatus_;\n \tint exitCode_;\n \ndiff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 0990b4bdd..c22c9af5d 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -208,7 +208,7 @@ const struct sigaction &ProcessManager::oldsa() const\n */\n \n Process::Process()\n-\t: pid_(-1), running_(false), exitStatus_(NotExited), exitCode_(0)\n+\t: pid_(-1), exitStatus_(NotExited), exitCode_(0)\n {\n }\n \n@@ -240,7 +240,7 @@ int Process::start(const std::string &path,\n {\n \tint ret;\n \n-\tif (running_)\n+\tif (pid_ > 0)\n \t\treturn 0;\n \n \tint childPid = fork();\n@@ -252,8 +252,6 @@ int Process::start(const std::string &path,\n \t\tpid_ = childPid;\n \t\tProcessManager::instance()->registerProcess(this);\n \n-\t\trunning_ = true;\n-\n \t\treturn 0;\n \t} else {\n \t\tif (isolate())\n@@ -327,7 +325,7 @@ int Process::isolate()\n */\n void Process::died(int wstatus)\n {\n-\trunning_ = false;\n+\tpid_ = -1;\n \texitStatus_ = WIFEXITED(wstatus) ? NormalExit : SignalExit;\n \texitCode_ = exitStatus_ == NormalExit ? WEXITSTATUS(wstatus) : -1;\n \n", "prefixes": [ "RFC", "v4", "3/9" ] }