Patch Detail
Show a patch.
GET /api/1.1/patches/23236/?format=api
{ "id": 23236, "url": "https://patchwork.libcamera.org/api/1.1/patches/23236/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23236/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250422215920.4297-24-bryan.odonoghue@linaro.org>", "date": "2025-04-22T21:59:16", "name": "[23/27] libcamera: shaders: Use highp not mediump for float precision", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "6439446f42d55daa7cb56a7cfadfc73db1847b48", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23236/mbox/", "series": [ { "id": 5142, "url": "https://patchwork.libcamera.org/api/1.1/series/5142/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5142", "date": "2025-04-22T21:58:53", "name": "RFC: Add in a eGL based GPUISP in libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5142/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23236/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23236/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC075C32A2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 22:00:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D525868B36;\n\tWed, 23 Apr 2025 00:00:06 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C779268B40\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 23:59:45 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-43cf257158fso37902725e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:59:45 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 14:59:44 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"NvOLafmz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1745359185; x=1745963985;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=aHV/OzBettE9JMBz8rxXsO0JyXp6g3150ZsuVLe9cQ0=;\n\tb=NvOLafmzSzR7jvTcURNl+cWoaOLGe/dIQkj+lZctBmB5t+Pw8gSEv/WN9jSe0jmnJJ\n\t43ZGYDJacBAoU0Xv3LXWA/qXYV0ysgFvvQtnHB33Hg6q4zTtKx34Ej01Len0aiAmUrE6\n\tgnD3zrp95IwwUtrdb57f3bx0vM62wocix8KW2aISU/cbGmnFT+bwaftyY4LsJ+ZPlhU/\n\t1lEDBVuGk8idBemgG76psjnpRM1quZKZ+yU6tOA8vQqM0tH/cf55pT9bOs3mXxppkdvb\n\tpIzkrEXX/zvi1KCGwHIPN8hR+LUFax+9tSG9VgeX/YCZwWKrskvSYpm0YsziuzEUdBgV\n\tEfpA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745359185; x=1745963985;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=aHV/OzBettE9JMBz8rxXsO0JyXp6g3150ZsuVLe9cQ0=;\n\tb=jjVm0RlA7fypuTIDGxIfE478UMiiJijpze3uHfB3wZWKTAHQOL7+SQopTloZL4Nq4J\n\t+6oE5KY83zaliKeL1JTQbTBzf5xo94U73V7s/SnLMgebBT5saz2jcL0oiAHI020hz2AG\n\tTQ3K8MTIi8AAfHydwFghPIJK4WPZ2XjUTooxSKq1vHbFIOHr5EDvABhJ67g33b+nmpD7\n\tyW6O02kNzza6lQ5HE+/RM1ZV3eNG/MiN3DKu3HwZ9Zyh+rIMyrVznxdIGVSu3nuvMu8g\n\te+yzHNV1OcwOKTFQ3flRftNcqUEx18012LRC+/PAHXQeINyAhUV7jWUCOxo9DJgO50ON\n\tAOkA==", "X-Gm-Message-State": "AOJu0YwoHErErEdgnbJ4IHD9VAlOSVIe/FC4UZPFA4B1b0epsm2Ori0g\n\tAOJuU0nLyNxAa/500ZX8Ca5uGNEwPCKCJk6Nz0SgoFYQdMFoXCsOtcUE2be4aZ4slpUlfeqdeYD\n\t6/QI=", "X-Gm-Gg": "ASbGncswv0C1iB3Eynkm92HAcnp2XfDVAq1mKtkj6oHYpPTTvV+YcOvjwiS48rZW3U6\n\tRo8o2nmVPRJ/+Ydlrx1+Iqdkr6oya8Mzcxzt38Hskaysc9DKyVGTxJ1LGd9Ce3SKGvTWWGbv94G\n\tXOzI5VHL86LXdYnalz35A96J4MzFj97vy9u8vJPRamzEAWoLRA6iq+hdjjqdg8kRA2vLsh9SWUd\n\tGNcGVtwTaMPM2kX1IaCA4ixAcST1RwJ38tJ8b5QQ/G5iuMOz6nnIMicUsCI8lpqTOpYAx7eit3H\n\t9unQwvIMT7m9J9t7H8P7prSYi6piZyVwNEccDgJ7rTYavPgGRpTEeYmri+fdCtNy3+fEaDw7mWz\n\txBYWhz4n9OeoELJc9wC8kukqd5bkf5gs=", "X-Google-Smtp-Source": "AGHT+IGoNtvjoDWPqZBIAPAQUPdPrlP+qS7fUcII/7qdawBqNzL9XJABbhc6SBUpmFTbrITLwCmQCw==", "X-Received": "by 2002:a05:600c:1d0d:b0:43c:fae1:5151 with SMTP id\n\t5b1f17b1804b1-4406abf90f4mr114923525e9.25.1745359185199; \n\tTue, 22 Apr 2025 14:59:45 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH 23/27] libcamera: shaders: Use highp not mediump for float\n\tprecision", "Date": "Tue, 22 Apr 2025 22:59:16 +0100", "Message-ID": "<20250422215920.4297-24-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250422215920.4297-1-bryan.odonoghue@linaro.org>", "References": "<20250422215920.4297-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We get better sample resolution with highp instead of mediump.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/apps/qcam/assets/shader/RGB.frag | 2 +-\n src/apps/qcam/assets/shader/YUV_2_planes.frag | 2 +-\n src/apps/qcam/assets/shader/YUV_3_planes.frag | 2 +-\n src/apps/qcam/assets/shader/YUV_packed.frag | 2 +-\n src/apps/qcam/assets/shader/bayer_1x_packed.frag | 2 +-\n src/apps/qcam/assets/shader/bayer_8.frag | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/apps/qcam/assets/shader/RGB.frag b/src/apps/qcam/assets/shader/RGB.frag\nindex 4c374ac9..72439589 100644\n--- a/src/apps/qcam/assets/shader/RGB.frag\n+++ b/src/apps/qcam/assets/shader/RGB.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/apps/qcam/assets/shader/YUV_2_planes.frag b/src/apps/qcam/assets/shader/YUV_2_planes.frag\nindex 1d5d1206..d286f117 100644\n--- a/src/apps/qcam/assets/shader/YUV_2_planes.frag\n+++ b/src/apps/qcam/assets/shader/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/apps/qcam/assets/shader/YUV_3_planes.frag b/src/apps/qcam/assets/shader/YUV_3_planes.frag\nindex 8f788e90..8e3e0b4a 100644\n--- a/src/apps/qcam/assets/shader/YUV_3_planes.frag\n+++ b/src/apps/qcam/assets/shader/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/apps/qcam/assets/shader/YUV_packed.frag b/src/apps/qcam/assets/shader/YUV_packed.frag\nindex b9ef9d41..3c9e3e39 100644\n--- a/src/apps/qcam/assets/shader/YUV_packed.frag\n+++ b/src/apps/qcam/assets/shader/YUV_packed.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/apps/qcam/assets/shader/bayer_1x_packed.frag b/src/apps/qcam/assets/shader/bayer_1x_packed.frag\nindex f53f5575..19b13ad0 100644\n--- a/src/apps/qcam/assets/shader/bayer_1x_packed.frag\n+++ b/src/apps/qcam/assets/shader/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/src/apps/qcam/assets/shader/bayer_8.frag b/src/apps/qcam/assets/shader/bayer_8.frag\nindex 7e35ca88..aa7a1b00 100644\n--- a/src/apps/qcam/assets/shader/bayer_8.frag\n+++ b/src/apps/qcam/assets/shader/bayer_8.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n", "prefixes": [ "23/27" ] }