Patch Detail
Show a patch.
GET /api/1.1/patches/23223/?format=api
{ "id": 23223, "url": "https://patchwork.libcamera.org/api/1.1/patches/23223/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23223/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250422215920.4297-11-bryan.odonoghue@linaro.org>", "date": "2025-04-22T21:59:03", "name": "[10/27] libcamera: software_isp: Start the ISP thread in configure", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "1578d8bb23a077b2af27ae5277ba772b5d83063c", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23223/mbox/", "series": [ { "id": 5142, "url": "https://patchwork.libcamera.org/api/1.1/series/5142/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5142", "date": "2025-04-22T21:58:53", "name": "RFC: Add in a eGL based GPUISP in libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5142/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23223/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23223/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78275C3320\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 21:59:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2187268B39;\n\tTue, 22 Apr 2025 23:59:41 +0200 (CEST)", "from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1526168B25\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 23:59:33 +0200 (CEST)", "by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-43cfa7e7f54so2378965e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:59:33 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 14:59:31 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"mPvkJEjG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1745359172; x=1745963972;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=wJmpJgXrFEG5KEN1zSnXvlqRixc3EGKyYYkVA8Fbs4k=;\n\tb=mPvkJEjGOKGn0UcVsN9/UcxBEa+22ZED2/h5Cgio7sFL3lKCBuDdRqgwwxRzYXg6oE\n\tqos6IBBQ++kfOgtGIETRVTHKftZI5641ychmnrxEO06goxaGOCz/4QDz7EP1k3delqF5\n\t+LcbCrr3zENfRR/zl9YYEMFk858n73cEGVmDkLhKTPeMq7eAQFGzisjNX23MW+krrcYX\n\t//0Y1oc7PwSsHOp/pyHAsLbODcGNZMZKawJij5VyboRGG8ZqjgdEd8JMcjgH32ZL9iR0\n\tffa6kj38cqHu/9w692cfaPsltekXatAHmYSJoTlFIpnPs1xvh6S8E0VUwWNvXKG83KG1\n\tV7ww==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745359172; x=1745963972;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=wJmpJgXrFEG5KEN1zSnXvlqRixc3EGKyYYkVA8Fbs4k=;\n\tb=PP5JKOnxiD3U1IYUKAnWSnAeCQluJnaRb1mAmn0ZcNYWuxkKALDsKuxzRVDV7eEkaX\n\tHDkMaDNPMIdAiTfs8O7p9eell7mNq4WhJYvzLUs07BoZKGiagqvWp2W7OnvHkICXw67i\n\tjV05vmu4xQtWAQYPXdbIGWHSFxtJo96AhrqntfvI7w2oHi2edvQrO7YmjPlDVg1HEaXM\n\t0df4o//T0va5iYjIL6IXhQFnKtJiZYHp1J3ETNO6wkfTze77j0KIE0PGKhJowbnPEuGU\n\to5TDTI4bLlb2aUtbuyguJ4Z9JLXQM7DzMxlUh2VKIiYwJoIgyVCOjZh/0omPr92u3DZS\n\t7miw==", "X-Gm-Message-State": "AOJu0Yx9DWDqnTDyYW5Or7EjO1o3rLXbTJMqHRWx4q0Jis3KdKmZXcdl\n\tJXqVibQR/1zEppBZ1nrbycq53T6p5OnHcFwnXwdkxVp6li1uF7nNGO5tdA4uRx02RO89tiyhxKq\n\td558=", "X-Gm-Gg": "ASbGncsN+7mEE0lbQyH6edvsopYWBP7CmlleLVTSC3cRUb/4irge2XuvLA0wnAEXF38\n\tdhBrMgfgICZy212I98AVkGYs+0TJjiqCoSTFLQBs1M+3Z9KlW5x2tYyYeplLMwizurdBAYuVODy\n\toVbXh/R7GR0RbdFnEEmG+0Ahp36nyUMc4/T4eG98UeDWTvxAGj+27ujBylDMlYmDXyPkTnZjP37\n\tRWVVQy0wkx02fEaj8nBQATNFJv+2w65YsM/wwcuorY0AEhT3+ITMgdke0w8WoTkxpAX650NI/ip\n\tOFhelDIN0MRr0JTT48UgJDSv9K+r2oiyAqqu5HJoUngkv8vdtwn1cRnilPUxKKLcg5KeXzi95KZ\n\tVfo3366u+MGnPFjNFBlnh", "X-Google-Smtp-Source": "AGHT+IFubzulSIaleFtvZ/1sAxA9nhmqbt6gLnDqmrgkbiAZNHA75lMTureXquHN6a0/h2IC8/wejg==", "X-Received": "by 2002:a05:600c:698e:b0:440:6a68:826a with SMTP id\n\t5b1f17b1804b1-44091f6f402mr5184395e9.13.1745359172422; \n\tTue, 22 Apr 2025 14:59:32 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH 10/27] libcamera: software_isp: Start the ISP thread in\n\tconfigure", "Date": "Tue, 22 Apr 2025 22:59:03 +0100", "Message-ID": "<20250422215920.4297-11-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250422215920.4297-1-bryan.odonoghue@linaro.org>", "References": "<20250422215920.4297-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "OpenGL is not thread-safe and in fact associates invisible handles with the\nthreadid of the calling context.\n\nAs a result we need to make configure() and process() in SoftISP execute on\nthe same thread.\n\nMove start thread into configure() as a first step towards this.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 28e2a360..7bee8f06 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -159,8 +159,6 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t\t\t metadataReady.emit(frame, metadata);\n \t\t\t\t });\n \tipa_->setSensorControls.connect(this, &SoftwareIsp::setSensorCtrls);\n-\n-\tdebayer_->moveToThread(&ispWorkerThread_);\n }\n \n SoftwareIsp::~SoftwareIsp()\n@@ -262,6 +260,9 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tdebayer_->moveToThread(&ispWorkerThread_);\n+\tispWorkerThread_.start();\n+\n \treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n }\n \n@@ -343,7 +344,6 @@ int SoftwareIsp::start()\n \tif (ret)\n \t\treturn ret;\n \n-\tispWorkerThread_.start();\n \treturn 0;\n }\n \n", "prefixes": [ "10/27" ] }