Patch Detail
Show a patch.
GET /api/1.1/patches/23205/?format=api
{ "id": 23205, "url": "https://patchwork.libcamera.org/api/1.1/patches/23205/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23205/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250422124751.30409-2-barnabas.pocze@ideasonboard.com>", "date": "2025-04-22T12:47:50", "name": "[v1,1/2] apps: cam: capture_script: Disallow arrays of strings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8f6b4b8d272bfdfd156701d792cada33445a29b9", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23205/mbox/", "series": [ { "id": 5139, "url": "https://patchwork.libcamera.org/api/1.1/series/5139/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5139", "date": "2025-04-22T12:47:49", "name": "libcamera: controls: String controls as `std::string_view`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5139/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23205/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23205/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99772BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 12:48:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7DCB468AD0;\n\tTue, 22 Apr 2025 14:47:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F64E617E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:47:56 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C529666\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:45:48 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vMEsurTH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745325948;\n\tbh=q0h9SLaAylBdoyOGnrcJVJvmydinzayn/dBVekx7lwo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=vMEsurTHVU2Ba4old+Z69tK8DfPbBnCYtWmWfUYq4Yqs95Qj2jQwMRBgAUvHYTSsp\n\tSgS+6HLl0/5EMWtnjhTRRdFGEL8/IslyFbsHHTgAomJ+2ZeLmDIG7k2AHFrq4sWo5T\n\tgQHX9Ud7/iPnqNVcR1XFSiUOPYx7uhO1kKmTXScA=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 1/2] apps: cam: capture_script: Disallow arrays of strings", "Date": "Tue, 22 Apr 2025 14:47:50 +0200", "Message-ID": "<20250422124751.30409-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250422124751.30409-1-barnabas.pocze@ideasonboard.com>", "References": "<20250422124751.30409-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The current `ControlValue` mechanism does not support arrays\nof strings, the assignment in the removed snippet will in fact\ntrigger an assertion failure in `ControlValue::set()` because\n`sizeof(std::string) != ControlValueSize[ControlTypeString]`.\n\nFixes: b35f04b3c194 (\"cam: capture_script: Support parsing array controls\")\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/cam/capture_script.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/apps/cam/capture_script.cpp b/src/apps/cam/capture_script.cpp\nindex e7e69960e..fdf82efc0 100644\n--- a/src/apps/cam/capture_script.cpp\n+++ b/src/apps/cam/capture_script.cpp\n@@ -578,10 +578,6 @@ ControlValue CaptureScript::parseArrayControl(const ControlId *id,\n \t\tvalue = Span<const float>(values.data(), values.size());\n \t\tbreak;\n \t}\n-\tcase ControlTypeString: {\n-\t\tvalue = Span<const std::string>(repr.data(), repr.size());\n-\t\tbreak;\n-\t}\n \tdefault:\n \t\tstd::cerr << \"Unsupported control type\" << std::endl;\n \t\tbreak;\n", "prefixes": [ "v1", "1/2" ] }