Patch Detail
Show a patch.
GET /api/1.1/patches/23203/?format=api
{ "id": 23203, "url": "https://patchwork.libcamera.org/api/1.1/patches/23203/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23203/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250422124401.29968-1-barnabas.pocze@ideasonboard.com>", "date": "2025-04-22T12:44:01", "name": "[v1] libcamera: controls: Arrays of arrays are not supported", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ff2fbb6e9b5d6703ebbffe384b379c1e8df74fa0", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23203/mbox/", "series": [ { "id": 5138, "url": "https://patchwork.libcamera.org/api/1.1/series/5138/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5138", "date": "2025-04-22T12:44:01", "name": "[v1] libcamera: controls: Arrays of arrays are not supported", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5138/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23203/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23203/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 849BCC327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 12:44:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2449E68ACA;\n\tTue, 22 Apr 2025 14:44:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B1C4617E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:44:05 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D8D1250\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:41:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RrJJG1Yg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745325717;\n\tbh=FCmD+7muEQP5Snl3eI9Zefv91OFNc5uKqLvcTe5YPew=;\n\th=From:To:Subject:Date:From;\n\tb=RrJJG1YgejnHh5XeMn2Qb02eHUnK4aUOy7kolMeITxcTKdVhDXeLje3Wpi367vDeo\n\teaICdR/pddE6e6LEW+gK7va6YKuQBartpZzuj/UCEIqxjDWgK+DBK78KjOBIM2pKan\n\t5YXm6CzvVb+67efS0qiq8oLs6O5Ck8cqUO5OBBJ8=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] libcamera: controls: Arrays of arrays are not supported", "Date": "Tue, 22 Apr 2025 14:44:01 +0200", "Message-ID": "<20250422124401.29968-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Arrays of arrays, even arrays of strings, are not supported by\nthe current `ControlValue` mechanism, so disable them for now\nto trigger comptime errors if attempts are made to use them.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 326452540..427517a02 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -121,7 +121,7 @@ struct control_type<Point> {\n };\n \n template<typename T, std::size_t N>\n-struct control_type<Span<T, N>> : public control_type<std::remove_cv_t<T>> {\n+struct control_type<Span<T, N>, std::enable_if_t<control_type<std::remove_cv_t<T>>::size == 0>> : public control_type<std::remove_cv_t<T>> {\n \tstatic constexpr std::size_t size = N;\n };\n \n", "prefixes": [ "v1" ] }