Patch Detail
Show a patch.
GET /api/1.1/patches/23199/?format=api
{ "id": 23199, "url": "https://patchwork.libcamera.org/api/1.1/patches/23199/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23199/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250421155109.175930-4-barnabas.pocze@ideasonboard.com>", "date": "2025-04-21T15:51:07", "name": "[RFC,v1,3/5] apps: cam: sdl_sink: Use `SDLTexture1Plane` for `YUYV`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "635bf0bc0055a7ce62cb95e4abad73f6098369b7", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23199/mbox/", "series": [ { "id": 5136, "url": "https://patchwork.libcamera.org/api/1.1/series/5136/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5136", "date": "2025-04-21T15:51:04", "name": "apps: cam: Support {RGB,BGR}888 format", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5136/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23199/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23199/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DB61C32A2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Apr 2025 15:51:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7F7968ACE;\n\tMon, 21 Apr 2025 17:51:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BB3A68AC9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Apr 2025 17:51:14 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 807106D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Apr 2025 17:49:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kce19Pup\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745250547;\n\tbh=pG1DWR4OnmESyZHGPwuSWeqD/CJsRUp1cV2it43awvc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=kce19PupTX4aj6oAVNp58cOnMXVzAdVQRbBkTBHcaAj36hDqBLz1KTFIqWMCLnsTM\n\t2BA385Ob11JIve5iaio+DVvg/XEtfuKU7hf2fvj47CBAQrEyGjt4P/D14grB/uAU+D\n\tNvoVTLRqpxgBNTFP4GiZB2DzK4VT2o64jSgkpvNY=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 3/5] apps: cam: sdl_sink: Use `SDLTexture1Plane` for\n\t`YUYV`", "Date": "Mon, 21 Apr 2025 17:51:07 +0200", "Message-ID": "<20250421155109.175930-4-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250421155109.175930-1-barnabas.pocze@ideasonboard.com>", "References": "<20250421155109.175930-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`SDL_PIXELFORMAT_YUY2` designates a pixel foramt with a single plane,\nso use the generic `SDLTexture1Plan` to handle it.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/cam/sdl_sink.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\nindex 8355dd5ed..b295675dc 100644\n--- a/src/apps/cam/sdl_sink.cpp\n+++ b/src/apps/cam/sdl_sink.cpp\n@@ -22,6 +22,7 @@\n #include \"../common/event_loop.h\"\n #include \"../common/image.h\"\n \n+#include \"sdl_texture_1plane.h\"\n #ifdef HAVE_LIBJPEG\n #include \"sdl_texture_mjpg.h\"\n #endif\n@@ -74,7 +75,7 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n \t\tbreak;\n #endif\n \tcase libcamera::formats::YUYV:\n-\t\ttexture_ = std::make_unique<SDLTextureYUYV>(rect_, cfg.stride);\n+\t\ttexture_ = std::make_unique<SDLTexture1Plane>(rect_, SDL_PIXELFORMAT_YUY2, cfg.stride);\n \t\tbreak;\n \tdefault:\n \t\tstd::cerr << \"Unsupported pixel format \"\n", "prefixes": [ "RFC", "v1", "3/5" ] }