Patch Detail
Show a patch.
GET /api/1.1/patches/23197/?format=api
{ "id": 23197, "url": "https://patchwork.libcamera.org/api/1.1/patches/23197/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23197/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250421155109.175930-2-barnabas.pocze@ideasonboard.com>", "date": "2025-04-21T15:51:05", "name": "[RFC,v1,1/5] apps: cam: sdl_texture: Take list of buffers in span", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "15cd2530ff820510095f75e5a7d4ab09442ecdf0", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23197/mbox/", "series": [ { "id": 5136, "url": "https://patchwork.libcamera.org/api/1.1/series/5136/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5136", "date": "2025-04-21T15:51:04", "name": "apps: cam: Support {RGB,BGR}888 format", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5136/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23197/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23197/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A156BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Apr 2025 15:51:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 128BF68AD5;\n\tMon, 21 Apr 2025 17:51:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A32E068AC7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Apr 2025 17:51:13 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF8046D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Apr 2025 17:49:06 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L0w4sRqf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745250547;\n\tbh=2m6zsR/ZqfDdDyqs07oqupDdrD4S9VTLuvva1t5W4Q4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=L0w4sRqfmvBcCKU2ow1DU2YBjXQ1ThEbNvEjkiaxgDt9UlzRG/mN0PDaxFI7eygBE\n\tl4+3pCptN8JPcNVpsN+EzR42OjTpqDbTVbiRYVLjUo+TnYreBxVO1ZQGcKevrcXC1m\n\tmWcZbz3oI7JF5Dduk1iWRgWc51cJrLt/6GLuCg1c=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 1/5] apps: cam: sdl_texture: Take list of buffers in\n\tspan", "Date": "Mon, 21 Apr 2025 17:51:05 +0200", "Message-ID": "<20250421155109.175930-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250421155109.175930-1-barnabas.pocze@ideasonboard.com>", "References": "<20250421155109.175930-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/cam/sdl_texture.h | 4 ++--\n src/apps/cam/sdl_texture_mjpg.cpp | 2 +-\n src/apps/cam/sdl_texture_mjpg.h | 2 +-\n src/apps/cam/sdl_texture_yuv.cpp | 4 ++--\n src/apps/cam/sdl_texture_yuv.h | 4 ++--\n 5 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/apps/cam/sdl_texture.h b/src/apps/cam/sdl_texture.h\nindex 990f83b6e..39e1c7b38 100644\n--- a/src/apps/cam/sdl_texture.h\n+++ b/src/apps/cam/sdl_texture.h\n@@ -7,7 +7,7 @@\n \n #pragma once\n \n-#include <vector>\n+#include <libcamera/base/span.h>\n \n #include <SDL2/SDL.h>\n \n@@ -19,7 +19,7 @@ public:\n \tSDLTexture(const SDL_Rect &rect, uint32_t pixelFormat, const int stride);\n \tvirtual ~SDLTexture();\n \tint create(SDL_Renderer *renderer);\n-\tvirtual void update(const std::vector<libcamera::Span<const uint8_t>> &data) = 0;\n+\tvirtual void update(libcamera::Span<const libcamera::Span<const uint8_t>> data) = 0;\n \tSDL_Texture *get() const { return ptr_; }\n \n protected:\ndiff --git a/src/apps/cam/sdl_texture_mjpg.cpp b/src/apps/cam/sdl_texture_mjpg.cpp\nindex cace18fc6..ca49a1142 100644\n--- a/src/apps/cam/sdl_texture_mjpg.cpp\n+++ b/src/apps/cam/sdl_texture_mjpg.cpp\n@@ -76,7 +76,7 @@ int SDLTextureMJPG::decompress(Span<const uint8_t> data)\n \treturn 0;\n }\n \n-void SDLTextureMJPG::update(const std::vector<libcamera::Span<const uint8_t>> &data)\n+void SDLTextureMJPG::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)\n {\n \tdecompress(data[0]);\n \tSDL_UpdateTexture(ptr_, nullptr, rgb_.get(), stride_);\ndiff --git a/src/apps/cam/sdl_texture_mjpg.h b/src/apps/cam/sdl_texture_mjpg.h\nindex 37bed5f0e..be8a55fe7 100644\n--- a/src/apps/cam/sdl_texture_mjpg.h\n+++ b/src/apps/cam/sdl_texture_mjpg.h\n@@ -14,7 +14,7 @@ class SDLTextureMJPG : public SDLTexture\n public:\n \tSDLTextureMJPG(const SDL_Rect &rect);\n \n-\tvoid update(const std::vector<libcamera::Span<const uint8_t>> &data) override;\n+\tvoid update(libcamera::Span<const libcamera::Span<const uint8_t>> data) override;\n \n private:\n \tint decompress(libcamera::Span<const uint8_t> data);\ndiff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\nindex 480d7a379..80a5ec05d 100644\n--- a/src/apps/cam/sdl_texture_yuv.cpp\n+++ b/src/apps/cam/sdl_texture_yuv.cpp\n@@ -15,7 +15,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)\n {\n }\n \n-void SDLTextureNV12::update(const std::vector<libcamera::Span<const uint8_t>> &data)\n+void SDLTextureNV12::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)\n {\n \tSDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,\n \t\t\t data[1].data(), stride_);\n@@ -27,7 +27,7 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n {\n }\n \n-void SDLTextureYUYV::update(const std::vector<libcamera::Span<const uint8_t>> &data)\n+void SDLTextureYUYV::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)\n {\n \tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n }\ndiff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\nindex 29c756e77..db877f503 100644\n--- a/src/apps/cam/sdl_texture_yuv.h\n+++ b/src/apps/cam/sdl_texture_yuv.h\n@@ -14,7 +14,7 @@ class SDLTextureNV12 : public SDLTexture\n {\n public:\n \tSDLTextureNV12(const SDL_Rect &rect, unsigned int stride);\n-\tvoid update(const std::vector<libcamera::Span<const uint8_t>> &data) override;\n+\tvoid update(libcamera::Span<const libcamera::Span<const uint8_t>> data) override;\n };\n #endif\n \n@@ -22,5 +22,5 @@ class SDLTextureYUYV : public SDLTexture\n {\n public:\n \tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n-\tvoid update(const std::vector<libcamera::Span<const uint8_t>> &data) override;\n+\tvoid update(libcamera::Span<const libcamera::Span<const uint8_t>> data) override;\n };\n", "prefixes": [ "RFC", "v1", "1/5" ] }