Patch Detail
Show a patch.
GET /api/1.1/patches/23193/?format=api
{ "id": 23193, "url": "https://patchwork.libcamera.org/api/1.1/patches/23193/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23193/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250421153556.171192-4-barnabas.pocze@ideasonboard.com>", "date": "2025-04-21T15:35:54", "name": "[v2,3/5] libcamera: controls: Implement move ctor/assignment", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f96054f820568e99c07f1ac373d16dfd6dd14630", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23193/mbox/", "series": [ { "id": 5135, "url": "https://patchwork.libcamera.org/api/1.1/series/5135/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5135", "date": "2025-04-21T15:35:51", "name": "libcamera: controls: Move constructor/assignment + swap", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5135/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23193/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23193/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD0D0C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Apr 2025 15:36:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3211168ACE;\n\tMon, 21 Apr 2025 17:36:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCD7968AC3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Apr 2025 17:36:00 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1840D73E;\n\tMon, 21 Apr 2025 17:33:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"omWxDcj0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745249634;\n\tbh=kLmYPN72UTTxjzDEdUKeIyAXCAEfWQyE3Pjl4ZvlQ0w=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=omWxDcj0cMDfr70mJW2528gGMVkB7z2EtFGC31rCj1R2gUyBkWkb8pQBiliSdBg2y\n\tcr+THAz2HHwmo4QVla4WMoOd4fmK/8ZZ5FnhqLPVbaO5TD7o4IATfO3OdoCyi77+FZ\n\ttcQkRlthYG0Rv0fzLBDKm8wsS6TlkcppfUA5twQI=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v2 3/5] libcamera: controls: Implement move ctor/assignment", "Date": "Mon, 21 Apr 2025 17:35:54 +0200", "Message-ID": "<20250421153556.171192-4-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250421153556.171192-1-barnabas.pocze@ideasonboard.com>", "References": "<20250421153556.171192-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Implement a move constructor and move assignment operator for `ControlValue`.\nThe `ControlValue` type already has an \"empty\" state that is used when\ncreating a default constructed `ControlValue`, so have the moved-from\ninstance return to that state after move construction/assignment.\n\nThis is useful, for example, for `std::vector` as most implementations will\nuse the copy constructor when reallocating if no nothrow move constructor\nis available. Having a nothrow move constructor avoids the extra copies.\nIt is also useful when using temporaries of `ControlValue` with other\ncontainers such as `std::optional`, and it also makes `ControlInfo`\n\"cheaply\" move constructible/assignable.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/controls.h | 26 ++++++++++++++++++++++++++\n src/libcamera/controls.cpp | 18 ++++++++++++++++++\n 2 files changed, 44 insertions(+)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 3f3580036..866d667c4 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -14,6 +14,7 @@\n #include <stdint.h>\n #include <string>\n #include <unordered_map>\n+#include <utility>\n #include <vector>\n \n #include <libcamera/base/class.h>\n@@ -165,6 +166,31 @@ public:\n \tControlValue(const ControlValue &other);\n \tControlValue &operator=(const ControlValue &other);\n \n+\tControlValue(ControlValue &&other) noexcept\n+\t\t: type_(other.type_),\n+\t\t isArray_(std::exchange(other.isArray_, false)),\n+\t\t numElements_(std::exchange(other.numElements_, 0)),\n+\t\t storage_(std::exchange(other.storage_, {}))\n+\t{\n+\t\tother.type_ = ControlTypeNone;\n+\t}\n+\n+\tControlValue &operator=(ControlValue &&other) noexcept\n+\t{\n+\t\tif (this != &other) {\n+\t\t\trelease();\n+\n+\t\t\ttype_ = other.type_;\n+\t\t\tisArray_ = std::exchange(other.isArray_, false);\n+\t\t\tnumElements_ = std::exchange(other.numElements_, 0);\n+\t\t\tstorage_ = std::exchange(other.storage_, {});\n+\n+\t\t\tother.type_ = ControlTypeNone;\n+\t\t}\n+\n+\t\treturn *this;\n+\t}\n+\n \tControlType type() const { return type_; }\n \tbool isNone() const { return type_ == ControlTypeNone; }\n \tbool isArray() const { return isArray_; }\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex d384e1ef7..135e87613 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -155,6 +155,24 @@ ControlValue &ControlValue::operator=(const ControlValue &other)\n \treturn *this;\n }\n \n+/**\n+ * \\fn ControlValue::ControlValue(ControlValue &&other) noexcept\n+ * \\brief Move constructor for ControlValue\n+ * \\param[in] other The ControlValue object to move from\n+ *\n+ * Move constructs a ControlValue instance from \\a other.\n+ * After this operation \\a other will be in the same state\n+ * as a default constructed ControlValue instance.\n+ */\n+\n+/**\n+ * \\fn ControlValue &ControlValue::operator=(ControlValue &&other) noexcept\n+ * \\brief Move assignment operator for ControlValue\n+ * \\param[in] other The ControlValue object to move from\n+ *\n+ * \\sa ControlValue::ControlValue(ControlValue &&other)\n+ */\n+\n /**\n * \\fn ControlValue::type()\n * \\brief Retrieve the data type of the value\n", "prefixes": [ "v2", "3/5" ] }