Patch Detail
Show a patch.
GET /api/1.1/patches/23156/?format=api
{ "id": 23156, "url": "https://patchwork.libcamera.org/api/1.1/patches/23156/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23156/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250409212747.29280-1-laurent.pinchart@ideasonboard.com>", "date": "2025-04-09T21:27:47", "name": "[v2] meson: Do not automatically build documentation if sphinx-build-3 is found", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5d254c6820016f65e26acbd6651f655539332cce", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23156/mbox/", "series": [ { "id": 5120, "url": "https://patchwork.libcamera.org/api/1.1/series/5120/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5120", "date": "2025-04-09T21:27:47", "name": "[v2] meson: Do not automatically build documentation if sphinx-build-3 is found", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5120/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23156/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23156/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A92CC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 9 Apr 2025 21:28:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70CB76899E;\n\tWed, 9 Apr 2025 23:28:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 213AC627F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 9 Apr 2025 23:28:13 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41AC882E;\n\tWed, 9 Apr 2025 23:26:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NDLz3AUx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744233974;\n\tbh=q+/mO2ndVH75TbjpW/9nvV4JzVFMXX9lBT0msyOTCes=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=NDLz3AUx76Xw2riePTIqJBMUNGz+HngqlQpkFieq+Yb68p6kdT3uAMhHjeiJPez1G\n\tALBUVs0yGsGHGfmg8F3SRwxV3a3+kKR19kDcJF/40NdZe2H9QvEMjo5qMmzWWyEezC\n\teqRjFXt26B7gkkuB7PVWSYHH1FptuW9TqOFEOLZA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Quentin Schulz <foss+libcamera@0leil.net>, Quentin Schulz\n\t<quentin.schulz@cherry.de>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v2] meson: Do not automatically build documentation if\n\tsphinx-build-3 is found", "Date": "Thu, 10 Apr 2025 00:27:47 +0300", "Message-ID": "<20250409212747.29280-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Quentin Schulz <quentin.schulz@cherry.de>\n\nCommit aba567338b25 (\"Documentation: Move all dependencies into\nfeatures\") did an incomplete migration of the documentation boolean\noption into a documentation feature.\n\nIf sphinx-build-3 binary is found on the host system, the documentation\nis built, regardless of the value of the feature option.\n\nThis makes sure that sphinx-build-3 presence is only checked if the\ndocumentation feature is not disabled (which is the default, as it's\n\"auto\" by default).\n\nThis is essential for reproducibility for build systems where\nsphinx-build-3 may or may not be present when libcamera is built, and\nalso to declutter the generated package if documentation isn't desired.\n\nFixes: aba567338b25 (\"Documentation: Move all dependencies into features\")\nSigned-off-by: Quentin Schulz <quentin.schulz@cherry.de>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n\nQuentin, could you please test this version ?\n\n---\n Documentation/meson.build | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)\n\n\nbase-commit: 058f589ae36170935e537910f2c303b1c3ea03b3\n--\nRegards,\n\nLaurent Pinchart", "diff": "diff --git a/Documentation/meson.build b/Documentation/meson.build\nindex 6158320e177c..0fc5909d088e 100644\n--- a/Documentation/meson.build\n+++ b/Documentation/meson.build\n@@ -116,10 +116,8 @@ endif\n # Sphinx\n #\n\n-sphinx = find_program('sphinx-build-3', required : false)\n-if not sphinx.found()\n- sphinx = find_program('sphinx-build', required : get_option('documentation'))\n-endif\n+sphinx = find_program('sphinx-build-3', 'sphinx-build',\n+ required : get_option('documentation'))\n\n if sphinx.found()\n docs_sources = [\n", "prefixes": [ "v2" ] }