Patch Detail
Show a patch.
GET /api/1.1/patches/23135/?format=api
{ "id": 23135, "url": "https://patchwork.libcamera.org/api/1.1/patches/23135/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23135/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250404074624.2975182-2-paul.elder@ideasonboard.com>", "date": "2025-04-04T07:46:21", "name": "[1/3] libcamera: v4l2: Support fromEntityName with shared_ptr<MediaDevice>", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ca12c702ea1625164b98307f9f7f1dfa46d916ab", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23135/mbox/", "series": [ { "id": 5113, "url": "https://patchwork.libcamera.org/api/1.1/series/5113/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5113", "date": "2025-04-04T07:46:20", "name": "libcamera: pipeline: Use shared pointers for MediaDevice", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5113/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23135/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23135/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B889C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 4 Apr 2025 07:46:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1027689A8;\n\tFri, 4 Apr 2025 09:46:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FC5768994\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Apr 2025 09:46:36 +0200 (CEST)", "from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:cd45:d129:c842:b4ce])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 112B149E;\n\tFri, 4 Apr 2025 09:44:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l/sB304N\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743752682;\n\tbh=/pn/fLE22NrypW+Ye7UsywrcyAV80+/orN2kactWvLw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=l/sB304NuXuFYFPe675kVnH999/uWuzsmrJXT0clk3pW0riBNgzTxRXYfN9Hwzp0B\n\tIRS9lZmEx3eEuKTOSE5eO4uLiA8l/+id5uwLgKSZgiYMiQXLyRbxE2ON1CUsn1LQ8x\n\t3lgUpmL8810VAAWzw0pFdZLwtLZFxuVO3fQfuJFc=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH 1/3] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr<MediaDevice>", "Date": "Fri, 4 Apr 2025 16:46:21 +0900", "Message-ID": "<20250404074624.2975182-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.2", "In-Reply-To": "<20250404074624.2975182-1-paul.elder@ideasonboard.com>", "References": "<20250404074624.2975182-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nTo facilitate expanding the use of a shared_ptr<MediaDevice> in\npreference of a raw MediaDevice* pointer, add an additional\nimplementation for fromEntityName for both of v4l2_videodevice and\nv4l2_subdevice to support this type.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/internal/v4l2_subdevice.h | 2 ++\n include/libcamera/internal/v4l2_videodevice.h | 2 ++\n src/libcamera/v4l2_subdevice.cpp | 15 +++++++++++++++\n src/libcamera/v4l2_videodevice.cpp | 15 +++++++++++++++\n 4 files changed, 34 insertions(+)", "diff": "diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\nindex fa2a4a21eefb..08216cd56bc3 100644\n--- a/include/libcamera/internal/v4l2_subdevice.h\n+++ b/include/libcamera/internal/v4l2_subdevice.h\n@@ -163,6 +163,8 @@ public:\n \n \tstatic std::unique_ptr<V4L2Subdevice>\n \tfromEntityName(const MediaDevice *media, const std::string &entity);\n+\tstatic std::unique_ptr<V4L2Subdevice>\n+\tfromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n \n protected:\n \tstd::string logPrefix() const override;\ndiff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex ae6a76cb0209..e35fb11bc99f 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -228,6 +228,8 @@ public:\n \n \tstatic std::unique_ptr<V4L2VideoDevice>\n \tfromEntityName(const MediaDevice *media, const std::string &entity);\n+\tstatic std::unique_ptr<V4L2VideoDevice>\n+\tfromEntityName(std::shared_ptr<const MediaDevice>, const std::string &entity);\n \n \tV4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat) const;\n \ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 33279654db8c..13f5316a3fc3 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -1766,6 +1766,21 @@ V4L2Subdevice::fromEntityName(const MediaDevice *media,\n \treturn std::make_unique<V4L2Subdevice>(mediaEntity);\n }\n \n+/**\n+ * \\brief Create a new video subdevice instance from \\a entity in media device\n+ * \\a media\n+ * \\param[in] media The media device where the entity is registered\n+ * \\param[in] entity The media entity name\n+ *\n+ * \\return A newly created V4L2Subdevice on success, nullptr otherwise\n+ */\n+std::unique_ptr<V4L2Subdevice>\n+V4L2Subdevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n+\t\t\t const std::string &entity)\n+{\n+\treturn fromEntityName(media.get(), entity);\n+}\n+\n std::string V4L2Subdevice::logPrefix() const\n {\n \treturn \"'\" + entity_->name() + \"'\";\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex f5b3fa09d9a0..ce7be7deb91f 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -2109,6 +2109,21 @@ V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n \treturn std::make_unique<V4L2VideoDevice>(mediaEntity);\n }\n \n+/**\n+ * \\brief Create a new video device instance from \\a entity in media device\n+ * \\a media\n+ * \\param[in] media The media device where the entity is registered\n+ * \\param[in] entity The media entity name\n+ *\n+ * \\return A newly created V4L2VideoDevice on success, nullptr otherwise\n+ */\n+std::unique_ptr<V4L2VideoDevice>\n+V4L2VideoDevice::fromEntityName(std::shared_ptr<const MediaDevice> media,\n+\t\t\t\tconst std::string &entity)\n+{\n+\treturn fromEntityName(media.get(), entity);\n+}\n+\n /**\n * \\brief Convert \\a PixelFormat to a V4L2PixelFormat supported by the device\n * \\param[in] pixelFormat The PixelFormat to convert\n", "prefixes": [ "1/3" ] }