Patch Detail
Show a patch.
GET /api/1.1/patches/23122/?format=api
{ "id": 23122, "url": "https://patchwork.libcamera.org/api/1.1/patches/23122/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23122/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250403154925.382973-7-stefan.klug@ideasonboard.com>", "date": "2025-04-03T15:49:11", "name": "[v3,06/16] test: Add minimal test for Matrix", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1c84f42ef151d30d3ef133913bfcb77d700919ea", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23122/mbox/", "series": [ { "id": 5111, "url": "https://patchwork.libcamera.org/api/1.1/series/5111/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5111", "date": "2025-04-03T15:49:05", "name": "Some rkisp1 awb improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5111/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23122/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23122/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4612C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Apr 2025 15:49:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAAF1689F4;\n\tThu, 3 Apr 2025 17:49:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C389689B0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Apr 2025 17:49:53 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6d9d:9854:3fc1:4bb2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5537511E9;\n\tThu, 3 Apr 2025 17:47:59 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Aw4VqXci\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743695279;\n\tbh=Z1BF7QKEtfoUmzmAWPN4o6NI5gfCG08cz/aVy8qvqnA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Aw4VqXcio7g/sABCZdc8whfDrrJwQhn4Qeo++ZVWXRQLcrZtTbOUlnfZTog9v3V9/\n\tKdz7VcJat7Galey94Tjqq0tSYZrPP8kPHk+2rnVzAxkC71GRSEIOg8G+ajCU9MAIpg\n\tNJjZme4UDWG5qpHXR9jykMvCZEuJXsUuiF0hK470=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 06/16] test: Add minimal test for Matrix", "Date": "Thu, 3 Apr 2025 17:49:11 +0200", "Message-ID": "<20250403154925.382973-7-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250403154925.382973-1-stefan.klug@ideasonboard.com>", "References": "<20250403154925.382973-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a few tests for the Matrix class. This is not full fledged but at\nleast a starter.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Added this patch\n\nChanges in v3:\n- Fixed test class name\n---\n test/matrix.cpp | 53 ++++++++++++++++++++++++++++++++++++++++++++++++\n test/meson.build | 1 +\n 2 files changed, 54 insertions(+)\n create mode 100644 test/matrix.cpp", "diff": "diff --git a/test/matrix.cpp b/test/matrix.cpp\nnew file mode 100644\nindex 000000000000..3a1c8b4c88a2\n--- /dev/null\n+++ b/test/matrix.cpp\n@@ -0,0 +1,53 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas on Board Oy\n+ *\n+ * Vector tests\n+ */\n+\n+#include \"libcamera/internal/matrix.h\"\n+\n+#include <cmath>\n+#include <iostream>\n+\n+#include \"test.h\"\n+\n+using namespace libcamera;\n+\n+#define ASSERT_EQ(a, b) \\\n+\tif ((a) != (b)) { \\\n+\t\tstd::cout << #a \" != \" #b << \" (line \" << __LINE__ << \")\" \\\n+\t\t\t << std::endl; \\\n+\t\treturn TestFail; \\\n+\t}\n+\n+class MatrixTest : public Test\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\tMatrix<double, 3, 3> m1;\n+\n+\t\tASSERT_EQ(m1[0][0], 0.0);\n+\t\tASSERT_EQ(m1[0][1], 0.0);\n+\n+\t\tconstexpr Matrix<float, 2, 2> m2 = Matrix<float, 2, 2>().identity();\n+\t\tASSERT_EQ(m2[0][0], 1.0);\n+\t\tASSERT_EQ(m2[0][1], 0.0);\n+\t\tASSERT_EQ(m2[1][0], 0.0);\n+\t\tASSERT_EQ(m2[1][1], 1.0);\n+\n+\t\tMatrix<float, 2, 2> m3{ { 2.0, 0.0, 0.0, 2.0 } };\n+\t\tMatrix<float, 2, 2> m4 = m3.inverse();\n+\n+\t\tMatrix<float, 2, 2> m5 = m3 * m4;\n+\t\tASSERT_EQ(m5[0][0], 1.0);\n+\t\tASSERT_EQ(m5[0][1], 0.0);\n+\t\tASSERT_EQ(m5[1][0], 0.0);\n+\t\tASSERT_EQ(m5[1][1], 1.0);\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(MatrixTest)\ndiff --git a/test/meson.build b/test/meson.build\nindex 4095664994fd..52f04364e4fc 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -60,6 +60,7 @@ internal_tests = [\n {'name': 'file', 'sources': ['file.cpp']},\n {'name': 'flags', 'sources': ['flags.cpp']},\n {'name': 'hotplug-cameras', 'sources': ['hotplug-cameras.cpp']},\n+ {'name': 'matrix', 'sources': ['matrix.cpp']},\n {'name': 'message', 'sources': ['message.cpp']},\n {'name': 'object', 'sources': ['object.cpp']},\n {'name': 'object-delete', 'sources': ['object-delete.cpp']},\n", "prefixes": [ "v3", "06/16" ] }