Patch Detail
Show a patch.
GET /api/1.1/patches/23114/?format=api
{ "id": 23114, "url": "https://patchwork.libcamera.org/api/1.1/patches/23114/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23114/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250403074551.263496-6-stanislaw.gruszka@linux.intel.com>", "date": "2025-04-03T07:45:51", "name": "[v7,5/5] pipeline: simple: Reset delayedCtrls at start", "commit_ref": "18792b81cb122eb15cbda20bbcfe37d4bdb5c930", "pull_url": null, "state": "accepted", "archived": false, "hash": "5fca86882c18c9814006c5b8a648ef6cb870c578", "submitter": { "id": 211, "url": "https://patchwork.libcamera.org/api/1.1/people/211/?format=api", "name": "Stanislaw Gruszka", "email": "stanislaw.gruszka@linux.intel.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23114/mbox/", "series": [ { "id": 5109, "url": "https://patchwork.libcamera.org/api/1.1/series/5109/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5109", "date": "2025-04-03T07:45:46", "name": "libcamera: start frame events changes", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5109/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23114/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23114/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F2F3C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Apr 2025 07:46:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 225E0689AA;\n\tThu, 3 Apr 2025 09:46:22 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69FB5689A5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Apr 2025 09:46:20 +0200 (CEST)", "from orviesa001.jf.intel.com ([10.64.159.141])\n\tby orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2025 00:46:20 -0700", "from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.246.8.237])\n\tby smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2025 00:46:18 -0700" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"JbaAKXbZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1743666381; x=1775202381;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=xC5bNifgf4XOGco3L6/+Hy/vrlKFV/6DHm6pP/6liR8=;\n\tb=JbaAKXbZh86hIjFg2vlDWqFA3kzcqiUeSWx+gfqKUHQW4CzK9WDO8W1R\n\tpoXjCf+rg5AGjNhA+ODXCKOQYSVq5p6CeQ4m7gy8nZkXNEwLD+WKZlhme\n\tJ6g1+OOht8FBo793n49p2N2bSvtxYKDU6g19dokTV9bGPIe2Cek7oHNnj\n\tBkdLzvcILnsQdYZQtDKwdR6K7ocusEv8sPeX+qL/JA13I/mpcwGt15vnl\n\txUrovbAteyr5PQ+P2o+ChkrfEFbG/Ru7IdPGHUiNeqTsk5ObEbYv1KJmG\n\tavLskL5mB+Vyw3VEDX2EoKtQzwUHF4C4dv28+x2PC/EAj8nmWkLKSVw1l g==;", "X-CSE-ConnectionGUID": [ "KvhxXeyMSKOOMnFEPqghbA==", "HZkD2GQIRTWPjjqjmkhIRw==" ], "X-CSE-MsgGUID": [ "9rbI+54YRp2rCPhhEPHXuA==", "9jsrgDzRSaqTkaH3DHdoOA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6700,10204,11392\"; a=\"48721725\"", "E=Sophos;i=\"6.15,184,1739865600\"; d=\"scan'208\";a=\"48721725\"", "E=Sophos;i=\"6.15,184,1739865600\"; d=\"scan'208\";a=\"164159720\"" ], "X-ExtLoop1": "1", "From": "Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Hans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v7 5/5] pipeline: simple: Reset delayedCtrls at start", "Date": "Thu, 3 Apr 2025 09:45:51 +0200", "Message-Id": "<20250403074551.263496-6-stanislaw.gruszka@linux.intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>", "References": "<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Similar like in other pipelines (IPU3, rpi) avoid using stale\nvalues of DelayedControls class when the same camera is started\nsecond time.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\nCo-developed-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 262192b849e2..0432e591aa8d 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1462,6 +1462,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL\n \n \tvideo->bufferReady.connect(data, &SimpleCameraData::imageBufferReady);\n \n+\tdata->delayedCtrls_->reset();\n \tif (frameStartEmitter) {\n \t\tret = frameStartEmitter->setFrameStartEnabled(true);\n \t\tif (ret) {\n", "prefixes": [ "v7", "5/5" ] }