Patch Detail
Show a patch.
GET /api/1.1/patches/23111/?format=api
{ "id": 23111, "url": "https://patchwork.libcamera.org/api/1.1/patches/23111/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23111/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250403074551.263496-3-stanislaw.gruszka@linux.intel.com>", "date": "2025-04-03T07:45:48", "name": "[v7,2/5] pipeline: simple: Connect/disconnect frameStart signal at start/stop time", "commit_ref": "2f7bece17baaf40115c062bd537f63854d79a63e", "pull_url": null, "state": "accepted", "archived": false, "hash": "ffaa2b42a2d48da21ffdd3b1b964b18610010ef9", "submitter": { "id": 211, "url": "https://patchwork.libcamera.org/api/1.1/people/211/?format=api", "name": "Stanislaw Gruszka", "email": "stanislaw.gruszka@linux.intel.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23111/mbox/", "series": [ { "id": 5109, "url": "https://patchwork.libcamera.org/api/1.1/series/5109/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5109", "date": "2025-04-03T07:45:46", "name": "libcamera: start frame events changes", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5109/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23111/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23111/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A0D6C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Apr 2025 07:46:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4394D689A1;\n\tThu, 3 Apr 2025 09:46:09 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2CFC6899F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Apr 2025 09:46:07 +0200 (CEST)", "from orviesa001.jf.intel.com ([10.64.159.141])\n\tby orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2025 00:46:06 -0700", "from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.246.8.237])\n\tby smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2025 00:46:04 -0700" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"cgnjceXq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1743666368; x=1775202368;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=ZC3JSAvMBG9urzbiYzEWqBvKPrjnwU+bwCzZ4ckGhJY=;\n\tb=cgnjceXqS3NdtTynan0hQ1BRo2DL5OJZERDSALuZyMcjGStJMGrw8zYc\n\t0DbuAuTqWm01SruHWrt+V6l3ln/Jnq+D+O+sNl/PlNVyqFW0YuJoqWCzi\n\tnL6WvW7Mta8sFQA5DPAcb9Fitsu3RtgS0RZ8frmNw8l/T1bESZR+NX8j/\n\t4P6uibN5gPSlC3QKt/BJUTsUXAlAU/mRiyCFtt4vTdUmshVzW9KD+wM43\n\toy57JOlV4brQ+YM1dc7f8isDIqrKZkOIztUrc1u7bYl0Xz4oRi3wvQTQ0\n\t85zJP/+bLm7VQ53OjCJ4rkBHVVlY3BgAaqrX4lFJ/Qym9QfXeHyXKM4iO A==;", "X-CSE-ConnectionGUID": [ "UYn7JOVPTq6gXvBy9Vhiow==", "ghkcZ3KsR4eAWjqfqaQfyg==" ], "X-CSE-MsgGUID": [ "zZkmPaIRQGOHpBWO4WzB4A==", "QQyM7cwxQYCgpNlRLiPhEA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6700,10204,11392\"; a=\"48721684\"", "E=Sophos;i=\"6.15,184,1739865600\"; d=\"scan'208\";a=\"48721684\"", "E=Sophos;i=\"6.15,184,1739865600\"; d=\"scan'208\";a=\"164159630\"" ], "X-ExtLoop1": "1", "From": "Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Hans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v7 2/5] pipeline: simple: Connect/disconnect frameStart\n\tsignal at start/stop time", "Date": "Thu, 3 Apr 2025 09:45:48 +0200", "Message-Id": "<20250403074551.263496-3-stanislaw.gruszka@linux.intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>", "References": "<20250403074551.263496-1-stanislaw.gruszka@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The frameStart signal from the frame start emitter is connected in the\nconfigure() function, and is never disconnected. This means that each\ntime the camera is configured a new connection is made, causing the\nDelayedControls::applyControls() to be called multiple times. Fix it by\nconnecting and disconnecting the signal when starting and stopping the\ncamera.\n\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> # v6\nCo-developed-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nCo-developed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex fd0ccdca8ebe..06e805d89caa 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1371,8 +1371,6 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tdata->delayedCtrls_ =\n \t\tstd::make_unique<DelayedControls>(data->sensor_->device(),\n \t\t\t\t\t\t params);\n-\tdata->video_->frameStart.connect(data->delayedCtrls_.get(),\n-\t\t\t\t\t &DelayedControls::applyControls);\n \n \tStreamConfiguration inputCfg;\n \tinputCfg.pixelFormat = pipeConfig->captureFormat;\n@@ -1440,6 +1438,9 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL\n \n \tvideo->bufferReady.connect(data, &SimpleCameraData::imageBufferReady);\n \n+\tdata->video_->frameStart.connect(data->delayedCtrls_.get(),\n+\t\t\t\t\t &DelayedControls::applyControls);\n+\n \tret = video->streamOn();\n \tif (ret < 0) {\n \t\tstop(camera);\n@@ -1472,6 +1473,9 @@ void SimplePipelineHandler::stopDevice(Camera *camera)\n \tSimpleCameraData *data = cameraData(camera);\n \tV4L2VideoDevice *video = data->video_;\n \n+\tdata->video_->frameStart.disconnect(data->delayedCtrls_.get(),\n+\t\t\t\t\t &DelayedControls::applyControls);\n+\n \tif (data->useConversion_) {\n \t\tif (data->converter_)\n \t\t\tdata->converter_->stop();\n", "prefixes": [ "v7", "2/5" ] }