Patch Detail
Show a patch.
GET /api/1.1/patches/23106/?format=api
{ "id": 23106, "url": "https://patchwork.libcamera.org/api/1.1/patches/23106/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23106/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250402114928.937042-1-barnabas.pocze@ideasonboard.com>", "date": "2025-04-02T11:49:28", "name": "[v1] libcamera: pipeline: uvcvideo: Report new AeEnable control as available", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "76053036b6ce08bff34a382c3c3735e8c545b7fe", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23106/mbox/", "series": [ { "id": 5106, "url": "https://patchwork.libcamera.org/api/1.1/series/5106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5106", "date": "2025-04-02T11:49:28", "name": "[v1] libcamera: pipeline: uvcvideo: Report new AeEnable control as available", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23106/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23106/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC85BC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Apr 2025 11:49:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 888E86898E;\n\tWed, 2 Apr 2025 13:49:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3755E68979\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Apr 2025 13:49:39 +0200 (CEST)", "from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3EBB06A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Apr 2025 13:47:46 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r9Mg9tRK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743594466;\n\tbh=xLjGc9R2xa/DzVB+RJAhqX63Z7KY50oUu0tj8SzXKXY=;\n\th=From:To:Subject:Date:From;\n\tb=r9Mg9tRKNBgedgTNyKmI68u7nZ1J30uFHvhTRLEmiIvlCVxduZiPJFlwZbbVDavkL\n\tZa2Tr649Sm9+oQtMBfo/rdc0ToluOwitA0GYHBLUpvMdEJipJsjWdk9pg6nFWHJw+1\n\tXR5c8Yn9xzW8m1sNT8SIXgsCDixpyE4igx1CVdfI=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available", "Date": "Wed, 2 Apr 2025 13:49:28 +0200", "Message-ID": "<20250402114928.937042-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The `AeEnable` control is handled by the `Camera` class directly, but it\nstill has to be added because `ControlInfoMap`s are not easily modifiable.\n\nSee 338ba00e7abfe8 (\"ipa: rkisp1: agc: Report new AeEnable control as available\")\nfor more details and a similar change in rkisp1.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 5adc89fdb..ab180e820 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -583,6 +583,9 @@ int UVCCameraData::init(MediaDevice *media)\n \t/* Initialise the supported controls. */\n \tControlInfoMap::Map ctrls;\n \n+\t/* \\todo Move this to the Camera class */\n+\tctrls[&controls::AeEnable] = ControlInfo(false, true, true);\n+\n \tfor (const auto &ctrl : video_->controls()) {\n \t\tuint32_t cid = ctrl.first->id();\n \t\tconst ControlInfo &info = ctrl.second;\n", "prefixes": [ "v1" ] }